Skip to contentSkip to conversation

commit '[PATCH] kernel/softirq.c: EXPORT_UNUSED_SYMBOL'

PATCH New Christoph Hellwig 3 participants 3 messages Jul 11, 2006

lore
Share & tools
lore
#0 lore raw

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=80d6679a62fe45f440d042099d997a42e4e8c59d

open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway. Adrian, care to submit a patch to kill this senseless export entirely?

Acked-by
#1 lore raw
Quoted 7 lines · Christoph Hellwig

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=80d6679a62fe45f440d042099d997a42e4e8c59d

open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway. Adrian, care to submit a patch to kill this senseless export entirely?

good point.

Ingo

#2 lore raw

PATCH 1/1 unexport open_softirq

Christoph Hellwig:
open_softirq just enables a softirq. The softirq array is statically allocated so to add a new one you would have to patch the kernel. So there's no point to keep this export at all as any user would have to patch the enum in include/linux/interrupt.h anyway.

kernel/softirq.c renamed from kernel/softirq.c.old +0 -2
@@ -311,8 +311,6 @@
 	softirq_vec[nr].action = action;
 }
 
-EXPORT_UNUSED_SYMBOL(open_softirq);  /*  June 2006  */
-
 /* Tasklets */
 struct tasklet_head
 {