Skip to contentSkip to conversation

Dereference in drivers/usb/misc/adutux.c

PATCH In review Eric Sesterhenn 2 participants 3 messages Oct 5, 2006 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Dereference in drivers/usb/misc/adutux.c

hi,

in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)

drivers/usb/misc/adutux.c renamed from drivers/usb/misc/adutux.c.orig +2 -1
@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino
 	retval = adu_release_internal(dev);
 
 exit:
-	up(&dev->sem);
+	if(dev)
+		up(&dev->sem);
 	dbg(2," %s : leave, return value %d", __FUNCTION__, retval);
 	return retval;
 }
#1 lore raw
Quoted 10 lines · On Thu, 05 Oct 2006 12:01:29 +0200 Eric Sesterhenn wrote:

hi,

in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)

drivers/usb/misc/adutux.c static int adu_release(struct inode *ino · line 377

Quoted 9 lines
drivers/usb/misc/adutux.c renamed from drivers/usb/misc/adutux.c.orig +2 -1
@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino
 	retval = adu_release_internal(dev);
 
 exit:
-	up(&dev->sem);
+	if(dev)
+		up(&dev->sem);
 	dbg(2," %s : leave, return value %d", __FUNCTION__, retval);
 	return retval;
 }

if (dev)

space after if, for, while, etc. No space after function names.

---
~Randy

#2 lore raw

hi,

Quoted 4 lines
Quoted 3 lines

in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)

space after if, for, while, etc. No space after function names.

updated patch below.

drivers/usb/misc/adutux.c renamed from drivers/usb/misc/adutux.c.orig +2 -1
@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino
 	retval = adu_release_internal(dev);
 
 exit:
-	up(&dev->sem);
+	if (dev)
+		up(&dev->sem);
 	dbg(2," %s : leave, return value %d", __FUNCTION__, retval);
 	return retval;
 }