Dereference in drivers/usb/misc/adutux.c
PATCH 1/1 Dereference in drivers/usb/misc/adutux.c
hi,
in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/usb/misc/adutux.c renamed from drivers/usb/misc/adutux.c.orig +2 -1
@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino retval =adu_release_internal (dev); exit: -up (&dev->sem); +if (dev) +up (&dev->sem);dbg (2 ," %s : leave, return value %d" , __FUNCTION__, retval);return retval; }
Quoted 10 lines · On Thu, 05 Oct 2006 12:01:29 +0200 Eric Sesterhenn wrote:
hi,
in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)Signed-off-by Eric Sesterhenn <[email protected]>
drivers/usb/misc/adutux.c static int adu_release(struct inode *ino · line 377
Quoted 9 lines
drivers/usb/misc/adutux.c renamed from drivers/usb/misc/adutux.c.orig +2
-1@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino retval =adu_release_internal (dev); exit: -up (&dev->sem); +if (dev) +up (&dev->sem);dbg (2 ," %s : leave, return value %d" , __FUNCTION__, retval);return retval; }
if (dev)
space after if, for, while, etc. No space after function names.
---
~Randy
hi,
Quoted 4 lines
Quoted 3 lines
in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)space after if, for, while, etc. No space after function names.
updated patch below.
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/usb/misc/adutux.c renamed from drivers/usb/misc/adutux.c.orig +2 -1
@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino retval =adu_release_internal (dev); exit: -up (&dev->sem); +if (dev) +up (&dev->sem);dbg (2 ," %s : leave, return value %d" , __FUNCTION__, retval);return retval; }