Skip to contentSkip to conversation

ktime: Fix signed / unsigned mismatch in ktime_to_ns

PATCH In review Thomas Gleixner 2 participants 2 messages Nov 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ktime: Fix signed / unsigned mismatch in ktime_to_ns

The 32 bit implementation of ktime_to_ns returns unsigned value, while the 64 bit version correctly returns an signed value. There is no current user affected by this, but it has to be fixed, as ktime values can be negative.

--

include/linux/ktime.h +2 -2
Index: linux-2.6.19-rc5-mm1.orig/include/linux/ktime.h
===================================================================
@@ -248,9 +248,9 @@ static inline struct timeval ktime_to_ti
  *
  * Returns the scalar nanoseconds representation of kt
  */
-static inline u64 ktime_to_ns(const ktime_t kt)
+static inline s64 ktime_to_ns(const ktime_t kt)
 {
-	return (u64) kt.tv.sec * NSEC_PER_SEC + kt.tv.nsec;
+	return (s64) kt.tv.sec * NSEC_PER_SEC + kt.tv.nsec;
 }
 
 #endif

--