ktime: Fix signed / unsigned mismatch in ktime_to_ns
PATCH 1/1 ktime: Fix signed / unsigned mismatch in ktime_to_ns
The 32 bit implementation of ktime_to_ns returns unsigned value, while the 64 bit version correctly returns an signed value. There is no current user affected by this, but it has to be fixed, as ktime values can be negative.
Pointed-out-by Helmut Duregger <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
--
include/linux/ktime.h +2 -2
@@ -248,9 +248,9 @@ static inline struct timeval ktime_to_ti* * Returns the scalar nanoseconds representation of kt */ -static inline u64 ktime_to_ns (const ktime_t kt) +static inline s64 ktime_to_ns (const ktime_t kt) { -return (u64 ) kt.tv.sec *NSEC_PER_SEC + kt.tv.nsec; +return (s64 ) kt.tv.sec *NSEC_PER_SEC + kt.tv.nsec; }#endif
--
Quoted 6 lines · Thomas Gleixner
The 32 bit implementation of
ktime_to_nsreturns unsigned value, while the 64 bit version correctly returns an signed value. There is no current user affected by this, but it has to be fixed, as ktime values can be negative.Pointed-out-by Helmut Duregger <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>
Acked-by Ingo Molnar <[email protected]>
Ingo