Skip to contentSkip to conversation

atl1: Build files for Attansic L1 driver

PATCH In review Jay Cliburn 4 participants 6 messages Nov 19, 2006 – Nov 20, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 atl1: Build files for Attansic L1 driver

From: Jay Cliburn <[email protected]>

This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver.

---

 Kconfig       |   12 ++++++++++++
 Makefile      |    1 +
 atl1/Makefile |   30 ++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)
drivers/net/Kconfig +12 -0
index 6e863aa..f503d10 100644
@@ -2329,6 +2329,18 @@ config QLA3XXX
 	  To compile this driver as a module, choose M here: the module
 	  will be called qla3xxx.
 
+config ATL1
+	tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
+	depends on NET_PCI && PCI && EXPERIMENTAL
+	select CRC32
+	select MII
+	---help---
+	  This driver supports Attansic L1 gigabit ethernet adapter.
+
+	  To compile this driver as a module, choose M here.  The module
+	  will be called atl1.
+
+
 endmenu
 
 #
drivers/net/Makefile +1 -0
index f270bc4..b839af8 100644
@@ -8,6 +8,7 @@ obj-$(CONFIG_IXGB) += ixgb/
 obj-$(CONFIG_CHELSIO_T1) += chelsio/
 obj-$(CONFIG_EHEA) += ehea/
 obj-$(CONFIG_BONDING) += bonding/
+obj-$(CONFIG_ATL1) += atl1/
 obj-$(CONFIG_GIANFAR) += gianfar_driver.o
 
 gianfar_driver-objs := gianfar.o \
drivers/net/atl1/Makefile new file +30 -0
new file mode 100644
index 0000000..1a10b91
@@ -0,0 +1,30 @@
+################################################################################
+#
+# Attansic L1 gigabit ethernet driver
+# Copyright(c) 2005 - 2006 Attansic Corporation.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms and conditions of the GNU General Public License,
+# version 2, as published by the Free Software Foundation.
+#
+# This program is distributed in the hope it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# The full GNU General Public License is included in this distribution in
+# the file called "COPYING".
+#
+################################################################################
+
+#
+# Makefile for the Attansic L1 gigabit ethernet driver
+#
+
+obj-$(CONFIG_ATL1) += atl1.o
+
+atl1-objs := atl1_main.o atl1_hw.o atl1_ethtool.o atl1_param.o
#1 lore raw
Quoted 24 lines · On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:

From: Jay Cliburn <[email protected]>

This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver.

---

 Kconfig       |   12 ++++++++++++
 Makefile      |    1 +
 atl1/Makefile |   30 ++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)
drivers/net/Kconfig +3 -0
index 6e863aa..f503d10 100644
@@ -2329,6 +2329,18 @@ config QLA3XXX
 	  To compile this driver as a module, choose M here: the module
 	  will be called qla3xxx.
 
+config ATL1
+	tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
+	depends on NET_PCI && PCI && EXPERIMENTAL

drivers/net/Kconfig config QLA3XXX · line 2344

Quoted 10 lines
drivers/net/Kconfig +9 -0
+	select CRC32
+	select MII
+	---help---
+	  This driver supports Attansic L1 gigabit ethernet adapter.
+
+	  To compile this driver as a module, choose M here.  The module
+	  will be called atl1.
+
+
 endmenu

One problem here is that MII depends on NET_ETHERNET, which is 10/100 ethernet, which may not be enabled if someone has only gigabit ethernet. :)

I have a partial patch which moves MII and PHYLIB outside of NET_ETHERNET. That also makes them usable by USB or other non-drivers/net/ drivers, e.g., again without the need to enable NET_ETHERNET if someone only has USB ethernet. :(

I'll try to post it for review later today.

---
~Randy

#2 lore raw
Quoted 32 lines · Randy Dunlap
Quoted 30 lines · On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:

From: Jay Cliburn <[email protected]>

This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver.

---

 Kconfig       |   12 ++++++++++++
 Makefile      |    1 +
 atl1/Makefile |   30 ++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)
drivers/net/Kconfig +9 -0
index 6e863aa..f503d10 100644
@@ -2329,6 +2329,18 @@ config QLA3XXX
 	  To compile this driver as a module, choose M here: the module
 	  will be called qla3xxx.
 
+config ATL1
+	tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
+	depends on NET_PCI && PCI && EXPERIMENTAL
+	select CRC32
+	select MII
+	---help---
+	  This driver supports Attansic L1 gigabit ethernet adapter.
+
+	  To compile this driver as a module, choose M here.  The module
Quoted 8 lines

drivers/net/Kconfig config QLA3XXX · line 2344

Quoted 4 lines
drivers/net/Kconfig +3 -0
+	  will be called atl1.
+
+
 endmenu

One problem here is that MII depends on NET_ETHERNET, which is 10/100 ethernet, which may not be enabled if someone has only gigabit ethernet. :)

I'm actually quite inclined to rip out all MII support entirely. There's a lot of code in this driver that needs cleaning up cosmetically, and removing deprecated features would certainly speed things up. What do you think?

-- Chris

#3 lore raw
Quoted 42 lines · Chris Snook
Quoted 32 lines · Randy Dunlap
Quoted 30 lines · On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:

From: Jay Cliburn <[email protected]>

This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver.

---

 Kconfig       |   12 ++++++++++++
 Makefile      |    1 +
 atl1/Makefile |   30 ++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)
drivers/net/Kconfig +9 -0
index 6e863aa..f503d10 100644
@@ -2329,6 +2329,18 @@ config QLA3XXX
       To compile this driver as a module, choose M here: the module
       will be called qla3xxx.
 
+config ATL1
+    tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
+    depends on NET_PCI && PCI && EXPERIMENTAL
+    select CRC32
+    select MII
+    ---help---
+      This driver supports Attansic L1 gigabit ethernet adapter.
+
+      To compile this driver as a module, choose M here.  The module
Quoted 8 lines

drivers/net/Kconfig config QLA3XXX · line 2344

Quoted 4 lines
drivers/net/Kconfig +3 -0
+      will be called atl1.
+
+
 endmenu

One problem here is that MII depends on NET_ETHERNET, which is 10/100 ethernet, which may not be enabled if someone has only gigabit ethernet. :)

Quoted 1 line

I'm actually quite inclined to rip out all MII support entirely. There's a lot of code in this driver that needs cleaning up cosmetically, and removing deprecated features would certainly speed things up. What do you think?

All of that sounds like a good idea to me.
I didn't realize that MII support is deprecated. Do you mean that it's deprecated for gigabit?

Signature · 1 line
~Randy
#4 lore raw
Quoted 43 lines · Randy Dunlap
Quoted 42 lines · Chris Snook
Quoted 40 lines · Randy Dunlap
Quoted 24 lines · On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:

From: Jay Cliburn <[email protected]>

This patch contains the build files for the Attansic L1 gigabit ethernet adapter driver.

---

 Kconfig       |   12 ++++++++++++
 Makefile      |    1 +
 atl1/Makefile |   30 ++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)
drivers/net/Kconfig +3 -0
index 6e863aa..f503d10 100644
@@ -2329,6 +2329,18 @@ config QLA3XXX
       To compile this driver as a module, choose M here: the module
       will be called qla3xxx.
 
+config ATL1
+    tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
+    depends on NET_PCI && PCI && EXPERIMENTAL

drivers/net/Kconfig config QLA3XXX · line 2344

Quoted 10 lines
drivers/net/Kconfig +9 -0
+    select CRC32
+    select MII
+    ---help---
+      This driver supports Attansic L1 gigabit ethernet adapter.
+
+      To compile this driver as a module, choose M here.  The module
+      will be called atl1.
+
+
 endmenu

One problem here is that MII depends on NET_ETHERNET, which is 10/100 ethernet, which may not be enabled if someone has only gigabit ethernet. :)

Quoted 6 lines
Quoted 1 line

I'm actually quite inclined to rip out all MII support entirely. There's a lot of code in this driver that needs cleaning up cosmetically, and removing deprecated features would certainly speed things up. What do you think?

All of that sounds like a good idea to me.
I didn't realize that MII support is deprecated. Do you mean that it's deprecated for gigabit?

To be precise, mii-tool is deprecated, in favor of ethtool. There are other things that use mii capabilities. Bonding uses miimon, but the arp monitor is an alternative, and I don't think there's much overlap between workloads where people care about bonding and workloads people run on an Asus M2V motherboard, so I'm not sure there's much justification to bother supporting the feature, except completeness. Thus my question to netdev:

Would anyone care if we removed MII support from an experimental driver for a chip that is only known to ship on non-OEM desktop boards?

-- Chris

#5 lore raw

Chris Snook <[email protected]> :
[...]

Quoted 1 line

To be precise, mii-tool is deprecated, in favor of ethtool. There are

$ man mii-tool
[...]
       -v, --verbose
              Display  more  detailed  MII status information.  If used twice,
                                                                ^^^^^^^^^^^^^
              also display raw MII register contents.
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Is there a similar feature in ethtool ?

Signature · 1 line
Ueimor