Skip to contentSkip to conversation

: CCID 3: packet scheduling and packet size EWMA patch

PATCH Applied Gerrit Renker 2 participants 2 messages Nov 21, 2006

lore
Share & tools
lore
#0 lore raw

cover : CCID 3: packet scheduling and packet size EWMA patch

This change set contains the promised exponential moving average patch for the CCID 3 packet size `s' plus a few other improvements.

Patch 1: Fixes a bug in calculation of first t_nom and first t_ipi Patch 2: Simplifies control flow in the calculation of t_ipi Patch 3: Fixes a problem in calculation of scheduled packet transmission Patch 4: Simplifies ccid3_hc_tx_send_packet (also reads easier afterwards)
--> here I have a question:
return type of this function is `int', if return value > 0 it means a delay in milliseconds. Is there any point converting the function to one returning type long or is it always certain that the return value is small enough that this doesn't matter?
Patch 5: The EWMA patch for packet size `s'
Patch 6: Tidies up left-overs from patch 5

Regards,

Gerrit

#1 lore raw
Quoted 6 lines

Patch 4: Simplifies ccid3_hc_tx_send_packet (also reads easier afterwards)
--> here I have a question:
return type of this function is `int', if return value > 0 it means a delay in milliseconds. Is there any point converting the function to one returning type long or is it always certain that the return value is small enough that this doesn't matter?

The spec says you must send a packet at least once every 64 seconds so it should be no higher than 64000 which is well within range of int.

Ian

Signature · 7 lines
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand