Skip to content

: CCID 3: packet scheduling and packet size EWMA patch

Gerrit Renker dccp 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am 200611211544.54258@strip-the-willow

Versions newest first

  1. v1 Latest6 patches 34 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6: Fix bug in calculation of first t_nom and first t_ipinet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+5 -719 replies
2/6: Simplify control flow in the calculation of t_ipinet/dccp/ccids/ccid3.c+3 -78 replies
3/6: Fix calculation of t_ipi time of scheduled transmissionnet/dccp/ccids/ccid3.c+13 -50 replies
4/6: Simplify control flow of ccid3_hc_tx_send_packetnet/dccp/ccids/ccid3.c+18 -202 replies
5/6: Track RX/TX packet size `s' using moving-averagenet/dccp/ccids/ccid3.c+29 -192 replies
6/6: Tidy up unused structuresinclude/linux/dccp.h net/dccp/ccids/ccid3.h net/dccp/proto.c+0 -142 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchIan McDonald
1/6
2/6A-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6]: CCID 3: packet scheduling and packet size EWMA patch

This change set contains the promised exponential moving average patch for the CCID 3 packet size `s' plus a few other improvements.

Patch 1: Fixes a bug in calculation of first t_nom and first t_ipi Patch 2: Simplifies control flow in the calculation of t_ipi Patch 3: Fixes a problem in calculation of scheduled packet transmission Patch 4: Simplifies ccid3_hc_tx_send_packet (also reads easier afterwards)
--> here I have a question:
return type of this function is `int', if return value > 0 it means a delay in milliseconds. Is there any point converting the function to one returning type long or is it always certain that the return value is small enough that this doesn't matter?
Patch 5: The EWMA patch for packet size `s'
Patch 6: Tidies up left-overs from patch 5

Regards,

Gerrit