Skip to contentSkip to conversation

fix create_write_pipe() error check

PATCH New Akinobu Mita 1 participant 1 message Nov 27, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix create_write_pipe() error check

The return value of create_write_pipe()/create_read_pipe() should be checked by IS_ERR().

---
 kernel/kmod.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
kernel/kmod.c +4 -4
Index: work-fault-inject/kernel/kmod.c
===================================================================
@@ -307,14 +307,14 @@ int call_usermodehelper_pipe(char *path,
 		return 0;
 
 	f = create_write_pipe();
-	if (!f)
-		return -ENOMEM;
+	if (IS_ERR(f))
+		return PTR_ERR(f);
 	*filp = f;
 
 	f = create_read_pipe(f);
-	if (!f) {
+	if (IS_ERR(f)) {
 		free_write_pipe(*filp);
-		return -ENOMEM;
+		return PTR_ERR(f);
 	}
 	sub_info.stdin = f;