fix create_write_pipe() error check
PATCH 1/1 fix create_write_pipe() error check
The return value of create_write_pipe()/create_read_pipe() should be checked by IS_ERR().
Signed-off-by Akinobu Mita <[email protected]>
--- kernel/kmod.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
kernel/kmod.c +4 -4
@@ -307,14 +307,14 @@ int call_usermodehelper_pipe(char *path,return 0 ; f =create_write_pipe (); -if (!f) -return -ENOMEM ; +if (IS_ERR (f)) +return PTR_ERR (f); *filp = f; f =create_read_pipe (f); -if (!f) { +if (IS_ERR (f)) {free_write_pipe (*filp); -return -ENOMEM ; +return PTR_ERR (f); } sub_info.stdin = f;