Skip to contentSkip to conversation

: Fix warning message about illegal ACK

PATCH In review Gerrit Renker 2 participants 2 messages Dec 1, 2006 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 2/8 : Fix warning message about illegal ACK

[DCCP] Fix warning message about illegal ACK

This avoids a (harmless) warning message being printed at the DCCP server (the receiver of a DCCP half connection).

Incoming packets are both directed to

* ccid_hc_rx_packet_recv() for the server half
* ccid_hc_tx_packet_recv() for the client half

The message gets printed since on a server the client half is currently not sending data packets.
This is resolved for the moment by checking the DCCP-role first. In future times (bidirectional DCCP connections), this test may have to be more sophisticated.

---
 net/dccp/ccids/ccid3.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/dccp/ccids/ccid3.c +2 -1
@@ -555,7 +555,8 @@ static void ccid3_hc_tx_packet_recv(stru
 		hctx->ccid3hctx_idle = 1;   
 		break;
 	case TFRC_SSTATE_NO_SENT:
-		DCCP_WARN("Illegal ACK received - no packet has been sent\n");
+		if(dccp_sk(sk)->dccps_role = DCCP_ROLE_CLIENT)
+			DCCP_WARN("Illegal ACK received - no packet sent\n");
 		/* fall through */
 	case TFRC_SSTATE_TERM:		/* ignore feedback when closing */
 		break;