Skip to content

: 2 Bug fixes, all earlier patches revised

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200612011825.43747@strip-the-willow

Versions newest first

  1. v1 Latest8 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8: Fix CCID 3 bug in calculation of send ratenet/dccp/ccids/ccid3.c+52 -370 replies
2/8: Fix warning message about illegal ACKnet/dccp/ccids/ccid3.c+2 -11 reply
3/8: Document boundaries and limits of the TFRC lookup tablenet/dccp/ccids/lib/tfrc_equation.c+67 -551 reply
4/8: Fix small error in reverse lookupnet/dccp/ccids/lib/tfrc_equation.c+2 -21 reply
5/8: Add protection against invalid parametersnet/dccp/ccids/lib/tfrc_equation.c+19 -145 replies
6/8: Identify TFRC table limits and simplify codenet/dccp/ccids/lib/tfrc_equation.c+18 -91 reply
7/8: Deprecate TFRC_SMALLEST_Pnet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+5 -183 replies
8/8: Binary search for reverse TFRC lookupnet/dccp/ccids/lib/tfrc_equation.c+24 -141 reply

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/8
2/8A-b
3/8
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8]: 2 Bug fixes, all earlier patches revised

I have been doing bug hunting almost all day, two bug fixes are enclosed, for the remainder I am willing to stick my head into the code next week until the performance is up to a reasonable level and most of the known bugs are ironed out.

I went through the earlier patches and tossed out some material and re-arranged the TFRC lookup stuff in a different way. I think it is now much easier to read.

Patch 1: Bug fix: sending rates were calculated before X_recv/p were updated Patch 2: Removes the `Illegal ACK received message' [it is harmless]

Patches 3..8 correspond to the earlier TFRC patches (much smaller now):
Ian I would appreciate if you could have a look at these.
I have put in effort to explain them clearer. While the performance still is bad, these are a step forward. In particular, the parameter checking is useful to have. Should it be needed, I have documented all everything on
http://www.erg.abdn.ac.uk/users/gerrit/dccp/tfrc_documentation/doc/

Patch 3: just adds documentation for the TFRC lookup table; no code change, but
this provides the basis for all other patches (the formulas)

Patch 4: corrects a small error in the reverse lookup function; I
have now added a detailed explanation _why_ this is an error.

Patch 5: adds extensive parameter checking to the TFRC lookup routines.

Patch 6: wraps up the previous steps by simplifying the forward lookup.
It also defines a constant for the lowest possible resolution and adds a warning if p is greater than 0 and less than this threshold.

Patch 7: deprecates the use of TFRC_SMALLEST_P in ccid3.c. It is subsumed
by the minimum threshold set in Patch 4. The use of TFRC_SMALLEST_P is dangerous, as it masks large errors for low values of p. The resolution error is exactly given by:
(f(0.0001) - f(p))/f(p) * 100
and for TFRC_SMALLEST_P = 0.00004 this is still a value of about 58%! It is better to observe the warning messages and generate a new table in case there are too many warnings.

Patch 8: adds bin-search which should speed up TFRC reverse-lookup a little