: Fix small error in reverse lookup
PATCH 4/8 : Fix small error in reverse lookup
[DCCP]: Fix small error in reverse lookup of p for given f(p)
This fixes the following small error in tfrc_calc_x_reverse_lookup.
1) The table is generated by the following equations:
lookup[index][0] = g((index+1) * 1000000/TFRC_CALC_X_ARRSIZE);
lookup[index][1] = g((index+1) * TFRC_CALC_X_SPLIT/TFRC_CALC_X_ARRSIZE);
where g(q) is 1E6 * f(q/1E6)2) The reverse lookup assigns an entry in lookup[index][small]
3) This index needs to match the above, i.e.
* if small=0 then
p = (index + 1) * 1000000/TFRC_CALC_X_ARRSIZE
* if small=1 then
p = (index+1) * TFRC_CALC_X_SPLIT/TFRC_CALC_X_ARRSIZE
These are exactly the changes that the patch makes; previously the code did not conform to the way the lookup table was generated (this difference resulted in a mean error of about 1.12%).
Signed-off-by Gerrit Renker <[email protected]>
--- net/dccp/ccids/lib/tfrc_equation.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/dccp/ccids/lib/tfrc_equation.c +2 -2
@@ -647,9 +647,9 @@ u32 tfrc_calc_x_reverse_lookup(u32 fvalu ctr++;if (small) -return TFRC_CALC_X_SPLIT * ctr /TFRC_CALC_X_ARRSIZE ; +return (ctr +1 ) *TFRC_CALC_X_SPLIT /TFRC_CALC_X_ARRSIZE ;else -return 1000000 * ctr /TFRC_CALC_X_ARRSIZE ; +return (ctr +1 ) *1000000 /TFRC_CALC_X_ARRSIZE ; }EXPORT_SYMBOL_GPL (tfrc_calc_x_reverse_lookup);
Quoted 2 lines · Gerrit Renker
[DCCP]: Fix small error in reverse lookup of p for given f(p)
Signed-off-by Gerrit Renker <[email protected]>
Acked-by Ian McDonald <[email protected]>
Signature · 3 lines
Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group