Skip to contentSkip to conversation

Why SCSI module needed for PCI-IDE ATA only disks ?

PATCH In review Robert Hancock 3 participants 6 messages Dec 6, 2006 3 messages not in the archive libata

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): fa.juE97gahpb4n2kNNH/[email protected]

A message that is not in the archive (sent off-list or not yet received): fa.IqtlZas3d+ZPuhF6S6N/[email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 10 lines · Ed Sweetman
Quoted 8 lines · Jeff Garzik
Quoted 2 lines · Bernard Pidoux

I am asking why need to compile the following modules while I do not have any SCSI device ?

libata uses SCSI to provide a lot of infrastructure that it would otherwise have to recreate. Also, using SCSI meant that it automatically worked in existing installers.

Jeff

This confusion could easily be remedied by explaining the requirement in the Help output for libata drivers/section. Also, making a dependency in the menu (since there is one) or automatically selecting the required scsi items when you select a libata driver would seem logical. As it is, nothing is said of scsi requirements in menuconfig. Trying to boot a machine without compiling the scsi drivers (something you're allowed to do) results in a system that boots and initializes the ata busses but can't communicate to any of the drives on them, (useless).

You can't select libata drivers without the SCSI core. However, you can select libata drivers without the SCSI disk (sd) or the SCSI CD (sr) drivers. However, that's a legitimate configuration as you may have only hard disks, only CD drives, etc. and there would be no need to build the other module. This isn't a major problem for most standard configurations as those drivers are needed to handle things like USB and FireWire flash drives, external HDs/optical drives, etc. anyway.

Signature · 3 lines
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from [email protected]
Home Page: http://www.roberthancock.com/
#4 lore raw
Quoted 6 lines · Robert Hancock
Quoted 5 lines · Ed Sweetman
Quoted 4 lines · Jeff Garzik
Quoted 2 lines · Bernard Pidoux

I am asking why need to compile the following modules while I do not have any SCSI device ?

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

libata uses SCSI to provide a lot of infrastructure that it would otherwise have to recreate. Also, using SCSI meant that it automatically worked in existing installers.

Jeff

This confusion could easily be remedied by explaining the requirement in the Help output for libata drivers/section. Also, making a dependency in the menu (since there is one) or automatically selecting the required scsi items when you select a libata driver would seem logical. As it is, nothing is said of scsi requirements in menuconfig. Trying to boot a machine without compiling the scsi drivers (something you're allowed to do) results in a system that boots and initializes the ata busses but can't communicate to any of the drives on them, (useless).

You can't select libata drivers without the SCSI core. However, you can select libata drivers without the SCSI disk (sd) or the SCSI CD (sr) drivers. However, that's a legitimate configuration as you may have only hard disks, only CD drives, etc. and there would be no need to build the other module. This isn't a major problem for most standard configurations as those drivers are needed to handle things like USB and FireWire flash drives, external HDs/optical drives, etc. anyway.

What's not a legitimate configuration is libata drivers, no low level scsi drivers, no ide drivers and no sd,sr,sg drivers. Yet, that is the configuration the kernel currently gives you. How is that more correct than any of the 3 solutions I have suggested?

The point is there is nothing in the help section in libata to tell you that these "scsi" drivers are needed for disk / cdrom / generic device access in libata. Indeed, there is no obvious connection to the two.

Either configuration options need to be put in the libata directory that would just select the drivers (libata disk, cdrom, generic configuration options which would just enable the appropriate config variable, in other words in the menu config have two config directives which would enable the same drivers but be under different submenus to avoid confusion), or a short description in the help dialog to tell users that they have to enable those scsi drivers under the scsi section to use their drivers under the libata section.

It's not safe to assume people will have those drivers compiled because of usb or firewire or flash drives. Assuming that situation is 10 times more problematic than any possible argument against just selecting those scsi drivers automatically and letting the user deselect them as needed when they select a libata driver.

Personaly, I prefer a help dialog blurb explaining that the user has to enable certain scsi drivers to actually use their libata driven devices. That, at the very least, I believe is necessary and not asking much.

I've made patches before that impliment these trivial features in menuconfig. In the grand scheme of things this isn't that important to kernel development, but it's going to get more and more feedback as more people move to libata and eventually it will be fixed in some manner similar to those i've mentioned, I think it would just be better to do it now than wait until the mailing list is filled with end users asking why they need scsi when they obviously only have sata/ide and want to use libata.

#5 lore raw
Quoted 1 line · Ed Sweetman

What's not a legitimate configuration is libata drivers, no low level scsi drivers, no ide drivers and no sd,sr,sg drivers. Yet, that is the configuration the kernel currently gives you. How is that more correct than any of the 3 solutions I have suggested?

You can't build libata without low-level SCSI drivers. CONFIG_ATA automatically selects CONFIG_SCSI.

Signature · 3 lines
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from [email protected]
Home Page: http://www.roberthancock.com/
#6 lore raw
Quoted 5 lines · Robert Hancock
Quoted 1 line · Ed Sweetman

What's not a legitimate configuration is libata drivers, no low level scsi drivers, no ide drivers and no sd,sr,sg drivers. Yet, that is the configuration the kernel currently gives you. How is that more correct than any of the 3 solutions I have suggested?

You can't build libata without low-level SCSI drivers. CONFIG_ATA automatically selects CONFIG_SCSI.

config scsi isn't low level. There are no scsi controllers selected by selecting config_ata. Mening, that the user hasn't bothered going into the SCSI section. In effect you have a system that detects the ata controllers but nothing that can use the drives on them. How is that a valid system, a system where no drives are usable, but having some mention of the configuration in the Help of libata or automatically selecting those scsi_sd, sr, and sg drivers and letting the user deselect them as needed instead of the other way around Not a valid are more correct system?

No matter what when you select a scsi controller or libata controller you are going to need to select one or more of those scsi device drivers (sr,sg,sd) the issue is that when you are only using libata, you have no reason to bother with the scsi section so it's not readily apparent that you would need those block device drivers. I'm not saying we should auto select them, but I am saying that auto selecting is way better than keeping the kernel configuration the way it is and selecting none.

In the end the problem is in the layout of the config. SCSI is _THE_ device interface protocol but most people dont have scsi physical interfaces. The kernel differentiates between the two inside the SCSI section. This made sense before ide was marked for eventual replacement by libata. Now everything uses that scsi top level for block device access. That effectively makes those scsi block devices generic block devices. SCSI and LIBATA sections should have configuration options that are relevant to those physical devices and interfaces and not require options from eachother's sections to get drivers in their own sections to work. Massively shared config options shouldn't be stuck in some sub menu below where all the things that use it are located.
But that's for some much later version of the kernel to deal with (when ide is removed and such).

#7 lore raw

PATCH 1/1 ata/kconfig: Re: Why SCSI module needed for PCI-IDE ATA only disks ?

On Tue, 05 Dec 2006 21:46:54 -0500 Ed Sweetman wrote:

-ETOOMANYWORDS && -ENOPATCH, so here is one to consider. Help text can also be added. <supply text> This is similar to what USB storage already does.

---
From: Randy Dunlap <[email protected]>

Provide more clues about SCSI config options that are needed for libata (SATA/PATA) drivers.

---
 drivers/ata/Kconfig |    9 +++++++++
 1 file changed, 9 insertions(+)
drivers/ata/Kconfig +9 -0
@@ -17,6 +17,15 @@ config ATA
 	  that "speaks" the ATA protocol, also called ATA controller),
 	  because you will be asked for it.
 
+comment "NOTE: ATA enables basic SCSI support; *however*,"
+	depends on ATA
+comment "+ 'SCSI disk support', 'SCSI tape support', or '"
+	depends on ATA
+comment "+ 'SCSI CDROM support' may also be needed,"
+	depends on ATA
+comment "+ depending on your hardware configuration."
+	depends on ATA
+
 if ATA
 
 config SATA_AHCI
#8 lore raw

Re: [PATCH] ata/kconfig: Re: Why SCSI module needed for PCI-IDE ATA only disks ?

Quoted 7 lines · Randy Dunlap

On Tue, 05 Dec 2006 21:46:54 -0500 Ed Sweetman wrote:

-ETOOMANYWORDS && -ENOPATCH, so here is one to consider. Help text can also be added. <supply text> This is similar to what USB storage already does.

I provided a patch a couple weeks ago when I brought this topic up myself, but it was largely ignored because it wasn't the "add something to help dialog" solution... I figured that the wording would be changed anyway by the ide / libata guys or anyone else really involved with the kernel. So I opted to provide a patch that did one of the other solutions, namely, adding fake libata block devices in the libata section that would merely enable the scsi blk dev variables as if you had gone into the scsi section and did it the way it's currently done. In any case, prior to this thread, I got basically no response on the matter.

Your patch, however, should at least get into the next kernel revision with any additional help text that may be of use. Thanks.