Skip to contentSkip to conversation

: Two more bugs found, finer-grained resolution, time types

PATCH In review Gerrit Renker 2 participants 2 messages Dec 5, 2006 – Dec 8, 2006

lore
Share & tools
lore
#0 lore raw

cover : Two more bugs found, finer-grained resolution, time types

This is a small patch set - and two more bugs busted.

Patch 1: Checks against too large p. This cropped up in a
discussion a few days ago. In all cases, p < 100% as necessary.

Patch 2: Two optimisations for recomputing the sending rate X.

Patch 3: Two bug fixes - both are my own fault (shame :-|),
twice I did confuse max with min.

Patch 4: Finer-grained resolution of sending rates. This implements
the strategy sent earlier on
http://www.mail-archive.com/[email protected]/msg01040.html

Patch 5: Continues by replacing the remaining calls to usecs_div
with scaled_div32 (which includes overflow warning).

Patch 6: Simplifies the calculation of fval in reverse-lookup of p.

Patch 7: Changes in almost all cases the storage type for time
calculations to `signed'. Warning messages against negative results (which otherwise would go undetected) are added. I think it might be a (useful?) idea to do an analogous systematical check for sequence operations [with regard to the strange bug Ian reported where the sequence numbers were twisted].

#1 lore raw
Quoted 1 line · Gerrit Renker

This is a small patch set - and two more bugs busted.

Gerrit, Ian, I'll work on reviewing both this series and the other one tomorrow morning, hope to submit to DaveM before the window closes.

- Arnaldo