: Two more bugs found, finer-grained resolution, time types
Get series with b4
b4 am 200612052037.25304@strip-the-willowVersions newest first
- v1 Latest7 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | : Check against too large pnet/ | +9 | 0 replies | |
| 2/7 | : Two optimisations for sending rate recomputationnet/ | +15 | 1 reply | |
| 3/7 | : Fix two BUGs in sending rate computationnet/ | +2 | 1 reply | |
| 4/7 | : Finer-grained resolution of sending ratesinclude/ net/ net/ | +76 | 1 reply | |
| 5/7 | : Replace scaled division operationsnet/ | +2 | 1 reply | |
| 6/7 | : Simplify calculation for reverse lookup of pnet/ | +22 | 1 reply | |
| 7/7 | : Debug timeval operationsnet/ net/ | +33 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Ian McDonald |
|---|---|
| 1/7 | |
| 2/7 | A-b |
| 3/7 | A-b |
| 4/7 | A-b |
| 5/7 | A-b |
| 6/7 | A-b |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7]: Two more bugs found, finer-grained resolution, time types
This is a small patch set - and two more bugs busted.
Patch 1: Checks against too large p. This cropped up in a
discussion a few days ago. In all cases, p < 100% as necessary.
Patch 2: Two optimisations for recomputing the sending rate X.
Patch 3: Two bug fixes - both are my own fault (shame :-|),
twice I did confuse max with min.
Patch 4: Finer-grained resolution of sending rates. This implements
the strategy sent earlier on
http://www.mail-archive.com/[email protected]/msg01040.html
Patch 5: Continues by replacing the remaining calls to usecs_div
with scaled_div32 (which includes overflow warning).
Patch 6: Simplifies the calculation of fval in reverse-lookup of p.
Patch 7: Changes in almost all cases the storage type for time
calculations to `signed'. Warning messages against negative results (which otherwise would go undetected) are added. I think it might be a (useful?) idea to do an analogous systematical check for sequence operations [with regard to the strange bug Ian reported where the sequence numbers were twisted].