Skip to content

: Two more bugs found, finer-grained resolution, time types

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200612052037.25304@strip-the-willow

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7: Check against too large pnet/dccp/ccids/ccid3.c+9 -40 replies
2/7: Two optimisations for sending rate recomputationnet/dccp/ccids/ccid3.c+15 -111 reply
3/7: Fix two BUGs in sending rate computationnet/dccp/ccids/ccid3.c+2 -21 reply
4/7: Finer-grained resolution of sending ratesinclude/linux/tfrc.h net/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+76 -371 reply
5/7: Replace scaled division operationsnet/dccp/ccids/ccid3.c+2 -241 reply
6/7: Simplify calculation for reverse lookup of pnet/dccp/ccids/ccid3.c+22 -171 reply
7/7: Debug timeval operationsnet/dccp/ccids/ccid3.c net/dccp/dccp.h+33 -211 reply

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/7
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7]: Two more bugs found, finer-grained resolution, time types

This is a small patch set - and two more bugs busted.

Patch 1: Checks against too large p. This cropped up in a
discussion a few days ago. In all cases, p < 100% as necessary.

Patch 2: Two optimisations for recomputing the sending rate X.

Patch 3: Two bug fixes - both are my own fault (shame :-|),
twice I did confuse max with min.

Patch 4: Finer-grained resolution of sending rates. This implements
the strategy sent earlier on
http://www.mail-archive.com/[email protected]/msg01040.html

Patch 5: Continues by replacing the remaining calls to usecs_div
with scaled_div32 (which includes overflow warning).

Patch 6: Simplifies the calculation of fval in reverse-lookup of p.

Patch 7: Changes in almost all cases the storage type for time
calculations to `signed'. Warning messages against negative results (which otherwise would go undetected) are added. I think it might be a (useful?) idea to do an analogous systematical check for sequence operations [with regard to the strange bug Ian reported where the sequence numbers were twisted].