irlan: fix header build warning
Subsystems (2)
PATCH 1/1 irlan: fix header build warning
From: Randy Dunlap <[email protected]>
Fix compile warning when CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
--- include/net/irda/irlan_filter.h | 1 + 1 file changed, 1 insertion(+)
include/net/irda/irlan_filter.h +1 -0
@@ -28,6 +28,7 @@void irlan_check_command_param (struct irlan_cb *self,char *param,char *value);void irlan_filter_request (struct irlan_cb *self,struct sk_buff *skb); +struct seq_file ;void irlan_print_filter (struct seq_file *seq,int filter_type);#endif /* IRLAN_FILTER_H */
---
Hi Randy,
Thanks for the patch. Looks fine to me.
Quoted 8 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix compile warning when
CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'structseq_file' declared inside parameter listinclude/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you wantSigned-off-by Randy Dunlap <[email protected]>
Cheers,
Samuel.
David Miller
maintainerFrom: Randy Dunlap <[email protected]>
Date: Wed, 6 Dec 2006 11:44:07 -0800
Quoted 8 lines
From: Randy Dunlap <[email protected]>
Fix compile warning when
CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'structseq_file' declared inside parameter listinclude/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you wantSigned-off-by Randy Dunlap <[email protected]>
How about we protect these function externs with CONFIG_PROC_FS ifdefs instead?
Quoted 2 lines · On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote:
How about we protect these function externs with
CONFIG_PROC_FSifdefs instead?
Sure.
---
From: Randy Dunlap <[email protected]>
Fix compile warning when CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'struct seq_file' declared inside parameter list include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want
--- include/net/irda/irlan_filter.h | 2 ++ 1 file changed, 2 insertions(+)
include/net/irda/irlan_filter.h +2 -0
@@ -28,6 +28,8 @@void irlan_check_command_param (struct irlan_cb *self,char *param,char *value);void irlan_filter_request (struct irlan_cb *self,struct sk_buff *skb); +#ifdef CONFIG_PROC_FS void irlan_print_filter (struct seq_file *seq,int filter_type); +#endif #endif /* IRLAN_FILTER_H */
David Miller
maintainerFrom: Randy Dunlap <[email protected]>
Date: Wed, 6 Dec 2006 17:08:18 -0800
Quoted 10 lines · On Wed, 06 Dec 2006 16:57:17 -0800 (PST) David Miller wrote:
Quoted 3 lines
How about we protect these function externs with
CONFIG_PROC_FSifdefs instead?Sure.
---
From: Randy Dunlap <[email protected]>
Quoted 6 lines
Fix compile warning when
CONFIG_PROC_FS=n:
include/net/irda/irlan_filter.h:31: warning: 'structseq_file' declared inside parameter listinclude/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you wantSigned-off-by Randy Dunlap <[email protected]>
Looks great, applied.