Skip to contentSkip to conversation

update MTD OF implementation

PATCH In review Vitaly Wool 3 participants 3 messages Dec 6, 2006 – Dec 11, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 update MTD OF implementation

Hello folks,

the patch below updates the powerpc part of the MTD OF implementation with the new field probe-type and also fixes the typos/build warning for rom.c. So therefore it in a way supersedes the patch from Geoff which can be seen at http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028831.html.

 Documentation/powerpc/booting-without-of.txt |   19 +++++++++++--------
 arch/powerpc/sysdev/rom.c                    |    1 +
 2 files changed, 12 insertions(+), 8 deletions(-)
Documentation/powerpc/booting-without-of.txt +11 -8
index b3bd366..3399427 100644
@@ -1703,29 +1703,32 @@ platforms are moved over to use the flat
     Required properties:
 
      - device_type : has to be "rom"
-     - compatible : Should specify what this ROM device is compatible with
-       (i.e. "onenand"). Currently, this is most likely to be "direct-mapped"
-       (which corresponds to the MTD physmap mapping driver).
-     - regs : Offset and length of the register set (or memory mapping) for
+     - compatible : Should specify what this flash device is compatible with.
+       Currently, this is most likely to be "direct-mapped" (which
+       corresponds to the MTD physmap mapping driver).
+     - reg : Offset and length of the register set (or memory mapping) for
        the device.
+     - bank-width : Width of the flash data bus in bytes. Required
+       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
 
     Recommended properties :
 
-     - bank-width : Width of the flash data bus in bytes. Required
-       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
      - partitions : Several pairs of 32-bit values where the first value is
        partition's offset from the start of the device and the second one is
        partition size in bytes with LSB used to signify a read only
-       partititon (so, the parition size should always be an even number).
+       partition (so, the parition size should always be an even number).
      - partition-names : The list of concatenated zero terminated strings
        representing the partition names.
+     - probe-type : The type of probe which should be done for the chip
+       (JEDEC vs CFI actually). Valid ONLY for NOR flashes.
 
    Example:
 
  	flash@ff000000 {
  		device_type = "rom";
  		compatible = "direct-mapped";
- 		regs = <ff000000 01000000>;
+ 		probe-type = "CFI";
+ 		reg = <ff000000 01000000>;
  		bank-width = <4>;
  		partitions = <00000000 00f80000
  			      00f80000 00080001>;
arch/powerpc/sysdev/Makefile +0 -0
arch/powerpc/sysdev/rom.c +1 -0
index bf5b3f1..c855a3b 100644
@@ -9,6 +9,7 @@
 
 #include <linux/kernel.h>
 #include <asm/of_device.h>
+#include <asm/of_platform.h>
 
 static int __init powerpc_flash_init(void)
 {
Acked-by on v1 1/1
#1 lore raw

Hello.

Quoted 8 lines · Vitaly Wool

the patch below updates the powerpc part of the MTD OF implementation with the new field probe-type and also fixes the typos/build warning for rom.c. So therefore it in a way supersedes the patch from Geoff which can be seen at http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028831.html.

 Documentation/powerpc/booting-without-of.txt |   19 +++++++++++--------
 arch/powerpc/sysdev/rom.c                    |    1 +
 2 files changed, 12 insertions(+), 8 deletions(-)
Quoted 51 lines
Documentation/powerpc/booting-without-of.txt +11 -8
index b3bd366..3399427 100644
@@ -1703,29 +1703,32 @@ platforms are moved over to use the flat
     Required properties:
 
      - device_type : has to be "rom"
-     - compatible : Should specify what this ROM device is compatible with
-       (i.e. "onenand"). Currently, this is most likely to be "direct-mapped"
-       (which corresponds to the MTD physmap mapping driver).
-     - regs : Offset and length of the register set (or memory mapping) for
+     - compatible : Should specify what this flash device is compatible with.
+       Currently, this is most likely to be "direct-mapped" (which
+       corresponds to the MTD physmap mapping driver).
+     - reg : Offset and length of the register set (or memory mapping) for
        the device.
+     - bank-width : Width of the flash data bus in bytes. Required
+       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
 
     Recommended properties :
 
-     - bank-width : Width of the flash data bus in bytes. Required
-       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.
      - partitions : Several pairs of 32-bit values where the first value is
        partition's offset from the start of the device and the second one is
        partition size in bytes with LSB used to signify a read only
-       partititon (so, the parition size should always be an even number).
+       partition (so, the parition size should always be an even number).
      - partition-names : The list of concatenated zero terminated strings
        representing the partition names.
+     - probe-type : The type of probe which should be done for the chip
+       (JEDEC vs CFI actually). Valid ONLY for NOR flashes.
 
    Example:
 
  	flash@ff000000 {
  		device_type = "rom";
  		compatible = "direct-mapped";
- 		regs = <ff000000 01000000>;
+ 		probe-type = "CFI";
+ 		reg = <ff000000 01000000>;
  		bank-width = <4>;
  		partitions = <00000000 00f80000
  			      00f80000 00080001>;
arch/powerpc/sysdev/Makefile +0 -0
arch/powerpc/sysdev/rom.c +0 -0
index bf5b3f1..c855a3b 100644

arch/powerpc/sysdev/rom.c line 15

Quoted 7 lines
arch/powerpc/sysdev/rom.c +1 -0
@@ -9,6 +9,7 @@
 
 #include <linux/kernel.h>
 #include <asm/of_device.h>
+#include <asm/of_platform.h>
 
 static int __init powerpc_flash_init(void)
 {

WBR, Sergei

#2 lore raw
Quoted 10 lines · On Tue, 12 Dec 2006 00:58:29 +0300 Sergei Shtylyov wrote:

Hello.

Quoted 6 lines · Vitaly Wool

the patch below updates the powerpc part of the MTD OF implementation with the new field probe-type and also fixes the typos/build warning for rom.c. So therefore it in a way supersedes the patch from Geoff which can be seen at
http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028831.html.

Quoted 7 lines
Quoted 5 lines
 Documentation/powerpc/booting-without-of.txt |   19

+++++++++++-------- arch/powerpc/sysdev/rom.c
| 1 + 2 files changed, 12 insertions(+), 8 deletions(-)

Quoted 74 lines
Quoted 61 lines
(quoted diff) +0 -0

b/Documentation/powerpc/booting-without-of.txt index b3bd366..3399427 100644 --- a/Documentation/powerpc/booting-without-of.txt +++ b/Documentation/powerpc/booting-without-of.txt @@ -1703,29 +1703,32 @@ platforms are moved over to use the flat Required properties:

- device_type : has to be "rom"
- - compatible : Should specify what this ROM device is
compatible with
- (i.e. "onenand"). Currently, this is most likely to be
"direct-mapped"

(quoted diff) +0 -2
-       (which corresponds to the MTD physmap mapping driver).
-     - regs : Offset and length of the register set (or memory

mapping) for
+ - compatible : Should specify what this flash device is
compatible with.

Documentation/powerpc/booting-without-of.txt +3 -0
+       Currently, this is most likely to be "direct-mapped" (which
+       corresponds to the MTD physmap mapping driver).
+     - reg : Offset and length of the register set (or memory

mapping) for the device.

(quoted diff) +2 -0
+     - bank-width : Width of the flash data bus in bytes. Required
+       for the NOR flashes (compatible == "direct-mapped" and

others) ONLY.
Recommended properties :

(quoted diff) +0 -2
-     - bank-width : Width of the flash data bus in bytes. Required
-       for the NOR flashes (compatible == "direct-mapped" and

others) ONLY.
- partitions : Several pairs of 32-bit values where the first
value is partition's offset from the start of the device and the second one is partition size in bytes with LSB used to signify a read only
- partititon (so, the parition size should always be an even
number).
+ partition (so, the parition size should always be an even
number).
- partition-names : The list of concatenated zero terminated
strings representing the partition names.
+ - probe-type : The type of probe which should be done for the
chip

Documentation/powerpc/booting-without-of.txt +3 -1
+       (JEDEC vs CFI actually). Valid ONLY for NOR flashes.
 
    Example:
 
  	flash@ff000000 {
  		device_type = "rom";
  		compatible = "direct-mapped";
- 		regs = <ff000000 01000000>;
+ 		probe-type = "CFI";
+ 		reg = <ff000000 01000000>;
  		bank-width = <4>;
  		partitions = <00000000 00f80000
  			      00f80000 00080001>;
(quoted diff) +0 -0

b/arch/powerpc/sysdev/Makefile diff --git a/arch/powerpc/sysdev/rom.c b/arch/powerpc/sysdev/rom.c index bf5b3f1..c855a3b 100644 --- a/arch/powerpc/sysdev/rom.c +++ b/arch/powerpc/sysdev/rom.c

arch/powerpc/sysdev/rom.c line 15

Quoted 7 lines
arch/powerpc/sysdev/rom.c +1 -0
@@ -9,6 +9,7 @@
 
 #include <linux/kernel.h>
 #include <asm/of_device.h>
+#include <asm/of_platform.h>
 
 static int __init powerpc_flash_init(void)
 {

WBR, Sergei
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Signature · 1 line
Sincerely, Vitaly