Skip to contentSkip to conversation

: Remove redundant `len' test

PATCH In review Gerrit Renker 2 participants 2 messages Dec 15, 2006 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 6/8 : Remove redundant `len' test

[CCID3] Remove redundant `len' test

Since CCID3 avoids sending 0-byte data packets (cf. ccid3_hc_tx_send_packet), testing for zero-payload length, as performed by ccid3_hc_tx_update_s, is redundant - hence removed by this patch.

---
 net/dccp/ccids/ccid3.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
net/dccp/ccids/ccid3.c +2 -5
@@ -142,11 +142,8 @@ static void ccid3_hc_tx_update_x(struct 
  */
 static inline void ccid3_hc_tx_update_s(struct ccid3_hc_tx_sock *hctx, int len)
 {
-	if (unlikely(len = 0))
-		ccid3_pr_debug("Packet payload length is 0 - not updating\n");
-	else
-		hctx->ccid3hctx_s = hctx->ccid3hctx_s = 0 ? len :
-				    (9 * hctx->ccid3hctx_s + len) / 10;
+	hctx->ccid3hctx_s = hctx->ccid3hctx_s = 0 ? len :
+			    (9 * hctx->ccid3hctx_s + len) / 10;
 	/*
 	 * Note: We could do a potential optimisation here - when `s' changes,
 	 *	 recalculate sending rate and consequently t_ipi, t_delta, and
Acked-by on v1 6/8
#1 lore raw
Quoted 2 lines · Gerrit Renker

[CCID3] Remove redundant `len' test

Signature · 3 lines
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group