Skip to content

: Sequence numbers, larger windows revisited, minor cleanups

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200612151049.50073@strip-the-willow

Versions newest first

  1. v1 Latest8 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8: Sequence number arithmeticnet/dccp/dccp.h+24 -191 reply
2/8: Signed variant of dccp_delta_seqnonet/dccp/dccp.h+10 -31 reply
3/8: Make `before' relation unambiguousnet/dccp/dccp.h+3 -61 reply
4/8: Fix for follows48net/dccp/dccp.h+1 -31 reply
5/8: Move debugging macro to header filenet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+8 -70 replies
6/8: Remove redundant `len' testnet/dccp/ccids/ccid3.c+2 -51 reply
7/8: Re-order CCID 3 source filenet/dccp/ccids/ccid3.c+45 -431 reply
8/8: Truly larger initial windowsnet/dccp/ccids/ccid3.c+5 -51 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8]: Sequence numbers, larger windows revisited, minor cleanups

This is a small set of patches, likely the last for this year. I have run my whitespace test script over them and gave them a test run (sorry, the sparc64 is not yet up).

Patch 1: Adds the add48/sub48 functions to dccp.h. This was
inspired by Ian McDonald

Patch 2: Changes dccp_delta_seqno(a, b) to return signed numbers,
depending on whether a sequence number a is `before' b or not

Patch 3: Makes `before48' unambiguous, following the previous discussions.
I have kept Arnaldo's basic concept, only the subtraction and comparison changes. Thanks to Eddie for discussions.

Patch 4: Fixes a problem with follows48, solved as a byproduct of dccp_delta_seqno

Patch 5: Moves ccid3_pr_debug into header file so that the macro can be used by
other files. Thanks to Ian McDonald who raised this.

Patch 6: Removes a now redundant `len' test in ccid3_hc_tx_update_s

Patch 7: Re-orders ccid3.c in a TX/RX section, following the ordering in packet_history.{c,h}

Patch 8: Now uses MSS instead of `s' for larger windows -- and now finally also larger throughput :)