Skip to contentSkip to conversation

musb_hdrc, remove MGC_WriteCsr16()

PATCH In review David Brownell 1 participant 1 message Jan 18, 2007

Subsystems (2)
USB MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

David Brownell

author
#0 lore raw

PATCH 3/3 musb_hdrc, remove MGC_WriteCsr16()

More camelcase fixes: remove MGC_WriteCsr16.

This review also caught a latent bug in the GIT tree, where peripheral side shared fifo OUT endpoints (not used by the standard set of gadget drivers) would init wrong since they read from the wrong register.

Signed-off-by David Brownell <[email protected]>
drivers/usb/musb/musbdefs.h +1 -13
Index: o26/drivers/usb/musb/musbdefs.h
===================================================================
@@ -203,8 +203,7 @@ enum musb_g_ep0_state {
  */
 
 #if defined(CONFIG_ARCH_DAVINCI) || defined(CONFIG_ARCH_OMAP243X)
-/* REVISIT "flat" takes about 1% more object code space and can't be very
- * noticeable for speed differences.  But for now indexed access seems to
+/* REVISIT indexed access seemed to
  * misbehave (on DaVinci) for at least peripheral IN ...
  */
 #define	MUSB_FLAT_REG

@@ -228,17 +227,6 @@ enum musb_g_ep0_state {
 #define	MGC_END_OFFSET			MGC_INDEXED_OFFSET
 #endif
 
-/* FIXME: replace with musb_readcsr(hw_ep *, REGNAME), etc
- * using hw_ep->regs, for all access except writing INDEX
- */
-#ifdef	MUSB_FLAT_REG
-#define MGC_WriteCsr16(_pBase, _bOffset, _bEnd, _bData) \
-	musb_writew((_pBase), MGC_END_OFFSET((_bEnd), (_bOffset)), (_bData))
-#else
-#define MGC_WriteCsr16(_pBase, _bOffset, _bEnd, _bData) \
-	musb_writew(_pBase, (_bOffset + 0x10), _bData)
-#endif
-
 /****************************** FUNCTIONS ********************************/
 
 #define MUSB_HST_MODE(_pthis)\
drivers/usb/musb/musb_gadget.c +30 -33

221 lines not on this page · raw message

drivers/usb/musb/musb_host.c +34 -39

225 lines not on this page · raw message