Skip to content

musb_hdrc, remove MGC_{Read,Write}Csr{8,16}

David Brownell linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3musb_hdrc, remove MGC_{Read,Write}Csr8()drivers/usb/musb/musb_host.c drivers/usb/musb/musbdefs.h+13 -200 replies
2/3musb_hdrc, remove MGC_ReadCsr16()drivers/usb/musb/musb_gadget.c drivers/usb/musb/musb_host.c drivers/usb/musb/musbdefs.h+55 -670 replies
3/3musb_hdrc, remove MGC_WriteCsr16()drivers/usb/musb/musb_gadget.c drivers/usb/musb/musb_host.c drivers/usb/musb/musbdefs.h+65 -850 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/3] musb_hdrc, remove MGC_{Read,Write}Csr{8,16}

Folowing this are three patches removing those annoying CaMeLcAsE macros cluttering up the sources ... this is the last significant such fix that's needed IMO, although certainly struct members, variables, and function/procedure parameters can be cleaned up.

Given that, issues I know about on the musb_hdrc code in GIT right now, observed on tusb6010 but not tested on DaVinci, include:

- Hmm, host side was not enumerating ... new failure
- DMA wierdness of various types
- Various issues with suspend states and remote wakeup

That list is just so anyone running into them needn't be too surprised.

- Dave

Read the cover letter in its thread