Skip to contentSkip to conversation

floppy.c: Remove pointless register keywords

PATCH RESEND In review Jesper Juhl 1 participant 1 message Mar 19, 2007

Subsystems (2)
Block layer Floppy driver
lore
Share & tools
lore

Jesper Juhl

author
#0 lore raw

PATCH RESEND 2/5 floppy.c: Remove pointless register keywords

This patch removes the use of the 'register' keyword from floppy.c

Marking some variables 'register' may have made sense in the past (though I doubt it for these ones), but these days I very much suspect that we would rather grant gcc more freedom in how to handle the variables and I doubt very much that in this day and age optimizing access to variables via 'register' makes any sense for a floppy driver. Let's just get rid of it.

Signed-off-by Jesper Juhl <[email protected]>
Acked-by Alan Cox <[email protected]>
Acked-by Bartlomiej Zolnierkiewicz <[email protected]>

---

drivers/block/floppy.c +2 -2
index 5da54b8..dea7c4f 100644
@@ -791,7 +791,7 @@ static inline int is_selected(int dor, int unit)
 
 static int set_dor(int fdc, char mask, char data)
 {
-	register unsigned char drive, unit, newdor, olddor;
+	unsigned char drive, unit, newdor, olddor;
 
 	if (FDCS->address == -1)
 		return -1;

@@ -946,7 +946,7 @@ static void motor_off_callback(unsigned long nr)
 static void floppy_off(unsigned int drive)
 {
 	unsigned long volatile delta;
-	register int fdc = FDC(drive);
+	int fdc = FDC(drive);
 
 	if (!(FDCS->dor & (0x10 << UNIT(drive))))
 		return;