Skip to contentSkip to conversation

bcm43xx-mac80211: fix radio_set_tx_iq

PATCH In review Stefano Brivio 2 participants 2 messages Mar 23, 2007 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcm43xx-mac80211: fix radio_set_tx_iq

Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are already leftshifted. Thanks to Michael Buesch for spotting this.

---

drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c +1 -1
index 10a82b1..a2c52f6 100644
@@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4
 
 	for (i = 0; i < 5; i++) {
 		for (j = 0; j < 5; j++) {
-			if (tmp == (data_high[i] << 4 | data_low[j])) {
+			if (tmp == (data_high[i] | data_low[j])) {
 				bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
 				return;
 			}
#1 lore raw
Quoted 4 lines · Stefano Brivio

Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are already leftshifted. Thanks to Michael Buesch for spotting this.

I think you should probably write your APHY stuff against the development tree, as only that has proper support for multiple 802.11 cores (4309).

Quoted 13 lines
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c +1 -1
index 10a82b1..a2c52f6 100644
@@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4
 
 	for (i = 0; i < 5; i++) {
 		for (j = 0; j < 5; j++) {
-			if (tmp == (data_high[i] << 4 | data_low[j])) {
+			if (tmp == (data_high[i] | data_low[j])) {
 				bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
 				return;
 			}
Signature · 1 line
Greetings Michael.