bcm43xx-mac80211: fix radio_set_tx_iq
PATCH 1/1 bcm43xx-mac80211: fix radio_set_tx_iq
Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are already leftshifted. Thanks to Michael Buesch for spotting this.
Signed-off-by Stefano Brivio <[email protected]>
---
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c +1 -1
@@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4for (i =0 ; i <5 ; i++) {for (j =0 ; j <5 ; j++) { -if (tmp == (data_high[i] <<4 | data_low[j])) { +if (tmp == (data_high[i] | data_low[j])) {bcm43xx_phy_write (dev,0x0069 , (i - j) <<8 |0x00C0 );return ; }
Quoted 4 lines · Stefano Brivio
Fix a duplicated leftshift in
bcm43xx_radio_set_tx_iq.data_highvalues are already leftshifted. Thanks to Michael Buesch for spotting this.Signed-off-by Stefano Brivio <[email protected]>
I think you should probably write your APHY stuff against the development tree, as only that has proper support for multiple 802.11 cores (4309).
Quoted 13 lines
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c +1
-1@@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4for (i =0 ; i <5 ; i++) {for (j =0 ; j <5 ; j++) { -if (tmp == (data_high[i] <<4 | data_low[j])) { +if (tmp == (data_high[i] | data_low[j])) {bcm43xx_phy_write (dev,0x0069 , (i - j) <<8 |0x00C0 );return ; }
Signature · 1 line
Greetings Michael.