Skip to contentSkip to conversation

mtdcore.c: share syms with mtd_blkdev.c

PATCH In review Ben Dooks 2 participants 2 messages May 28, 2007 – May 29, 2007 Memory technology devices (MTD)

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 mtdcore.c: share syms with mtd_blkdev.c

Fix the sparse warnings generated by the implicit dependency of mtd_blkdevs.c and mtd_core.c for the two symbols mtd_table and mtd_table_mutex. This is done by adding an local header file mtdcore.h to define these (including the warning about the non-proliferation of these symbols).

Signed-off-by Ben Dooks <[email protected]>
drivers/mtd/mtdcore.h +11 -0
@@ -0,0 +1,11 @@
+/* linux/drivers/mtd/mtdcore.h
+ *
+ * Header file for driver private mtdcore exports
+ *
+ */
+
+/* These are exported solely for the purpose of mtd_blkdevs.c. You
+   should not use them for _anything_ else */
+
+extern struct mutex mtd_table_mutex;
+extern struct mtd_info *mtd_table[MAX_MTD_DEVICES];
drivers/mtd/mtd_blkdevs.c renamed from /drivers/mtd/mtd_blkdevs.c +2 -3
diff -urpN -X linux-2.6.22-rc3-sparse1//Documentation/dontdiff linux-2.6.22-rc3-sparse1//drivers/mtd/mtd_blkdevs.c linux-2.6.22-rc3-sparse2/drivers/mtd/mtd_blkdevs.c
@@ -23,10 +23,9 @@
 #include <linux/kthread.h>
 #include <asm/uaccess.h>
 
-static LIST_HEAD(blktrans_majors);
+#include "mtdcore.h"
 
-extern struct mutex mtd_table_mutex;
-extern struct mtd_info *mtd_table[];
+static LIST_HEAD(blktrans_majors);
 
 struct mtd_blkcore_priv {
 	struct task_struct *thread;
drivers/mtd/mtdcore.c renamed from /drivers/mtd/mtdcore.c +2 -0
diff -urpN -X linux-2.6.22-rc3-sparse1//Documentation/dontdiff linux-2.6.22-rc3-sparse1//drivers/mtd/mtdcore.c linux-2.6.22-rc3-sparse2/drivers/mtd/mtdcore.c
@@ -22,6 +22,8 @@
 
 #include <linux/mtd/mtd.h>
 
+#include "mtdcore.h"
+
 /* These are exported solely for the purpose of mtd_blkdevs.c. You
    should not use them for _anything_ else */
 DEFINE_MUTEX(mtd_table_mutex);
#1 lore raw
Quoted 6 lines · Ben Dooks

Fix the sparse warnings generated by the implicit dependency of mtd_blkdevs.c and mtd_core.c for the two symbols mtd_table and mtd_table_mutex. This is done by adding an local header file mtdcore.h to define these (including the warning about the non-proliferation of these symbols).

Looks good.

josh