Skip to contentSkip to conversation

Guard against a potential NULL pointer dereference in old_capi_manufacturer()

PATCH Superseded Jesper Juhl 1 participant 1 message Jun 24, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Guard against a potential NULL pointer dereference in old_capi_manufacturer()

In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call to get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then we'll be dereferencing a NULL pointer in the very next line.

(Found by Coverity checker as bug #402)

---

 drivers/isdn/capi/kcapi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/isdn/capi/kcapi.c +0 -0
index 3ed34f7..3f9e962 100644
@@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void 

__user *data)
return -EFAULT;
}
card = get_capi_ctr_by_nr(ldef.contr);
+ if (!card)
+ return -EINVAL;
card = capi_ctr_get(card);
if (!card)
return -ESRCH;