Skip to contentSkip to conversation

m68k: -Werror-implicit-function-declaration fallout

PATCH Applied Geert Uytterhoeven 11 participants 24 messages Jul 20, 2007 – Jul 24, 2007

Subsystems (7)
Networking Network drivers SCSI MIPS +3 more subsystems
lore
Share & tools
lore

Geert Uytterhoeven

author
#0 lore raw

cover m68k: -Werror-implicit-function-declaration fallout

Hi Andrew,

These patches fix the fallout on m68k of the recent introduction of -Werror-implicit-function-declaration:
[1] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible
[2] netdev: i82596 Ethernet needs <asm/cacheflush.h>
[3] scsi: wd33c93 needs <asm/irq.h>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#1 lore raw

PATCH 1/3 m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on m68k because it's hidden in the middle of a big #ifdef block.

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 drivers/char/keyboard.c     |    5 +----
 drivers/macintosh/mac_hid.c |    1 +
 include/linux/hid.h         |    3 +++
 3 files changed, 5 insertions(+), 4 deletions(-)
drivers/char/keyboard.c +1 -4
@@ -41,6 +41,7 @@
 #include <linux/sysrq.h>
 #include <linux/input.h>
 #include <linux/reboot.h>
+#include <linux/hid.h>
 
 extern void ctrl_alt_del(void);
 

@@ -1022,10 +1023,6 @@ static const unsigned short x86_keycodes
 	308,310,313,314,315,317,318,319,320,357,322,323,324,325,276,330,
 	332,340,365,342,343,344,345,346,356,270,341,368,369,370,371,372 };
 
-#ifdef CONFIG_MAC_EMUMOUSEBTN
-extern int mac_hid_mouse_emulate_buttons(int, int, int);
-#endif /* CONFIG_MAC_EMUMOUSEBTN */
-
 #ifdef CONFIG_SPARC
 static int sparc_l1_a_state = 0;
 extern void sun_do_break(void);
drivers/macintosh/mac_hid.c +1 -0
@@ -13,6 +13,7 @@
 #include <linux/sysctl.h>
 #include <linux/input.h>
 #include <linux/module.h>
+#include <linux/hid.h>
 
 
 static struct input_dev *emumousebtn;
include/linux/hid.h +3 -0
@@ -522,6 +522,9 @@ int usbhid_quirks_init(char **quirks_par
 void usbhid_quirks_exit(void);
 void usbhid_fixup_report_descriptor(const u16, const u16, char *, unsigned, char **);
 
+/* mac hid */
+extern int mac_hid_mouse_emulate_buttons(int, unsigned int, int);
+
 #ifdef CONFIG_HID_FF
 int hid_ff_init(struct hid_device *hid);
Signature · 10 lines
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#2 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Hi Geert,

Quoted 4 lines · Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 8 lines

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on m68k because it's hidden in the middle of a big #ifdef block.

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.

BTW, I don't think that mac button emulation will work well when x86 evdev-based driver gains popularity - it "grabs" the device and so no event will flow through keyboard driver... We'd need a new solution...

Signature · 1 line
Dmitry
#3 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 15 lines · Dmitry Torokhov

Hi Geert,

Quoted 12 lines · Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on
m68k because it's hidden in the middle of a big #ifdef block.

Quoted 8 lines
Quoted 2 lines

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.
...

If you only move it you will keep the bug of the wrong second parameter.

But if you move it to any header file gcc is able to figure out such errors itself instead of them being nasty runtime errors.

Such prototypes in C files are really bad since (like in this case) they prevent the finding of bugs. It doesn't matter which header file you put the prototype into (it can even be a new one), but it belongs into a header file.

Quoted 1 line

Dmitry

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 27 lines · Adrian Bunk
Quoted 15 lines · Dmitry Torokhov

Hi Geert,

Quoted 12 lines · Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on
m68k because it's hidden in the middle of a big #ifdef block.

Quoted 8 lines
Quoted 2 lines

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.
...

If you only move it you will keep the bug of the wrong second parameter.

Quoted 8 lines

But if you move it to any header file gcc is able to figure out such errors itself instead of them being nasty runtime errors.

Such prototypes in C files are really bad since (like in this case) they prevent the finding of bugs. It doesn't matter which header file you put the prototype into (it can even be a new one), but it belongs into a header file.

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

Signature · 1 line
Dmitry
#5 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 32 lines · Dmitry Torokhov
Quoted 31 lines · Adrian Bunk
Quoted 12 lines · Dmitry Torokhov

Hi Geert,

Quoted 9 lines · Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not

visible

Quoted 11 lines
Quoted 5 lines

on
m68k because it's hidden in the middle of a big #ifdef block.

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.
...

If you only move it you will keep the bug of the wrong second parameter.

But if you move it to any header file gcc is able to figure out such errors itself instead of them being nasty runtime errors.

Quoted 8 lines
Quoted 4 lines

Such prototypes in C files are really bad since (like in this case) they prevent the finding of bugs. It doesn't matter which header file you put the prototype into (it can even be a new one), but it belongs into a header file.

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

scsi.h would also be fine with me. ;-)

Are you making a patch or should I send one? [1]

Quoted 1 line

Dmitry

cu
Adrian

[1] for a new header file, not scsi.h

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#6 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 38 lines · Adrian Bunk
Quoted 37 lines · Dmitry Torokhov
Quoted 35 lines · Adrian Bunk
Quoted 12 lines · Dmitry Torokhov

Hi Geert,

Quoted 9 lines · Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not

visible

Quoted 11 lines
Quoted 5 lines

on
m68k because it's hidden in the middle of a big #ifdef block.

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.
...

If you only move it you will keep the bug of the wrong second parameter.

But if you move it to any header file gcc is able to figure out such errors itself instead of them being nasty runtime errors.

Such prototypes in C files are really bad since (like in this case) they prevent the finding of bugs. It doesn't matter which header file you put the prototype into (it can even be a new one), but it belongs into a header file.

Quoted 8 lines
Quoted 3 lines

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

scsi.h would also be fine with me. ;-)

Are you making a patch or should I send one? [1]

If you send one I'll gladly take it ;)

Signature · 1 line
Dmitry
author
#7 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

In reply to Dmitry Torokhov
Quoted 35 lines · Dmitry Torokhov
Quoted 25 lines · Adrian Bunk
Quoted 13 lines · Dmitry Torokhov
Quoted 12 lines · Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>

m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on
m68k because it's hidden in the middle of a big #ifdef block.

Quoted 8 lines
Quoted 2 lines

Move it to <linux/hid.h>, correct the type of the second parameter, and include <linux/hid.h> where needed.

linux/hid.h contains definitions needed for drivers speaking HID protocol, I don't think we want to put quirks for legacy keyboard driver there. I'd just move the #ifdef within drivers/char/keyboard.c for now.
...

If you only move it you will keep the bug of the wrong second parameter.

Quoted 8 lines

But if you move it to any header file gcc is able to figure out such errors itself instead of them being nasty runtime errors.

Such prototypes in C files are really bad since (like in this case) they prevent the finding of bugs. It doesn't matter which header file you put the prototype into (it can even be a new one), but it belongs into a header file.

Quoted 3 lines

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

At first I just wanted to move it. Then I thought about the angry comments I would get about not moving it to a header file ;-)

<linux/hid.h> looked like the best candidate. <linux/kbd_kern.h> is another option.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#8 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Hi Geert,

Quoted 6 lines · Geert Uytterhoeven
Quoted 4 lines · Dmitry Torokhov

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

Quoted 6 lines

At first I just wanted to move it. Then I thought about the angry comments I would get about not moving it to a header file ;-)

<linux/hid.h> looked like the best candidate. <linux/kbd_kern.h> is another option.

linux/kbd_kern.h sounds much better.

Signature · 1 line
Dmitry
author
#9 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 6 lines · Dmitry Torokhov
Quoted 5 lines · Geert Uytterhoeven
Quoted 3 lines · Dmitry Torokhov

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

Quoted 8 lines
Quoted 6 lines

At first I just wanted to move it. Then I thought about the angry comments I would get about not moving it to a header file ;-)

<linux/hid.h> looked like the best candidate. <linux/kbd_kern.h> is another option.

linux/kbd_kern.h sounds much better.

And so it will be.

---
m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

drivers/char/keyboard.c: In function 'kbd_keycode':
drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons'

The forward declaration of mac_hid_mouse_emulate_buttons() is not visible on m68k because it's hidden in the middle of a big #ifdef block.

Move it to <linux/kbd_kern.h>, correct the type of the second parameter, and include <linux/kbd_kern.h> where needed.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 drivers/char/keyboard.c     |    4 ----
 drivers/macintosh/mac_hid.c |    1 +
 include/linux/kbd_kern.h    |    3 +++
 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/char/keyboard.c +0 -4
@@ -1022,10 +1022,6 @@ static const unsigned short x86_keycodes
 	308,310,313,314,315,317,318,319,320,357,322,323,324,325,276,330,
 	332,340,365,342,343,344,345,346,356,270,341,368,369,370,371,372 };
 
-#ifdef CONFIG_MAC_EMUMOUSEBTN
-extern int mac_hid_mouse_emulate_buttons(int, int, int);
-#endif /* CONFIG_MAC_EMUMOUSEBTN */
-
 #ifdef CONFIG_SPARC
 static int sparc_l1_a_state = 0;
 extern void sun_do_break(void);
drivers/macintosh/mac_hid.c +1 -0
@@ -13,6 +13,7 @@
 #include <linux/sysctl.h>
 #include <linux/input.h>
 #include <linux/module.h>
+#include <linux/kbd_kern.h>
 
 
 static struct input_dev *emumousebtn;
include/linux/kbd_kern.h +3 -0
@@ -161,4 +161,7 @@ static inline void con_schedule_flip(str
 	schedule_delayed_work(&t->buf.work, 0);
 }
 
+/* mac_hid.c */
+extern int mac_hid_mouse_emulate_buttons(int, unsigned int, int);
+
 #endif

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Applied
#10 lore raw

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Quoted 10 lines · Geert Uytterhoeven
Quoted 9 lines · Dmitry Torokhov
Quoted 8 lines · Geert Uytterhoeven
Quoted 3 lines · Dmitry Torokhov

I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h

At first I just wanted to move it. Then I thought about the angry comments I would get about not moving it to a header file ;-)

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

<linux/hid.h> looked like the best candidate. <linux/kbd_kern.h> is another option.

linux/kbd_kern.h sounds much better.

And so it will be.

Applied to 'for-linus' branch of input tree, thank you.

Signature · 1 line
Dmitry
author
#11 lore raw

PATCH 2/3 netdev: i82596 Ethernet needs <asm/cacheflush.h>

In reply to Geert Uytterhoeven

netdev: i82596 Ethernet needs <asm/cacheflush.h> on m68k

drivers/net/82596.c: In function 'init_rx_bufs':
drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear' drivers/net/82596.c: In function 'i596_start_xmit':
drivers/net/82596.c:1104: error: implicit declaration of function 'cache_push'

The driver still compiles on ia32 (CONFIG_APRICOT=y)

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 drivers/net/82596.c |    1 +
 1 file changed, 1 insertion(+)
drivers/net/82596.c +1 -0
@@ -57,6 +57,7 @@
 #include <asm/io.h>
 #include <asm/dma.h>
 #include <asm/pgtable.h>
+#include <asm/cacheflush.h>
 
 static char version[] __initdata =
 	"82596.c $Revision: 1.5 $\n";
Signature · 10 lines
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
Applied
#12 lore raw

Re: [patch 2/3] netdev: i82596 Ethernet needs <asm/cacheflush.h>

Quoted 10 lines · Geert Uytterhoeven

netdev: i82596 Ethernet needs <asm/cacheflush.h> on m68k

drivers/net/82596.c: In function 'init_rx_bufs':
drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear' drivers/net/82596.c: In function 'i596_start_xmit':
drivers/net/82596.c:1104: error: implicit declaration of function 'cache_push'

The driver still compiles on ia32 (CONFIG_APRICOT=y)

Signed-off-by Geert Uytterhoeven <[email protected]>

applied

author
#13 lore raw

PATCH 3/3 scsi: wd33c93 needs <asm/irq.h>

In reply to Geert Uytterhoeven

wd33c93 SCSI needs <asm/irq.h> on m68k

drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset':
drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq'

The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y)

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 drivers/scsi/wd33c93.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/scsi/wd33c93.c +2 -0
@@ -89,6 +89,8 @@
 #include <scsi/scsi_device.h>
 #include <scsi/scsi_host.h>
 
+#include <asm/irq.h>
+
 #include "wd33c93.h"
 
 #define optimum_sx_per(hostdata) (hostdata)->sx_table[1].period_ns
Signature · 10 lines
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#14 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

Quoted 8 lines · Geert Uytterhoeven

plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) wd33c93 SCSI needs <asm/irq.h> on m68k

drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset':
drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq'

The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y)

That's fixed here, isn't it:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=078dda95c521b1c78d1b5da69ac90d581abc9951

(sorry about the lack of descriptive subject line)

James

author
#15 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

Quoted 8 lines · James Bottomley
Quoted 7 lines · Geert Uytterhoeven

plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) wd33c93 SCSI needs <asm/irq.h> on m68k

drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset':
drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq'

Quoted 5 lines
Quoted 1 line

The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y)

That's fixed here, isn't it:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=078dda95c521b1c78d1b5da69ac90d581abc9951

Indeed, thx!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#16 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

In reply to James Bottomley
Quoted 8 lines · James Bottomley
Quoted 7 lines · Geert Uytterhoeven

plain text document attachment (m68k-wd33c93-needs-asm-irq.diff) wd33c93 SCSI needs <asm/irq.h> on m68k

drivers/scsi/wd33c93.c: In function 'wd33c93_host_reset':
drivers/scsi/wd33c93.c:1582: error: implicit declaration of function 'disable_irq' drivers/scsi/wd33c93.c:1603: error: implicit declaration of function 'enable_irq'

Quoted 7 lines
Quoted 1 line

The driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y)

That's fixed here, isn't it:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=078dda95c521b1c78d1b5da69ac90d581abc9951

(sorry about the lack of descriptive subject line)

It wasn't a compile error when I sent this patch to you for the first time 11 months ago...

Quoted 1 line

James

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#17 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

In reply to Geert Uytterhoeven

drivers/scsi/wd33c93.c line 92

Quoted 7 lines · Geert Uytterhoeven
drivers/scsi/wd33c93.c +1 -0
@@ -89,6 +89,8 @@
 #include <scsi/scsi_device.h>
 #include <scsi/scsi_host.h>
 
+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Ralf

#18 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

Quoted 3 lines · Ralf Baechle
Quoted 1 line

+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Not at all, linux/irq.h is something entirely different.

#19 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

Hello Christoph:

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Not at all, linux/irq.h is something entirely different.

Actually, <linux/interrupt.h>

WBR, Sergei

#20 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

Quoted 9 lines · Sergei Shtylyov

Hello Christoph:

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Not at all, linux/irq.h is something entirely different.

Actually, <linux/interrupt.h>

Not for enable/disable_irq. For request_irq, yes.

This is something that should be fixed.

Signature · 3 lines
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
#21 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

Quoted 7 lines · Matthew Wilcox
Quoted 6 lines · Sergei Shtylyov

Hello Christoph:

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Not at all, linux/irq.h is something entirely different.

Actually, <linux/interrupt.h>

Not for enable/disable_irq. For request_irq, yes.

This is something that should be fixed.

Now it is... FWIW, I suspect that absolute majority of asm/irq.h uses can be removed now.

Next steps in irq.h/interrupt.h cleanups:
* scouring asm/irq.h like it had been done for sparc32;
the parts that are only used by relevant arch/ code should be taken there and includes _in_ asm/irq.h trimmed to minimum
* separating tasklet.h, with interrupt.h still including it.
Using it where needed.
* asm/softirq.h (with stuff mostly taken there from asm/hardirq.h)
and linux/softirq.h; again interrupt.h still should include it.
* mechanical adding include of linux/interrupt.h to files that use
request_irq/free_irq/enable_irq/disable_irq/irqreturn_t/IRQF_... ---> in the next merge window:
* replace include of linux/interrupt.h in netdevice.h with
that of linux/softirq.h.
* trim uses of linux/interrupt.h that are not needed anymore.

#22 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

In reply to Christoph Hellwig
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Ralf Baechle
Quoted 1 line

+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Not at all, linux/irq.h is something entirely different.

Well, fine. But checkpatch.pl will bitch about this and other files. So one way or the other it's not quite kosher.

Ralf

#23 lore raw

Re: [patch 3/3] scsi: wd33c93 needs <asm/irq.h>

In reply to Ralf Baechle
Quoted 4 lines · Ralf Baechle
Quoted 1 line · Geert Uytterhoeven

+#include <asm/irq.h>

These days that should probably be <linux/irq.h>.

Go and read the comments at the top of linux/irq.h. And then report to Russell for your whipping.

Signature · 3 lines
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."