Skip to contentSkip to conversation

ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()

PATCH In review Bartlomiej Zolnierkiewicz 3 participants 4 messages Jul 22, 2007 – Jul 23, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 10/11 ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()

Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in pmac_ide_do_setfeature().

---
 drivers/ide/ppc/pmac.c |    1 -
 1 file changed, 1 deletion(-)
drivers/ide/ppc/pmac.c +0 -1
Index: b/drivers/ide/ppc/pmac.c
===================================================================
@@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv
 	result = __ide_wait_stat(drive, drive->ready_stat,
 				 BUSY_STAT|DRQ_STAT|ERR_STAT,
 				 WAIT_CMD, &stat);
-	hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
 	if (result)
 		printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "
 			"after SET_FEATURE !\n", drive->name);
#3 lore raw
In reply to Bartlomiej Zolnierkiewicz
Quoted 2 lines · Bartlomiej Zolnierkiewicz

Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in pmac_ide_do_setfeature().

Same comment as before regarding the weirdo drive in the wallstreet. I need to do some tests.

Ben.

Quoted 18 lines
---
 drivers/ide/ppc/pmac.c |    1 -
 1 file changed, 1 deletion(-)

Index: b/drivers/ide/ppc/pmac.c
===================================================================

drivers/ide/ppc/pmac.c +0 -1
@@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv
 	result = __ide_wait_stat(drive, drive->ready_stat,
 				 BUSY_STAT|DRQ_STAT|ERR_STAT,
 				 WAIT_CMD, &stat);
-	hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
 	if (result)
 		printk(KERN_ERR "%s: pmac_ide_do_setfeature disk not ready "
 			"after SET_FEATURE !\n", drive->name);