ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
PATCH 10/11 ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()
Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in pmac_ide_do_setfeature().
--- drivers/ide/ppc/pmac.c | 1 - 1 file changed, 1 deletion(-)
drivers/ide/ppc/pmac.c +0 -1
@@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv result =__ide_wait_stat (drive, drive->ready_stat,BUSY_STAT |DRQ_STAT |ERR_STAT ,WAIT_CMD , &stat); - hwif->OUTB (drive->ctl,IDE_CONTROL_REG );if (result)printk (KERN_ERR "%s: pmac_ide_do_setfeature disk not ready " "after SET_FEATURE !\n" , drive->name);
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in
pmac_ide_do_setfeature().Cc Benjamin Herrenschmidt <[email protected]>Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
MBR, Sergei
Quoted 9 lines · Sergei Shtylyov
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in
pmac_ide_do_setfeature().Cc Benjamin Herrenschmidt <[email protected]>Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>Acked-by Sergei Shtylyov <[email protected]>
added
Quoted 2 lines · Bartlomiej Zolnierkiewicz
Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in
pmac_ide_do_setfeature().
Same comment as before regarding the weirdo drive in the wallstreet. I need to do some tests.
Ben.
Quoted 18 lines
Cc Benjamin Herrenschmidt <[email protected]>Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>--- drivers/ide/ppc/pmac.c | 1 - 1 file changed, 1 deletion(-)Index:
b/drivers/ide/ppc/pmac.c
===================================================================drivers/ide/ppc/pmac.c +0
-1@@ -555,7 +555,6 @@ pmac_ide_do_setfeature(ide_drive_t *driv result =__ide_wait_stat (drive, drive->ready_stat,BUSY_STAT |DRQ_STAT |ERR_STAT ,WAIT_CMD , &stat); - hwif->OUTB (drive->ctl,IDE_CONTROL_REG );if (result)printk (KERN_ERR "%s: pmac_ide_do_setfeature disk not ready " "after SET_FEATURE !\n" , drive->name);