Skip to contentSkip to conversation

irq: irq and pci_ids patch for Intel Tolapai

PATCH RESEND In review Jason Gaston 3 participants 5 messages Aug 31, 2007 – Sep 11, 2007 PCI

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 irq: irq and pci_ids patch for Intel Tolapai

Resend without wordwrap.

This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.orig +1 -0
@@ -550,6 +550,7 @@
 		case PCI_DEVICE_ID_INTEL_ICH9_3:
 		case PCI_DEVICE_ID_INTEL_ICH9_4:
 		case PCI_DEVICE_ID_INTEL_ICH9_5:
+		case PCI_DEVICE_ID_INTEL_Tolapai_0:
 			r->name = "PIIX/ICH";
 			r->get = pirq_piix_get;
 			r->set = pirq_piix_set;
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +2 -0
@@ -2293,6 +2293,8 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC	0x3599
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0	0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1	0x5032
 #define PCI_DEVICE_ID_INTEL_82371SB_0	0x7000
 #define PCI_DEVICE_ID_INTEL_82371SB_1	0x7010
 #define PCI_DEVICE_ID_INTEL_82371SB_2	0x7020
#1 lore raw
Quoted 19 lines · On Thu, 30 Aug 2007 17:50:56 -0700 Jason Gaston <[email protected]>…

Resend without wordwrap.

This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.orig +1 -0
@@ -550,6 +550,7 @@
 		case PCI_DEVICE_ID_INTEL_ICH9_3:
 		case PCI_DEVICE_ID_INTEL_ICH9_4:
 		case PCI_DEVICE_ID_INTEL_ICH9_5:
+		case PCI_DEVICE_ID_INTEL_Tolapai_0:
 			r->name = "PIIX/ICH";
 			r->get = pirq_piix_get;
 			r->set = pirq_piix_set;

include/linux/pci_ids.h line 2300

Quoted 8 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +2 -0
@@ -2293,6 +2293,8 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC	0x3599
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0	0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1	0x5032
 #define PCI_DEVICE_ID_INTEL_82371SB_0	0x7000
 #define PCI_DEVICE_ID_INTEL_82371SB_1	0x7010
 #define PCI_DEVICE_ID_INTEL_82371SB_2	0x7020

I agree with Matthew that the lower-case shouldn't be in there, so I queued a patch to fix that up.

Given that your I2C patch (and potentially others?) depend upon this one, I shall plan on getting this patch into mainline this week to make everyone's life simpler.

#2 lore raw
Quoted 33 lines · Andrew Morton
Quoted 19 lines · On Thu, 30 Aug 2007 17:50:56 -0700 Jason Gaston <[email protected]>…

Resend without wordwrap.

This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.orig +1 -0
@@ -550,6 +550,7 @@
 		case PCI_DEVICE_ID_INTEL_ICH9_3:
 		case PCI_DEVICE_ID_INTEL_ICH9_4:
 		case PCI_DEVICE_ID_INTEL_ICH9_5:
+		case PCI_DEVICE_ID_INTEL_Tolapai_0:
 			r->name = "PIIX/ICH";
 			r->get = pirq_piix_get;
 			r->set = pirq_piix_set;

include/linux/pci_ids.h line 2300

Quoted 8 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +2 -0
@@ -2293,6 +2293,8 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC	0x3599
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0	0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1	0x5032
 #define PCI_DEVICE_ID_INTEL_82371SB_0	0x7000
 #define PCI_DEVICE_ID_INTEL_82371SB_1	0x7010
 #define PCI_DEVICE_ID_INTEL_82371SB_2	0x7020

I agree with Matthew that the lower-case shouldn't be in there, so I queued a patch to fix that up.

Quoted 3 lines

Given that your I2C patch (and potentially others?) depend upon this one, I shall plan on getting this patch into mainline this week to make everyone's life simpler.

I agree, that's why it's in my queue to go to Linus in a day or so :)

thanks,

greg k-h

#3 lore raw
Quoted 34 lines · On Mon, 10 Sep 2007 07:09:13 -0700 Greg KH <[email protected]> wrote:
Quoted 33 lines · Andrew Morton
Quoted 19 lines · On Thu, 30 Aug 2007 17:50:56 -0700 Jason Gaston <[email protected]>…

Resend without wordwrap.

This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.orig +1 -0
@@ -550,6 +550,7 @@
 		case PCI_DEVICE_ID_INTEL_ICH9_3:
 		case PCI_DEVICE_ID_INTEL_ICH9_4:
 		case PCI_DEVICE_ID_INTEL_ICH9_5:
+		case PCI_DEVICE_ID_INTEL_Tolapai_0:
 			r->name = "PIIX/ICH";
 			r->get = pirq_piix_get;
 			r->set = pirq_piix_set;

include/linux/pci_ids.h line 2300

Quoted 8 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +2 -0
@@ -2293,6 +2293,8 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC	0x3599
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0	0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1	0x5032
 #define PCI_DEVICE_ID_INTEL_82371SB_0	0x7000
 #define PCI_DEVICE_ID_INTEL_82371SB_1	0x7010
 #define PCI_DEVICE_ID_INTEL_82371SB_2	0x7020

I agree with Matthew that the lower-case shouldn't be in there, so I queued a patch to fix that up.

Quoted 6 lines
Quoted 3 lines

Given that your I2C patch (and potentially others?) depend upon this one, I shall plan on getting this patch into mainline this week to make everyone's life simpler.

I agree, that's why it's in my queue to go to Linus in a day or so :)

I can't find it. Did you queue the all-caps version or the above version?

#4 lore raw
Quoted 36 lines · Andrew Morton
Quoted 34 lines · On Mon, 10 Sep 2007 07:09:13 -0700 Greg KH <[email protected]> wrote:
Quoted 33 lines · Andrew Morton
Quoted 19 lines · On Thu, 30 Aug 2007 17:50:56 -0700 Jason Gaston <[email protected]>…

Resend without wordwrap.

This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.orig +1 -0
@@ -550,6 +550,7 @@
 		case PCI_DEVICE_ID_INTEL_ICH9_3:
 		case PCI_DEVICE_ID_INTEL_ICH9_4:
 		case PCI_DEVICE_ID_INTEL_ICH9_5:
+		case PCI_DEVICE_ID_INTEL_Tolapai_0:
 			r->name = "PIIX/ICH";
 			r->get = pirq_piix_get;
 			r->set = pirq_piix_set;

include/linux/pci_ids.h line 2300

Quoted 8 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +2 -0
@@ -2293,6 +2293,8 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC	0x3599
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0	0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1	0x5032
 #define PCI_DEVICE_ID_INTEL_82371SB_0	0x7000
 #define PCI_DEVICE_ID_INTEL_82371SB_1	0x7010
 #define PCI_DEVICE_ID_INTEL_82371SB_2	0x7020

I agree with Matthew that the lower-case shouldn't be in there, so I queued a patch to fix that up.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Given that your I2C patch (and potentially others?) depend upon this one, I shall plan on getting this patch into mainline this week to make everyone's life simpler.

I agree, that's why it's in my queue to go to Linus in a day or so :)

I can't find it. Did you queue the all-caps version or the above version?

The all-caps version. But I realized that I hadn't pushed out my tree to kernel.org due to doing this work on the train without network support, so it should be there now. Sorry about that.

greg k-h