irq: irq and pci_ids patch for Intel Tolapai
PATCH 1/1 irq: irq and pci_ids patch for Intel Tolapai
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
-0700
+++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700
@@ -550,6 +550,7 @@
case PCI_DEVICE_ID_INTEL_ICH9_3:
case PCI_DEVICE_ID_INTEL_ICH9_4:
case PCI_DEVICE_ID_INTEL_ICH9_5:
+ case PCI_DEVICE_ID_INTEL_Tolapai_0:
r->name = "PIIX/ICH";
r->get = pirq_piix_get;
r->set = pirq_piix_set;
--- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-27
18:32:35.000000000 -0700
+++ linux-2.6.23-rc4/include/linux/pci_ids.h 2007-08-28 16:58:31.000000000
-0700
@@ -2293,6 +2293,8 @@
#define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599
#define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a
#define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
+#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031
+#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
#define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000
#define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010
#define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020
Matthew Wilcox
NAKReview
Quoted 3 lines · Jason Gaston
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
(quoted diff) +2
-0+#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031 +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
NACK -- use all upper-case.
Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
Review line 553
Quoted 12 lines · Jason Gaston
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
Signed-off-by ?Jason Gaston <[email protected]>--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
-0700
+++linux-2.6.23-rc4/arch/i386/pci/irq.c2007-08-28 16:58:31.000000000 -0700(quoted diff) +1
-0@@ -550,6 +550,7 @@ case PCI_DEVICE_ID_INTEL_ICH9_3: case PCI_DEVICE_ID_INTEL_ICH9_4: case PCI_DEVICE_ID_INTEL_ICH9_5: + case PCI_DEVICE_ID_INTEL_Tolapai_0:
If this is the only place it's used, the prefence is to define the constant locally (in the file) and not in pci_ids.h.
Please do submit new PCI device IDs to pciids.sf.net project.
thanks,
grant
Quoted 16 lines
(quoted diff) +0
-1r->name = "PIIX/ICH"; r->get = pirq_piix_get; r->set = pirq_piix_set; --- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-2718:32:35.000000000 -0700
+++linux-2.6.23-rc4/include/linux/pci_ids.h2007-08-28 16:58:31.000000000
-0700(quoted diff) +2
-0@@ -2293,6 +2293,8 @@ #define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599 #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031 +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032 #define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000 #define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010 #define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020
Quoted 5 lines · Grant Grundler
Quoted 4 lines · Jason Gaston
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
Signed-off-by ?Jason Gaston <[email protected]>
Quoted 11 lines
Review line 553
Quoted 8 lines
--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000
-0700
+++linux-2.6.23-rc4/arch/i386/pci/irq.c2007-08-28 16:58:31.000000000 -0700(quoted diff) +1
-0@@ -550,6 +550,7 @@ case PCI_DEVICE_ID_INTEL_ICH9_3: case PCI_DEVICE_ID_INTEL_ICH9_4: case PCI_DEVICE_ID_INTEL_ICH9_5: + case PCI_DEVICE_ID_INTEL_Tolapai_0:If this is the only place it's used, the prefence is to define the constant locally (in the file) and not in
pci_ids.h.
Kinda sorta: if you must define a constant, it should go into linux/pci_ids.h. Otherwise someone will come along later, do the same locally in another file, then you have two independent symbols with the same meaning.
Ideally, in pci_device_id tables and such, you can just use the hex number, since they are all arbitrary and lack meaning anyway.
Quoted 1 line
Please do submit new PCI device IDs to pciids.sf.net project.
Yep.
Quoted 5 lines
Review
Quoted 5 lines
(quoted diff) +2
-0#define PCI_DEVICE_ID_INTEL_MCH_PC 0x3599 #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e +#define PCI_DEVICE_ID_INTEL_Tolapai_0 0x5031 +#define PCI_DEVICE_ID_INTEL_Tolapai_1 0x5032
And change the StudlyCaps to ALLCAPS.
Jeff
Quoted 3 lines
Quoted 1 line
Please do submit new PCI device IDs to pciids.sf.net project.
Yep.
FYI: I have already posted the Tolapai DID's and device strings to pciids.sf.net.
Thanks,
Jason