Skip to contentSkip to conversation

: Preparatory patches for feature negotiation

PATCH In review Gerrit Renker 2 participants 2 messages Sep 25, 2007

lore
Share & tools
lore
#0 lore raw

cover : Preparatory patches for feature negotiation

A small set of patches to prepare feature negotion, and one miscellaneous one. I will start step by step, the patches will be put into the test tree after the last batch has been set (although this time I made sure that patch sets also compile separately).

Patch #1: Accounting, records an unused function.

Patch #2: Adds Data 1..3 fields to do more informative

          processing of DCCP-Resets (RFC 4340, 5.6)

Patch #3: Removes duplicate code for generating Reset
from connected socket (now uses already prepared route via dccp_transmit_skb).

Patch #4: Factors out common code for sending Resets from
control sockets. This includes processing the Data 1..3 fields for Packet/Option/Mandatory Error.

Patch #5: Parsing options on request_socks, a prerequisite
for implementing feature-negotiation during connection setup.

Patch #6: Integrates the code of Patch #5 with the processing
in dccp_check_req, so that options can be considered by the server during the initial handshake (is a FIXME).

Patch #7: As the first option to be parseable on both request_socks
and connected socks, timestamp echo is made dynamic. There are hooks/ideas there of turning this into a RFC1323-like algorithm, which however requires some more work (to deal correctly with delayed, lost, duplicate packets/timestamps).

Patch #8: Rounds off this request-sock patch set by adding support for
inserting options from request_socks as well (as opposed to sk's).

#1 lore raw

Em Tue, Sep 25, 2007 at 03:23:50PM +0100, Gerrit Renker escreveu:

Quoted 4 lines

A small set of patches to prepare feature negotion, and one miscellaneous one. I will start step by step, the patches will be put into the test tree after the last batch has been set (although this time I made sure that patch sets also compile separately).

I'll review these ASAP, they shouldn't touch CCID code so it'll be easier to put in my tree.

- Arnaldo