Skip to content

: Preparatory patches for feature negotiation

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200709251523.50165@strip-the-willow

Versions newest first

  1. v1 Latest8 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8: Add FIXME for send_delayed_acknet/dccp/dccp.h net/dccp/output.c+1 -13 replies
2/8: Add Support for Data 1 .. 3 fields of Reset packetsinclude/linux/dccp.h net/dccp/dccp.h+19 -91 reply
3/8: Remove duplicate code for Reset from connected socketnet/dccp/output.c+19 -592 replies
4/8: Factor out common code for generating Resetsnet/dccp/dccp.h net/dccp/ipv4.c net/dccp/output.c+59 -331 reply
5/8: Allow to parse options on Request Socketsinclude/linux/dccp.h net/dccp/input.c net/dccp/ipv4.c +2 more+37 -241 reply
6/8: Add (missing) option parsing to request_sock processingnet/dccp/minisocks.c+6 -61 reply
7/8: Handle timestamps on Request/Response exchange separatelyinclude/linux/dccp.h net/dccp/dccp.h net/dccp/ipv4.c +4 more+66 -196 replies
8/8: Support inserting options during the 3-way handshakenet/dccp/dccp.h net/dccp/options.c net/dccp/output.c+30 -134 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/8
2/8
3/8A-b
4/8A-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8]: Preparatory patches for feature negotiation

A small set of patches to prepare feature negotion, and one miscellaneous one. I will start step by step, the patches will be put into the test tree after the last batch has been set (although this time I made sure that patch sets also compile separately).

Patch #1: Accounting, records an unused function.

Patch #2: Adds Data 1..3 fields to do more informative

          processing of DCCP-Resets (RFC 4340, 5.6)

Patch #3: Removes duplicate code for generating Reset
from connected socket (now uses already prepared route via dccp_transmit_skb).

Patch #4: Factors out common code for sending Resets from
control sockets. This includes processing the Data 1..3 fields for Packet/Option/Mandatory Error.

Patch #5: Parsing options on request_socks, a prerequisite
for implementing feature-negotiation during connection setup.

Patch #6: Integrates the code of Patch #5 with the processing
in dccp_check_req, so that options can be considered by the server during the initial handshake (is a FIXME).

Patch #7: As the first option to be parseable on both request_socks
and connected socks, timestamp echo is made dynamic. There are hooks/ideas there of turning this into a RFC1323-like algorithm, which however requires some more work (to deal correctly with delayed, lost, duplicate packets/timestamps).

Patch #8: Rounds off this request-sock patch set by adding support for
inserting options from request_socks as well (as opposed to sk's).