: Add FIXME for send_delayed_ack
PATCH 1/8 : Add FIXME for send_delayed_ack
[DCCP]: Add FIXME for send_delayed_ack
This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere used in the entire DCCP/CCID code.
Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also rather subtle implications for the Ack-Ratio-accounting.
CCID2 does not use this (maybe it should).
I think leaving the function in is good, in case someone wants to implement this.
--- net/dccp/dccp.h | 1 - net/dccp/output.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
net/dccp/dccp.h +0 -1
@@ -214,7 +214,6 @@ extern void dccp_v4_send_check(struct soextern int dccp_retransmit_skb (struct sock *sk,struct sk_buff *skb);extern void dccp_send_ack (struct sock *sk); -extern void dccp_send_delayed_ack (struct sock *sk);extern void dccp_reqsk_send_ack (struct sk_buff *sk,struct request_sock *rsk); extern void dccp_send_sync(struct sock *sk, const u64 seq,
net/dccp/output.c +1 -0
@@ -481,6 +481,7 @@ void dccp_send_ack(struct sock *sk)EXPORT_SYMBOL_GPL (dccp_send_ack); +/* FIXME: Is this still necessary (11.3) - currently nowhere used by DCCP. */ void dccp_send_delayed_ack (struct sock *sk) {struct inet_connection_sock *icsk =inet_csk (sk);
Em Tue, Sep 25, 2007 at 03:29:52PM +0100, Gerrit Renker escreveu:
Quoted 8 lines
[DCCP]: Add FIXME for
send_delayed_ackThis adds a FIXME to signal that the function
dccp_send_delayed_ackis nowhere used in the entire DCCP/CCID code.Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also rather subtle implications for the Ack-Ratio-accounting.
Quoted 6 lines
CCID2 does not use this (maybe it should).
I think leaving the function in is good, in case someone wants to implement this.
Signed-off-by Gerrit Renker <[email protected]>
Well spotted, I just checked and it really was never used!
applying
- Arnaldo
Quoted 8 lines · Gerrit Renker
[DCCP]: Add FIXME for
send_delayed_ackThis adds a FIXME to signal that the function
dccp_send_delayed_ackis nowhere used in the entire DCCP/CCID code.Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also rather subtle implications for the Ack-Ratio-accounting.
Quoted 6 lines
CCID2 does not use this (maybe it should).
I think leaving the function in is good, in case someone wants to implement this.
Signed-off-by Gerrit Renker <[email protected]>
How about using #if 0, #endif around it to keep the code in the tree but not compiled.
This is done a fair bit elsewhere and if never used it gets removed.
Ian
Signature · 3 lines
Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz
Ian -
| How about using #if 0, #endif around it to keep the code in the tree | but not compiled. | | This is done a fair bit elsewhere and if never used it gets removed.
this is a good idea actually, the problem that I have with this is it makes the code look unfinished and hackish, but this is a self-contained function which I think would serve its purpose - it is just not used at the moment.
I was considering taking this on board, but noted that Arnaldo had applied this already. And I think that keeping delayed Acks an option might be useful for CCID2.