: Sequence number wrap-around when sending reset

PATCH In review Arnaldo Carvalho de Melo 1 participant 1 message Sep 26, 2007 Networking

lore

Share & tools

lore

Arnaldo Carvalho de Melo

author

2007-09-26 18:40 UTC #0 lore raw

PATCH 7/8 : Sequence number wrap-around when sending reset

This replaces normal addition with mod-48 addition so that sequence number wraparound is respected.

Signed-off-by Gerrit Renker <[email protected]>

Signed-off-by Ian McDonald <[email protected]>

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>

---
 net/dccp/ipv4.c |    2 +-
 net/dccp/ipv6.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

net/dccp/ipv4.c +1 -1

index 2c62828..58a79c2 100644
@@ -552,7 +552,7 @@ static void dccp_v4_ctl_send_reset(struct sock *sk, struct sk_buff *rxskb)
 
 	/* See "8.3.1. Abnormal Termination" in RFC 4340 */
 	if (DCCP_SKB_CB(rxskb)->dccpd_ack_seq != DCCP_PKT_WITHOUT_ACK_SEQ)
-		dccp_set_seqno(&seqno, DCCP_SKB_CB(rxskb)->dccpd_ack_seq + 1);
+		seqno = ADD48(DCCP_SKB_CB(rxskb)->dccpd_ack_seq, 1);
 
 	dccp_hdr_set_seq(dh, seqno);
 	dccp_hdr_set_ack(dccp_hdr_ack_bits(skb), DCCP_SKB_CB(rxskb)->dccpd_seq);

net/dccp/ipv6.c +1 -1

index b158c66..d954e83 100644
@@ -336,7 +336,7 @@ static void dccp_v6_ctl_send_reset(struct sock *sk, struct sk_buff *rxskb)
 
 	/* See "8.3.1. Abnormal Termination" in RFC 4340 */
 	if (DCCP_SKB_CB(rxskb)->dccpd_ack_seq != DCCP_PKT_WITHOUT_ACK_SEQ)
-		dccp_set_seqno(&seqno, DCCP_SKB_CB(rxskb)->dccpd_ack_seq + 1);
+		seqno = ADD48(DCCP_SKB_CB(rxskb)->dccpd_ack_seq, 1);
 
 	dccp_hdr_set_seq(dh, seqno);
 	dccp_hdr_set_ack(dccp_hdr_ack_bits(skb), DCCP_SKB_CB(rxskb)->dccpd_seq);

Signature · 1 line

1.5.2.2