Skip to contentSkip to conversation

Use an unsigned type for irq number

PATCH New Matthew Wilcox 1 participant 1 message Oct 9, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use an unsigned type for irq number

There are three places in the sym2 driver which print out an interrupt number; all need to be changed to unsigned

drivers/scsi/sym53c8xx_2/sym_glue.c +3 -3
index 74300dd..0f214c0 100644
@@ -1189,7 +1189,7 @@ static int sym_host_info(struct Scsi_Host *shost, char *ptr, off_t offset, int l
 	copy_info(&info, "Chip " NAME53C "%s, device id 0x%x, "
 			 "revision id 0x%x\n", np->s.chip_name,
 			 pdev->device, pdev->revision);
-	copy_info(&info, "At PCI address %s, IRQ %d\n",
+	copy_info(&info, "At PCI address %s, IRQ %u\n",
 			 pci_name(pdev), pdev->irq);
 	copy_info(&info, "Min. period factor %d, %s SCSI BUS%s\n",
 			 (int) (np->minsync_dt ? np->minsync_dt : np->minsync),
@@ -1275,7 +1275,7 @@ static struct Scsi_Host * __devinit sym_attach(struct scsi_host_template *tpnt,
 	unsigned long flags;
 	struct sym_fw *fw;
 
-	printk(KERN_INFO "sym%d: <%s> rev 0x%x at pci %s irq %d\n",
+	printk(KERN_INFO "sym%d: <%s> rev 0x%x at pci %s irq %u\n",
 		unit, dev->chip.name, pdev->revision, pci_name(pdev),
 		pdev->irq);
 
@@ -1359,7 +1359,7 @@ static struct Scsi_Host * __devinit sym_attach(struct scsi_host_template *tpnt,
 	 */
 	if (request_irq(pdev->irq, sym53c8xx_intr, IRQF_SHARED, NAME53C8XX,
 								shost)) {
-		printf_err("%s: request irq %d failure\n",
+		printf_err("%s: request irq %u failure\n",
 			sym_name(np), pdev->irq);
 		goto attach_failed;
 	}
Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."