Skip to contentSkip to conversation

: Adds a rcu_dereference() in sk_filter

SOCK Applied Eric Dumazet 3 participants 3 messages Jan 8, 2008 – Jan 9, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference()

Either we need a rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.

include/net/sock.h +1 -1
index 67e35c7..6e1542d 100644
@@ -944,7 +944,7 @@ static inline int sk_filter(struct sock *sk, struct sk_buff *skb)
 		return err;
 	
 	rcu_read_lock_bh();
-	filter = sk->sk_filter;
+	filter = rcu_dereference(sk->sk_filter);
 	if (filter) {
 		unsigned int pkt_len = sk_run_filter(skb, filter->insns,
 				filter->len);
Acked-by
#1 lore raw
Quoted 8 lines · Eric Dumazet

It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference()

Either we need a rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.

Thanks,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer Applied
#2 lore raw

From: Herbert Xu <[email protected]>
Date: Wed, 09 Jan 2008 17:17:06 +1100

Quoted 11 lines
Quoted 8 lines · Eric Dumazet

It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference()

Either we need a rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.

Applied, thanks everyone.