: Adds a rcu_dereference() in sk_filter
Subsystems (3)
It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference()
Either we need a rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.
include/net/sock.h +1 -1
@@ -944,7 +944,7 @@ static inline int sk_filter(struct sock *sk, struct sk_buff *skb)return err;rcu_read_lock_bh (); - filter = sk->sk_filter; + filter =rcu_dereference (sk->sk_filter);if (filter) {unsigned int pkt_len =sk_run_filter (skb, filter->insns, filter->len);
Herbert Xu
Acked-byQuoted 8 lines · Eric Dumazet
It seems commit
fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9introduced a RCU protection forsk_filter(), without arcu_dereference()Either we need a
rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.Signed-off-by Eric Dumazet <[email protected]>
Thanks,
Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txtFrom: Herbert Xu <[email protected]>
Date: Wed, 09 Jan 2008 17:17:06 +1100
Quoted 11 lines
Quoted 8 lines · Eric Dumazet
It seems commit
fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9introduced a RCU protection forsk_filter(), without arcu_dereference()Either we need a
rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.Signed-off-by Eric Dumazet <[email protected]>Acked-by Herbert Xu <[email protected]>
Applied, thanks everyone.