Skip to contentSkip to conversation

sis190 build breakage

DISCUSSION maximilian attems 5 participants 9 messages Jan 29, 2008 – Jan 30, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

CC [M] drivers/net/sis190.o
drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

#1 lore raw

maximilian attems <[email protected]> :

Quoted 6 lines

CC [M] drivers/net/sis190.o
drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

Are you building latest git with DEBUG_SECTION_MISMATCH enabled by any misfortune ?

Signature · 1 line
Ueimor
#2 lore raw
Quoted 10 lines · Francois Romieu

maximilian attems <[email protected]> :

Quoted 6 lines

CC [M] drivers/net/sis190.o
drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

Are you building latest git with DEBUG_SECTION_MISMATCH enabled by any misfortune ?

yep latest git, but nope
# CONFIG_DEBUG_SECTION_MISMATCH is not set

probably i should to get interesting info.

#3 lore raw

maximilian attems <[email protected]> :
[...]

Quoted 1 line

probably i should to get interesting info.

Don't bother.

$ less +/devinitdata Documentation/pci.txt
[...]
Tips on when/where to use the above attributes:
        o The module_init()/module_exit() functions (and all
          initialization functions called _only_ from these)
          should be marked __init/__exit.

o Do not mark the struct pci_driver.

o The ID table array should be marked __devinitdata.

Could our documentation be wrong ?

drivers/net/sis190.c +1 -1
index b570402..2e9e88b 100644
@@ -326,7 +326,7 @@ static const struct {
 	{ "SiS 191 PCI Gigabit Ethernet adapter" },
 };
 
-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
+static struct pci_device_id sis190_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
 	{ 0, },
#4 lore raw
Quoted 13 lines · Francois Romieu

maximilian attems <[email protected]> :
[...]

Quoted 1 line

probably i should to get interesting info.

Don't bother.

$ less +/devinitdata Documentation/pci.txt
[...]
Tips on when/where to use the above attributes:
        o The module_init()/module_exit() functions (and all
          initialization functions called _only_ from these)
          should be marked __init/__exit.
Quoted 5 lines

o Do not mark the struct pci_driver.

o The ID table array should be marked __devinitdata.

Could our documentation be wrong ?

yep that was what i had in mind, so i was a bit baffled..

randy any insight?

Quoted 6 lines
drivers/net/sis190.c +0 -0
index b570402..2e9e88b 100644

drivers/net/sis190.c static const struct { · line 332

Quoted 8 lines
drivers/net/sis190.c +1 -1
@@ -326,7 +326,7 @@ static const struct {
 	{ "SiS 191 PCI Gigabit Ethernet adapter" },
 };
 
-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
+static struct pci_device_id sis190_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
 	{ 0, },

thanks for quick fix.

#5 lore raw
Quoted 16 lines · On Wed, 30 Jan 2008 00:12:23 +0100 maximilian attems wrote:
Quoted 15 lines · Francois Romieu

maximilian attems <[email protected]> :
[...]

Quoted 1 line

probably i should to get interesting info.

Don't bother.

$ less +/devinitdata Documentation/pci.txt
[...]
Tips on when/where to use the above attributes:
        o The module_init()/module_exit() functions (and all
          initialization functions called _only_ from these)
          should be marked __init/__exit.

o Do not mark the struct pci_driver.

Quoted 7 lines
Quoted 3 lines

o The ID table array should be marked __devinitdata.

Could our documentation be wrong ?

yep that was what i had in mind, so i was a bit baffled..

randy any insight?

Hi,

I can't reproduce the problem... :(

I tend to expect something with Sam's new section mismatch detection. Maybe it's a lot better and found a real issue, but AFAIK this table can still be marked as __devinitdata.

Sam cc-ed.

Quoted 9 lines
Quoted 9 lines
drivers/net/sis190.c +0 -0
index b570402..2e9e88b 100644
@@ -326,7 +326,7 @@ static const struct {
 	{ "SiS 191 PCI Gigabit Ethernet adapter" },
 };
 
Quoted 7 lines

drivers/net/sis190.c static const struct { · line 332

Quoted 5 lines
drivers/net/sis190.c +1 -1
-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
+static struct pci_device_id sis190_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
 	{ 0, },

thanks for quick fix.

---
~Randy

#6 lore raw
In reply to Francois Romieu
Quoted 7 lines · Francois Romieu

maximilian attems <[email protected]> :

Quoted 6 lines

CC [M] drivers/net/sis190.o
drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

Looks like a bug where __initdata has been used
for const data.
Searching:
static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
struct net_device *dev)

{
        static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
        struct sis190_private *tp = netdev_priv(dev);
        struct pci_dev *isa_bridge;
        u8 reg, tmp8;

Try to change this is __initconst and it should be fixed.

Sam

#7 lore raw
Quoted 14 lines · Sam Ravnborg
Quoted 7 lines · Francois Romieu

maximilian attems <[email protected]> :

Quoted 6 lines

CC [M] drivers/net/sis190.o
drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

Looks like a bug where __initdata has been used
for const data.
Searching:
static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
struct net_device *dev)

Quoted 7 lines
{
        static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
        struct sis190_private *tp = netdev_priv(dev);
        struct pci_dev *isa_bridge;
        u8 reg, tmp8;

Try to change this is __initconst and it should be fixed.

We have __initconst now?

Three cheers, and a beer, to whomever did that...

Jeff

#8 lore raw
Quoted 22 lines · Jeff Garzik
Quoted 21 lines · Sam Ravnborg
Quoted 8 lines · Francois Romieu

maximilian attems <[email protected]> :

Quoted 7 lines

CC [M] drivers/net/sis190.o
drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict
make[5]: *** [drivers/net/sis190.o] Error 1

gcc --version
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

Looks like a bug where __initdata has been used
for const data.
Searching:
static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
struct net_device *dev)

{
       static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
       struct sis190_private *tp = netdev_priv(dev);
       struct pci_dev *isa_bridge;
       u8 reg, tmp8;
Quoted 5 lines
Quoted 1 line

Try to change this is __initconst and it should be fixed.

We have __initconst now?

Three cheers, and a beer, to whomever did that...

I will hand over the cheers to Jan Beulich and drink the beer myself ;-)

Sam