KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
Quoted 4 lines
Currently, make
headers_checkbarfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, exportkvm.honly if the arch actually supports it.
This makes headers_install_all unreliable.linux/kvm.h will not be exported, depending on what system the libc headers will be generated. Please revert fb56dbb31c4738a3918db81fd24da732ce3b4ae6 and find a different way to run make headers_check successfully.
Similar CONFIG_* usage is in include/asm-cris/Kbuild. Fortunately, its not relevant in practice.
Quoted 8 lines · Olaf Hering
Quoted 4 lines
Currently, make
headers_checkbarfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, exportkvm.honly if the arch actually supports it.This makes
headers_install_allunreliable.linux/kvm.hwill not be exported, depending on what system the libc headers will be generated.
I see. Any suggestions besides adding lots of asm-*/kvm.h?
Signature · 1 line
Any sufficiently difficult bug is indistinguishable from a feature.
Quoted 8 lines · Avi Kivity
Quoted 7 lines · Olaf Hering
Quoted 6 lines
Currently, make
headers_checkbarfs due to <asm/kvm.h>, which <linux/kvm.h>
includes, not existing. Rather than add a zillion <asm/kvm.h>s, exportkvm.h
only if the arch actually supports it.
Quoted 5 lines
Quoted 3 lines
This makes
headers_install_allunreliable.linux/kvm.hwill not be exported, depending on what system the libc headers will be generated.I see. Any suggestions besides adding lots of
asm-*/kvm.h?
Do not include asm/kvm.h from linux/kvm.h.
And in the few places where it is needed explicit include asm/kvm.h before linux/kvm.h.
Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.
Sam
Quoted 16 lines · Sam Ravnborg
Quoted 7 lines · Avi Kivity
Quoted 5 lines · Olaf Hering
Quoted 5 lines
Currently, make
headers_checkbarfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, exportkvm.honly if the arch actually supports it.Quoted 6 lines
Quoted 4 lines
This makes
headers_install_allunreliable.linux/kvm.hwill not be exported, depending on what system the libc headers will be generated.I see. Any suggestions besides adding lots of
asm-*/kvm.h?
Quoted 7 lines
Do not include
asm/kvm.hfromlinux/kvm.h.
And in the few places where it is needed explicit includeasm/kvm.hbeforelinux/kvm.h.Alternatively inlcude
asm/kvm.hinside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.
That's not very nice for userspace, which needs asm/kvm.h for the arch specific parts of the interface. I'll add asm-*/kvm.h.
Signature · 1 line
Any sufficiently difficult bug is indistinguishable from a feature.
Quoted 21 lines · Avi Kivity
Quoted 20 lines · Sam Ravnborg
Quoted 8 lines · Avi Kivity
Quoted 6 lines · Olaf Hering
Quoted 6 lines
Currently, make
headers_checkbarfs due to <asm/kvm.h>, which <linux/kvm.h>
includes, not existing. Rather than add a zillion <asm/kvm.h>s, exportkvm.h
only if the arch actually supports it.Quoted 5 lines
Quoted 3 lines
This makes
headers_install_allunreliable.linux/kvm.hwill not be exported, depending on what system the libc headers will be generated.I see. Any suggestions besides adding lots of
asm-*/kvm.h?Do not include
asm/kvm.hfromlinux/kvm.h.
And in the few places where it is needed explicit includeasm/kvm.hbeforelinux/kvm.h.
Quoted 6 lines
Quoted 3 lines
Alternatively inlcude
asm/kvm.hinside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.That's not very nice for userspace, which needs
asm/kvm.hfor the arch specific parts of the interface. I'll addasm-*/kvm.h.
Can you please revert this change before 2.6.25 is released? 'make headers_install_all' has to be reliable.
commit fb56dbb31c4738a3918db81fd24da732ce3b4ae6
Author: Avi Kivity <[email protected]>
Date: Sun Dec 2 10:50:06 2007 +0200
KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM
Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h only if the arch actually supports it.