Skip to contentSkip to conversation

KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

DISCUSSION Olaf Hering 3 participants 5 messages Feb 10, 2008 – Mar 13, 2008

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines

Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h only if the arch actually supports it.

This makes headers_install_all unreliable.
linux/kvm.h will not be exported, depending on what system the libc headers will be generated. Please revert fb56dbb31c4738a3918db81fd24da732ce3b4ae6 and find a different way to run make headers_check successfully.

Similar CONFIG_* usage is in include/asm-cris/Kbuild. Fortunately, its not relevant in practice.

#1 lore raw
Quoted 8 lines · Olaf Hering
Quoted 4 lines

Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h only if the arch actually supports it.

This makes headers_install_all unreliable.
linux/kvm.h will not be exported, depending on what system the libc headers will be generated.

I see. Any suggestions besides adding lots of asm-*/kvm.h?

Signature · 1 line
Any sufficiently difficult bug is indistinguishable from a feature.
#2 lore raw
Quoted 8 lines · Avi Kivity
Quoted 7 lines · Olaf Hering
Quoted 6 lines

Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h>
includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h
only if the arch actually supports it.

Quoted 5 lines
Quoted 3 lines

This makes headers_install_all unreliable.
linux/kvm.h will not be exported, depending on what system the libc headers will be generated.

I see. Any suggestions besides adding lots of asm-*/kvm.h?

Do not include asm/kvm.h from linux/kvm.h.
And in the few places where it is needed explicit include asm/kvm.h before linux/kvm.h.

Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.

Sam

#3 lore raw
Quoted 16 lines · Sam Ravnborg
Quoted 7 lines · Avi Kivity
Quoted 5 lines · Olaf Hering
Quoted 5 lines

Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h only if the arch actually supports it.

Quoted 6 lines
Quoted 4 lines

This makes headers_install_all unreliable.
linux/kvm.h will not be exported, depending on what system the libc headers will be generated.

I see. Any suggestions besides adding lots of asm-*/kvm.h?

Quoted 7 lines

Do not include asm/kvm.h from linux/kvm.h.
And in the few places where it is needed explicit include asm/kvm.h before linux/kvm.h.

Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.

That's not very nice for userspace, which needs asm/kvm.h for the arch specific parts of the interface. I'll add asm-*/kvm.h.

Signature · 1 line
Any sufficiently difficult bug is indistinguishable from a feature.
#4 lore raw
Quoted 21 lines · Avi Kivity
Quoted 20 lines · Sam Ravnborg
Quoted 8 lines · Avi Kivity
Quoted 6 lines · Olaf Hering
Quoted 6 lines

Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h>
includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h
only if the arch actually supports it.

Quoted 5 lines
Quoted 3 lines

This makes headers_install_all unreliable.
linux/kvm.h will not be exported, depending on what system the libc headers will be generated.

I see. Any suggestions besides adding lots of asm-*/kvm.h?

Do not include asm/kvm.h from linux/kvm.h.
And in the few places where it is needed explicit include asm/kvm.h before linux/kvm.h.

Quoted 6 lines
Quoted 3 lines

Alternatively inlcude asm/kvm.h inside #ifdef KERNEL"
so only userspace has to do explicit include of asm before linux variant.

That's not very nice for userspace, which needs asm/kvm.h for the arch specific parts of the interface. I'll add asm-*/kvm.h.

Can you please revert this change before 2.6.25 is released? 'make headers_install_all' has to be reliable.

commit fb56dbb31c4738a3918db81fd24da732ce3b4ae6
Author: Avi Kivity <[email protected]>
Date: Sun Dec 2 10:50:06 2007 +0200

KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM

Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export kvm.h only if the arch actually supports it.