Skip to contentSkip to conversation

dasd: do not force use of deadline IO scheduler

PATCH Heiko Carstens 1 participant 1 message Mar 5, 2008 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 19 lines
Quoted 7 lines

Considering the call trace you sent:

Review

Quoted 2 lines
(quoted diff) +0 -2
-	elevator_exit(block->request_queue->elevator);
-	rc = elevator_init(block->request_queue, "deadline");

block->request_queue->elevator = NULL is missing here.

Quoted 6 lines

Review

Quoted 4 lines
(quoted diff) +0 -4
-	if (rc) {
-		blk_cleanup_queue(block->request_queue);
-		return rc;
-	}

Fallback to noop and printing a warning wouldn't be bad.

Is noop better than the default (e.g., CFQ)?

I was thinking that if the deadline init fails, we put back the old elevator
- whatever it may be.

Quoted 6 lines
Quoted 2 lines

In addition something like depends on IOSCHED_DEADLINE should be added to the Kconfig file.

Alright, so...

1) Kconfig change, ->elevator = NULL

That should be the way to go, since we want the deadline scheduler.