dasd: do not force use of deadline IO scheduler
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 19 lines
Quoted 7 lines
Considering the call trace you sent:
Review
Quoted 2 lines
(quoted diff) +0
-2- elevator_exit(block->request_queue->elevator); - rc = elevator_init(block->request_queue, "deadline");
block->request_queue->elevator= NULL is missing here.Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +0
-4- if (rc) { - blk_cleanup_queue(block->request_queue); - return rc; - }Fallback to noop and printing a warning wouldn't be bad.
Is noop better than the default (e.g., CFQ)?
I was thinking that if the deadline init fails, we put back the old elevator
- whatever it may be.
Quoted 6 lines
Quoted 2 lines
In addition something like depends on
IOSCHED_DEADLINEshould be added to theKconfigfile.Alright, so...
1)
Kconfigchange, ->elevator = NULL
That should be the way to go, since we want the deadline scheduler.