Skip to contentSkip to conversation

Input: adbhid - restore_capslock_events fixes

PATCH In review Rodney Lorrimar 2 participants 2 messages Apr 23, 2008 – Apr 25, 2008

lore
Share & tools
lore
#0 lore raw

cover Input: adbhid - restore_capslock_events fixes

Hi Dmitry,

Would you consider these for review and inclusion in the input tree?

They fix 2 out of 3 problems I know of in the simulation of capslock up/down key events on Apple laptop keyboards. The third problem - that sometimes the capslock key gets stuck down - I haven't looked at properly yet, but I know that the "capslock key up" packet is never received by adbhid_keyboard_input so the problem is in adb.c or via-pmu.c, or possibly the hardware never sends the event at all.

Pavel Machek suggested removing the parameter, and I would do this after fixing the third problem. This would probably happen after the once-or-twice-a-day event of stuck capslock annoys me enough to have a deeper look.

Thanks,

Rodney

Rodney Lorrimar (2):
Input: adbhid - fix capslock key state after suspend
Input: adbhid - capslock and power button fix

 drivers/macintosh/adbhid.c |   58 +++++++++++++++++++++++++++++++++++++-------
 1 files changed, 49 insertions(+), 9 deletions(-)
#1 lore raw

Hi Rodney,

Quoted 6 lines · Rodney Lorrimar

Hi Dmitry,

Would you consider these for review and inclusion in the input tree?

They fix 2 out of 3 problems I know of in the simulation of capslock up/down key events on Apple laptop keyboards.

They look reasonable, I will apply them, thank you.

Quoted 11 lines

The third problem - that
sometimes the capslock key gets stuck down - I haven't looked at properly yet, but I know that the "capslock key up" packet is never received by adbhid_keyboard_input so the problem is in adb.c or via-pmu.c, or possibly the hardware never sends the event at all.

Pavel Machek suggested removing the parameter, and I would do this after fixing the third problem. This would probably happen after the once-or-twice-a-day event of stuck capslock annoys me enough to have a deeper look.

OK.

Signature · 1 line
Dmitry