Skip to content

Input: adbhid - restore_capslock_events fixes

Rodney Lorrimar lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Input: adbhid - fix capslock key state after suspenddrivers/macintosh/adbhid.c+37 -60 replies
2/2Input: adbhid - capslock and power button fixdrivers/macintosh/adbhid.c+12 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Input: adbhid - restore_capslock_events fixes

Hi Dmitry,

Would you consider these for review and inclusion in the input tree?

They fix 2 out of 3 problems I know of in the simulation of capslock up/down key events on Apple laptop keyboards. The third problem - that sometimes the capslock key gets stuck down - I haven't looked at properly yet, but I know that the "capslock key up" packet is never received by adbhid_keyboard_input so the problem is in adb.c or via-pmu.c, or possibly the hardware never sends the event at all.

Pavel Machek suggested removing the parameter, and I would do this after fixing the third problem. This would probably happen after the once-or-twice-a-day event of stuck capslock annoys me enough to have a deeper look.

Thanks,

Rodney

Rodney Lorrimar (2):
Input: adbhid - fix capslock key state after suspend
Input: adbhid - capslock and power button fix

 drivers/macintosh/adbhid.c |   58 +++++++++++++++++++++++++++++++++++++-------
 1 files changed, 49 insertions(+), 9 deletions(-)