Few more patches for Kumar's powerpc.git
Subsystems (6)
v4 cover Few more patches for Kumar's powerpc.git
Hi Kumar,
Here is the fourth version. Old one started to cause non trivial merge conflicts.
Also, I re-exported the gtm_timer structure, so drivers could actually use its irq member.
Thanks.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
PATCH v4 1/6 sysdev: implement FSL GTM support
GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as found in some QE and CPM chips), or these timers could be used as wakeup events from the CPU deep-sleep mode.
Things unimplemented:
1. Cascaded (32 bit) timers (1-2, 3-4).
This is straightforward to implement when needed, two timers should be marked as "requested" and configured as appropriate.
2. Super-cascaded (64 bit) timers (1-2-3-4).
This is also straightforward to implement when needed, all timers should be marked as "requested" and configured as appropriate.
--- Documentation/powerpc/booting-without-of.txt | 37 +++- arch/powerpc/Kconfig | 5 + arch/powerpc/sysdev/Makefile | 1 + arch/powerpc/sysdev/fsl_gtm.c | 424 ++++++++++++++++++++++++++ include/asm-powerpc/fsl_gtm.h | 47 +++ 5 files changed, 513 insertions(+), 1 deletions(-) create mode 100644 arch/powerpc/sysdev/fsl_gtm.c create mode 100644 include/asm-powerpc/fsl_gtm.h
Documentation/powerpc/booting-without-of.txt +36 -1
@@ -57,7 +57,10 @@ Table of Contents n) 4xx/Axon EMAC ethernet nodes o) Xilinx IP cores p) Freescale Synchronous Serial Interface - q) USB EHCI controllers + q) USB EHCI controllers + r) Freescale Display Interface Unit + s) Freescale on board FPGA + t) Freescale General-purpose Timers Module VII - Marvell Discovery mv64[345]6x System Controller chips 1) The /system-controller node
@@ -2870,6 +2873,38 @@ platforms are moved over to use the flattened-device-tree model. reg = <0xe8000000 32>; }; + t) Freescale General-purpose Timers Module + + Required properties: + - compatible : should be + "fsl,<chip>-gtm", "fsl,gtm" for SOC GTMs + "fsl,<chip>-qe-gtm", "fsl,qe-gtm", "fsl,gtm" for QE GTMs + "fsl,<chip>-cpm2-gtm", "fsl,cpm2-gtm", "fsl,gtm" for CPM2 GTMs + - reg : should contain gtm registers location and length (0x40). + - interrupts : should contain four interrupts. + - interrupt-parent : interrupt source phandle. + - clock-frequency : specifies the frequency driving the timer. + + Example: + + timer@500 { + compatible = "fsl,mpc8360-gtm", "fsl,gtm"; + reg = <0x500 0x40>; + interrupts = <90 8 78 8 84 8 72 8>; + interrupt-parent = <&ipic>; + /* filled by u-boot */ + clock-frequency = <0>; + }; + + timer@440 { + compatible = "fsl,mpc8360-qe-gtm", "fsl,qe-gtm", "fsl,gtm"; + reg = <0x440 0x40>; + interrupts = <12 13 14 15>; + interrupt-parent = <&qeic>; + /* filled by u-boot */ + clock-frequency = <0>; + }; + VII - Marvell Discovery mv64[345]6x System Controller chips ===========================================================
arch/powerpc/Kconfig +5 -0
@@ -538,6 +538,11 @@ config FSL_LBC help Freescale Localbus support +config FSL_GTM + bool + help + Freescale General-purpose Timers support + # Yes MCA RS/6000s exist but Linux-PPC does not currently support any config MCA bool
arch/powerpc/sysdev/Makefile +1 -0
@@ -13,6 +13,7 @@ obj-$(CONFIG_MMIO_NVRAM) += mmio_nvram.o obj-$(CONFIG_FSL_SOC) += fsl_soc.o obj-$(CONFIG_FSL_PCI) += fsl_pci.o obj-$(CONFIG_FSL_LBC) += fsl_lbc.o +obj-$(CONFIG_FSL_GTM) += fsl_gtm.o obj-$(CONFIG_RAPIDIO) += fsl_rio.o obj-$(CONFIG_TSI108_BRIDGE) += tsi108_pci.o tsi108_dev.o obj-$(CONFIG_QUICC_ENGINE) += qe_lib/
arch/powerpc/sysdev/fsl_gtm.c new file +424 -0
424 lines not on this page · raw message
include/asm-powerpc/fsl_gtm.h new file +47 -0
47 lines not on this page · raw message
Signature · 1 line
1.5.5.1
Re: [PATCH 1/6] [POWERPC] sysdev: implement FSL GTM support
Quoted 35 lines · Anton Vorontsov
GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as found in some QE and CPM chips), or these timers could be used as wakeup events from the CPU deep-sleep mode.
Things unimplemented:
1. Cascaded (32 bit) timers (1-2, 3-4).
This is straightforward to implement when needed, two timers should be marked as "requested" and configured as appropriate.
2. Super-cascaded (64 bit) timers (1-2-3-4).
This is also straightforward to implement when needed, all timers should be marked as "requested" and configured as appropriate.Signed-off-by Anton Vorontsov <[email protected]>---
Documentation/powerpc/booting-without-of.txt | 37 +++- arch/powerpc/Kconfig | 5 + arch/powerpc/sysdev/Makefile | 1 + arch/powerpc/sysdev/fsl_gtm.c | 424 +++++++++++++++++ +++++++++ include/asm-powerpc/fsl_gtm.h | 47 +++ 5 files changed, 513 insertions(+), 1 deletions(-)create mode 100644
arch/powerpc/sysdev/fsl_gtm.c
create mode 100644include/asm-powerpc/fsl_gtm.harch/powerpc/Kconfig +0
-0
arch/powerpc/Kconfig config FSL_LBC · line 545
Quoted 8 lines
arch/powerpc/Kconfig +5
-0@@ -538,6 +538,11 @@ config FSL_LBC help Freescale Localbus support +config FSL_GTM + bool + help + Freescale General-purpose Timers support +
what chips actually use this? just QE or 83xx?
- k
Re: [PATCH 1/6] [POWERPC] sysdev: implement FSL GTM support
Quoted 40 lines · Kumar Gala
Quoted 38 lines · Anton Vorontsov
GTM stands for General-purpose Timers Module and able to generate timer{1,2,3,4} interrupts. These timers are used by the drivers that need time precise interrupts (like for USB transactions scheduling for the Freescale USB Host controller as found in some QE and CPM chips), or these timers could be used as wakeup events from the CPU deep-sleep mode.
Things unimplemented:
1. Cascaded (32 bit) timers (1-2, 3-4).
This is straightforward to implement when needed, two timers should be marked as "requested" and configured as appropriate.
2. Super-cascaded (64 bit) timers (1-2-3-4).
This is also straightforward to implement when needed, all timers should be marked as "requested" and configured as appropriate.Signed-off-by Anton Vorontsov <[email protected]>---
Documentation/powerpc/booting-without-of.txt | 37 +++- arch/powerpc/Kconfig | 5 + arch/powerpc/sysdev/Makefile | 1 + arch/powerpc/sysdev/fsl_gtm.c | 424 +++++++++++++++++ +++++++++ include/asm-powerpc/fsl_gtm.h | 47 +++ 5 files changed, 513 insertions(+), 1 deletions(-)create mode 100644
arch/powerpc/sysdev/fsl_gtm.c
create mode 100644include/asm-powerpc/fsl_gtm.harch/powerpc/Kconfig +0
-0@@ -538,6 +538,11 @@ config FSL_LBC help Freescale Localbus support
Quoted 7 lines
arch/powerpc/Kconfig config FSL_LBC · line 545
Quoted 5 lines
arch/powerpc/Kconfig +5
-0+config FSL_GTM + bool + help + Freescale General-purpose Timers support +what chips actually use this? just QE or 83xx?
83xx/85xx, QE, CPM2 and CPM1 (no support).
Probably some more old and new chips.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
PATCH v4 2/6 QE: add support for QE USB clocks routing
In reply to Anton VorontsovThis patch adds a function to the qe_lib to setup QE USB clocks routing. To setup clocks safely, cmxgcr register needs locking, so I just reused ucc_lock since it was used only to protect cmxgcr.
The idea behind placing clocks routing functions into the qe_lib is that later we'll hopefully switch to the generic Linux Clock API, thus, for example, FHCI driver may be used for QE and CPM chips without nasty #ifdefs.
This patch also fixes QE_USB_RESTART_TX command definition in the qe.h.
--- arch/powerpc/sysdev/qe_lib/Kconfig | 4 ++ arch/powerpc/sysdev/qe_lib/Makefile | 1 + arch/powerpc/sysdev/qe_lib/ucc.c | 7 ++-- arch/powerpc/sysdev/qe_lib/usb.c | 56 +++++++++++++++++++++++++++++++++++ include/asm-powerpc/qe.h | 23 +++++++++++++- 5 files changed, 87 insertions(+), 4 deletions(-) create mode 100644 arch/powerpc/sysdev/qe_lib/usb.c
arch/powerpc/sysdev/qe_lib/Kconfig +4 -0
@@ -20,3 +20,7 @@ config UCC bool default y if UCC_FAST || UCC_SLOW +config QE_USB + bool + help + QE USB Host Controller support
arch/powerpc/sysdev/qe_lib/Makefile +1 -0
@@ -6,3 +6,4 @@ obj-$(CONFIG_QUICC_ENGINE)+= qe.o qe_ic.o qe_io.o obj-$(CONFIG_UCC) += ucc.o obj-$(CONFIG_UCC_SLOW) += ucc_slow.o obj-$(CONFIG_UCC_FAST) += ucc_fast.o +obj-$(CONFIG_QE_USB) += usb.o
arch/powerpc/sysdev/qe_lib/ucc.c +4 -3
@@ -26,7 +26,8 @@#include <asm/qe.h> #include <asm/ucc.h> -static DEFINE_SPINLOCK (ucc_lock); +DEFINE_SPINLOCK (cmxgcr_lock); +EXPORT_SYMBOL (cmxgcr_lock);int ucc_set_qe_mux_mii_mng (unsigned int ucc_num) {
@@ -35,10 +36,10 @@ int ucc_set_qe_mux_mii_mng(unsigned int ucc_num)if (ucc_num >UCC_MAX_NUM -1 )return -EINVAL ; -spin_lock_irqsave (&ucc_lock, flags); +spin_lock_irqsave (&cmxgcr_lock, flags);clrsetbits_be32 (&qe_immr->qmx.cmxgcr,QE_CMXGCR_MII_ENET_MNG , ucc_num <<QE_CMXGCR_MII_ENET_MNG_SHIFT ); -spin_unlock_irqrestore (&ucc_lock, flags); +spin_unlock_irqrestore (&cmxgcr_lock, flags);return 0 ; }
arch/powerpc/sysdev/qe_lib/usb.c new file +56 -0
56 lines not on this page · raw message
include/asm-powerpc/qe.h +22 -1
@@ -16,6 +16,7 @@#define _ASM_POWERPC_QE_H#ifdef __KERNEL__ +#include <linux/spinlock.h> #include <asm/immap_qe.h> #define QE_NUM_OF_SNUM 28
@@ -74,6 +75,13 @@ enum qe_clock { QE_CLK_DUMMY }; +static inline bool qe_clock_is_brg (enum qe_clock clk) +{ +return clk >=QE_BRG1 && clk <=QE_BRG16 ; +} + +extern spinlock_t cmxgcr_lock; +/* Export QE common operations */ extern void qe_reset (void );extern int par_io_init (struct device_node *np);
@@ -156,6 +164,9 @@ int qe_upload_firmware(const struct qe_firmware *firmware);/* Obtain information on the uploaded firmware */ struct qe_firmware_info *qe_get_firmware_info (void ); +/* QE USB */ +int qe_usb_clock_set (enum qe_clock clk,int rate); +/* Buffer descriptors */ struct qe_bd {__be16 status;
@@ -254,6 +265,16 @@ enum comm_dir {#define QE_CMXGCR_MII_ENET_MNG 0x00007000#define QE_CMXGCR_MII_ENET_MNG_SHIFT 12#define QE_CMXGCR_USBCS 0x0000000f +#define QE_CMXGCR_USBCS_CLK3 0x1 +#define QE_CMXGCR_USBCS_CLK5 0x2 +#define QE_CMXGCR_USBCS_CLK7 0x3 +#define QE_CMXGCR_USBCS_CLK9 0x4 +#define QE_CMXGCR_USBCS_CLK13 0x5 +#define QE_CMXGCR_USBCS_CLK17 0x6 +#define QE_CMXGCR_USBCS_CLK19 0x7 +#define QE_CMXGCR_USBCS_CLK21 0x8 +#define QE_CMXGCR_USBCS_BRG9 0x9 +#define QE_CMXGCR_USBCS_BRG10 0xa/* QE CECR Commands. */
@@ -283,7 +304,7 @@ enum comm_dir {#define QE_HPAC_START_TX 0x0000060b#define QE_HPAC_START_RX 0x0000070b#define QE_USB_STOP_TX 0x0000000a -#define QE_USB_RESTART_TX 0x0000000b +#define QE_USB_RESTART_TX 0x0000000c#define QE_QMC_STOP_TX 0x0000000c#define QE_QMC_STOP_RX 0x0000000d#define QE_SS7_SU_FIL_RESET 0x0000000e
Signature · 1 line
1.5.5.1
Re: [PATCH 2/6] [POWERPC] QE: add support for QE USB clocks routing
Quoted 11 lines · Anton Vorontsov
This patch adds a function to the
qe_libto setup QE USB clocks routing. To setup clocks safely, cmxgcr register needs locking, so I just reuseducc_locksince it was used only to protect cmxgcr.The idea behind placing clocks routing functions into the
qe_libis that later we'll hopefully switch to the generic Linux Clock API, thus, for example, FHCI driver may be used for QE and CPM chips without nasty #ifdefs.This patch also fixes
QE_USB_RESTART_TXcommand definition in theqe.h.Signed-off-by Anton Vorontsov <[email protected]>
Anton, please be sure to CC: me on any QE library patches you send out.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Re: [PATCH 2/6] [POWERPC] QE: add support for QE USB clocks routing
Quoted 9 lines · Timur Tabi
Quoted 8 lines · Anton Vorontsov
This patch adds a function to the
qe_libto setup QE USB clocks routing. To setup clocks safely, cmxgcr register needs locking, so I just reuseducc_locksince it was used only to protect cmxgcr.The idea behind placing clocks routing functions into the
qe_libis that later we'll hopefully switch to the generic Linux Clock API, thus, for example, FHCI driver may be used for QE and CPM chips without nasty #ifdefs.
Quoted 5 lines
Quoted 3 lines
This patch also fixes
QE_USB_RESTART_TXcommand definition in theqe.h.Signed-off-by Anton Vorontsov <[email protected]>Acked-by Timur Tabi <[email protected]>
Much thanks for the review and Acks.
Quoted 1 line
Anton, please be sure to CC: me on any QE library patches you send out.
Sorry about that. I actually know that QE changes should be Cc: you, but I always forget this. :-/ I should automate Ccing, someday.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
PATCH v4 3/6 QE: prepare QE PIO code for GPIO LIB support
In reply to Anton Vorontsov- split and export __par_io_config_pin() out of par_io_config_pin(), so we could use the prefixed version with GPIO LIB API;
- rename struct port_regs to qe_pio_regs, and place it into qe.h;
- rename #define NUM_OF_PINS to QE_PIO_PINS, and place it into qe.h.
--- arch/powerpc/sysdev/qe_lib/qe_io.c | 94 +++++++++++++++++------------------- include/asm-powerpc/qe.h | 19 +++++++ 2 files changed, 64 insertions(+), 49 deletions(-)
arch/powerpc/sysdev/qe_lib/qe_io.c +45 -49
@@ -28,21 +28,7 @@#undef DEBUG -#define NUM_OF_PINS 32 - -struct port_regs { -__be32 cpodr;/* Open drain register */ -__be32 cpdata;/* Data register */ -__be32 cpdir1;/* Direction register */ -__be32 cpdir2;/* Direction register */ -__be32 cppar1;/* Pin assignment register */ -__be32 cppar2;/* Pin assignment register */ -#ifdef CONFIG_PPC_85xx -u8 pad[8 ]; -#endif -}; - -static struct port_regs __iomem *par_io; +static struct qe_pio_regs __iomem *par_io;static int num_par_io_ports =0 ;int par_io_init (struct device_node *np)
@@ -64,69 +50,79 @@ int par_io_init(struct device_node *np)return 0 ; } -int par_io_config_pin (u8 port,u8 pin,int dir,int open_drain, -int assignment,int has_irq) +void __par_io_config_pin (struct qe_pio_regs __iomem *par_io,u8 pin,int dir, +int open_drain,int assignment,int has_irq) { -u32 pin_mask1bit, pin_mask2bits, new_mask2bits, tmp_val; - -if (!par_io) -return -1 ; +u32 pin_mask1bit; +u32 pin_mask2bits; +u32 new_mask2bits; +u32 tmp_val;/* calculate pin location for single and 2 bits information */ - pin_mask1bit = (u32) (1 << (NUM_OF_PINS - (pin +1 ))); + pin_mask1bit = (u32) (1 << (QE_PIO_PINS - (pin +1 )));/* Set open drain, if required */ - tmp_val =in_be32 (&par_io[port].cpodr); + tmp_val =in_be32 (&par_io->cpodr);if (open_drain) -out_be32 (&par_io[port].cpodr, pin_mask1bit | tmp_val); +out_be32 (&par_io->cpodr, pin_mask1bit | tmp_val);else -out_be32 (&par_io[port].cpodr, ~pin_mask1bit & tmp_val); +out_be32 (&par_io->cpodr, ~pin_mask1bit & tmp_val);/* define direction */ - tmp_val = (pin > (NUM_OF_PINS /2 ) -1 ) ? -in_be32 (&par_io[port].cpdir2) : -in_be32 (&par_io[port].cpdir1); + tmp_val = (pin > (QE_PIO_PINS /2 ) -1 ) ? +in_be32 (&par_io->cpdir2) : +in_be32 (&par_io->cpdir1);/* get all bits mask for 2 bit per port */ - pin_mask2bits = (u32) (0x3 << (NUM_OF_PINS - - (pin % (NUM_OF_PINS /2 ) +1 ) *2 )); + pin_mask2bits = (u32) (0x3 << (QE_PIO_PINS - + (pin % (QE_PIO_PINS /2 ) +1 ) *2 ));/* Get the final mask we need for the right definition */ - new_mask2bits = (u32) (dir << (NUM_OF_PINS - - (pin % (NUM_OF_PINS /2 ) +1 ) *2 )); + new_mask2bits = (u32) (dir << (QE_PIO_PINS - + (pin % (QE_PIO_PINS /2 ) +1 ) *2 ));/* clear and set 2 bits mask */ -if (pin > (NUM_OF_PINS /2 ) -1 ) { -out_be32 (&par_io[port].cpdir2, +if (pin > (QE_PIO_PINS /2 ) -1 ) { +out_be32 (&par_io->cpdir2, ~pin_mask2bits & tmp_val); tmp_val &= ~pin_mask2bits; -out_be32 (&par_io[port].cpdir2, new_mask2bits | tmp_val); +out_be32 (&par_io->cpdir2, new_mask2bits | tmp_val); }else { -out_be32 (&par_io[port].cpdir1, +out_be32 (&par_io->cpdir1, ~pin_mask2bits & tmp_val); tmp_val &= ~pin_mask2bits; -out_be32 (&par_io[port].cpdir1, new_mask2bits | tmp_val); +out_be32 (&par_io->cpdir1, new_mask2bits | tmp_val); }/* define pin assignment */ - tmp_val = (pin > (NUM_OF_PINS /2 ) -1 ) ? -in_be32 (&par_io[port].cppar2) : -in_be32 (&par_io[port].cppar1); + tmp_val = (pin > (QE_PIO_PINS /2 ) -1 ) ? +in_be32 (&par_io->cppar2) : +in_be32 (&par_io->cppar1); - new_mask2bits = (u32) (assignment << (NUM_OF_PINS - - (pin % (NUM_OF_PINS /2 ) +1 ) *2 )); + new_mask2bits = (u32) (assignment << (QE_PIO_PINS - + (pin % (QE_PIO_PINS /2 ) +1 ) *2 ));/* clear and set 2 bits mask */ -if (pin > (NUM_OF_PINS /2 ) -1 ) { -out_be32 (&par_io[port].cppar2, +if (pin > (QE_PIO_PINS /2 ) -1 ) { +out_be32 (&par_io->cppar2, ~pin_mask2bits & tmp_val); tmp_val &= ~pin_mask2bits; -out_be32 (&par_io[port].cppar2, new_mask2bits | tmp_val); +out_be32 (&par_io->cppar2, new_mask2bits | tmp_val); }else { -out_be32 (&par_io[port].cppar1, +out_be32 (&par_io->cppar1, ~pin_mask2bits & tmp_val); tmp_val &= ~pin_mask2bits; -out_be32 (&par_io[port].cppar1, new_mask2bits | tmp_val); +out_be32 (&par_io->cppar1, new_mask2bits | tmp_val); } +} +EXPORT_SYMBOL (__par_io_config_pin); + +int par_io_config_pin (u8 port,u8 pin,int dir,int open_drain, +int assignment,int has_irq) +{ +if (!par_io || port >= num_par_io_ports) +return -EINVAL ; +__par_io_config_pin (&par_io[port], pin, dir, open_drain, assignment, + has_irq);return 0 ; }EXPORT_SYMBOL (par_io_config_pin);
@@ -137,10 +133,10 @@ int par_io_data_set(u8 port, u8 pin, u8 val)if (port >= num_par_io_ports)return -EINVAL ; -if (pin >=NUM_OF_PINS ) +if (pin >=QE_PIO_PINS )return -EINVAL ;/* calculate pin location */ - pin_mask = (u32) (1 << (NUM_OF_PINS -1 - pin)); + pin_mask = (u32) (1 << (QE_PIO_PINS -1 - pin)); tmp_val =in_be32 (&par_io[port].cpdata);
include/asm-powerpc/qe.h +19 -0
@@ -84,8 +84,27 @@ extern spinlock_t cmxgcr_lock;/* Export QE common operations */ extern void qe_reset (void ); + +/* QE PIO */ +#define QE_PIO_PINS 32 + +struct qe_pio_regs { +__be32 cpodr;/* Open drain register */ +__be32 cpdata;/* Data register */ +__be32 cpdir1;/* Direction register */ +__be32 cpdir2;/* Direction register */ +__be32 cppar1;/* Pin assignment register */ +__be32 cppar2;/* Pin assignment register */ +#ifdef CONFIG_PPC_85xx +u8 pad[8 ]; +#endif +}; +extern int par_io_init (struct device_node *np);extern int par_io_of_config (struct device_node *np); +extern void __par_io_config_pin (struct qe_pio_regs __iomem *par_io,u8 pin, +int dir,int open_drain,int assignment, +int has_irq);extern int par_io_config_pin (u8 port,u8 pin,int dir,int open_drain,int assignment,int has_irq);extern int par_io_data_set (u8 port,u8 pin,u8 val);
Signature · 1 line
1.5.5.1
Re: [PATCH 3/6] [POWERPC] QE: prepare QE PIO code for GPIO LIB support
Quoted 6 lines · Anton Vorontsov
- split and export
__par_io_config_pin()out ofpar_io_config_pin(), so we could use the prefixed version with GPIO LIB API;
- rename structport_regstoqe_pio_regs, and place it intoqe.h;
- rename #defineNUM_OF_PINStoQE_PIO_PINS, and place it intoqe.h.Signed-off-by Anton Vorontsov <[email protected]>
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
PATCH v4 4/6 QE: implement support for the GPIO LIB API
In reply to Anton VorontsovThis is needed to access QE GPIOs via Linux GPIO API.
--- Documentation/powerpc/booting-without-of.txt | 37 ++++--- arch/powerpc/sysdev/qe_lib/Kconfig | 9 ++ arch/powerpc/sysdev/qe_lib/Makefile | 1 + arch/powerpc/sysdev/qe_lib/gpio.c | 145 ++++++++++++++++++++++++++ include/asm-powerpc/qe.h | 1 + 5 files changed, 180 insertions(+), 13 deletions(-) create mode 100644 arch/powerpc/sysdev/qe_lib/gpio.c
Documentation/powerpc/booting-without-of.txt +23 -12
@@ -1723,24 +1723,35 @@ platforms are moved over to use the flattened-device-tree model. information. Required properties: - - device_type : should be "par_io". + - #gpio-cells : should be "2". + - compatible : should be "fsl,<chip>-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank". - reg : offset to the register set and its length. - - num-ports : number of Parallel I/O ports + - gpio-controller : node to identify gpio controllers. - Example: - par_io@1400 { - reg = <1400 100>; - #address-cells = <1>; - #size-cells = <0>; - device_type = "par_io"; - num-ports = <7>; - ucc_pin@01 { - ...... - }; + For example, two QE Par I/O banks: + qe_pio_a: gpio-controller@1400 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1400 0x18>; + gpio-controller; + }; + qe_pio_e: gpio-controller@1460 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1460 0x18>; + gpio-controller; + }; vi) Pin configuration nodes + NOTE: pin configuration nodes are obsolete. Usually, their existance + is an evidence of the firmware shortcomings. Such fixups are + better handled by the Linux board file, not the device tree. + Required properties: - linux,phandle : phandle of this node; likely referenced by a QE device.
arch/powerpc/sysdev/qe_lib/Kconfig +9 -0
@@ -24,3 +24,12 @@ config QE_USB bool help QE USB Host Controller support + +config QE_GPIO + bool "QE GPIO support" + depends on QUICC_ENGINE + select GENERIC_GPIO + select HAVE_GPIO_LIB + help + Say Y here if you're going to use hardware that connects to the + QE GPIOs.
arch/powerpc/sysdev/qe_lib/Makefile +1 -0
@@ -7,3 +7,4 @@ obj-$(CONFIG_UCC) += ucc.o obj-$(CONFIG_UCC_SLOW) += ucc_slow.o obj-$(CONFIG_UCC_FAST) += ucc_fast.o obj-$(CONFIG_QE_USB) += usb.o +obj-$(CONFIG_QE_GPIO) += gpio.o
arch/powerpc/sysdev/qe_lib/gpio.c new file +145 -0
145 lines not on this page · raw message
include/asm-powerpc/qe.h +1 -0
@@ -100,6 +100,7 @@ struct qe_pio_regs {#endif }; +extern void __init qe_add_gpiochips (void );extern int par_io_init (struct device_node *np);extern int par_io_of_config (struct device_node *np); extern void __par_io_config_pin(struct qe_pio_regs __iomem *par_io, u8 pin,
Signature · 1 line
1.5.5.1
Re: [PATCH 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 30 lines · Anton Vorontsov
This is needed to access QE GPIOs via Linux GPIO API.
Signed-off-by Anton Vorontsov <[email protected]>--- Documentation/powerpc/booting-without-of.txt | 37 ++++--- arch/powerpc/sysdev/qe_lib/Kconfig | 9 ++ arch/powerpc/sysdev/qe_lib/Makefile | 1 + arch/powerpc/sysdev/qe_lib/gpio.c | 145 ++++++++++++++++++++++++++ include/asm-powerpc/qe.h | 1 + 5 files changed, 180 insertions(+), 13 deletions(-) create mode 100644 arch/powerpc/sysdev/qe_lib/gpio.cDocumentation/powerpc/booting-without-of.txt +4
-4@@ -1723,24 +1723,35 @@ platforms are moved over to use the flattened-device-tree model. information. Required properties: - - device_type : should be "par_io". + - #gpio-cells : should be "2". + - compatible : should be "fsl,<chip>-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank". - reg : offset to the register set and its length. - - num-ports : number of Parallel I/O ports + - gpio-controller : node to identify gpio controllers. - Example: - par_io@1400 {
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 1733
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt +2
-8- reg = <1400 100>; - #address-cells = <1>; - #size-cells = <0>; - device_type = "par_io"; - num-ports = <7>; - ucc_pin@01 { - ...... - }; + For example, two QE Par I/O banks: + qe_pio_a: gpio-controller@1400 {
I think this change will break a number of boards, because a lot of them do this:
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) {
par_io_init(np);So if you're going to change the par_io nodes, you need to change the code as well.
A patch that changes the documentation should also change the code. And if you're code changes the device tree, it should also maintain compatibility for older device trees.
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt +9
-0+ #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1400 0x18>; + gpio-controller; + }; + qe_pio_e: gpio-controller@1460 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank",
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 1753
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt +7
-0+ "fsl,mpc8323-qe-pario-bank"; + reg = <0x1460 0x18>; + gpio-controller; + }; vi) Pin configuration nodes + NOTE: pin configuration nodes are obsolete. Usually, their existance + is an evidence of the firmware shortcomings. Such fixups are + better handled by the Linux board file, not the device tree.
You can't just delete the par_io documentation without updating the code and planning for feature removal. Almost all of the existing code out there for QE boards expects a par_io node, and the device trees still have them.
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model.
Quoted 7 lines
Documentation/powerpc/booting-without-of.txt +7
-0+static int qe_gpio_get(struct gpio_chip *gc, unsigned int gpio) +{ + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); + struct qe_pio_regs __iomem *regs = mm_gc->regs; + u32 pin_mask = 1 << (QE_PIO_PINS - 1 - gpio); + + return !!(in_be32(®s->cpdata) & pin_mask);
Do we need to do "!!"? I thought as long as the result was non-zero, it didn't matter what the actual value is. "!!" converts non-zero to 1.
Documentation/powerpc/booting-without-of.txt
Quoted 9 lines
Documentation/powerpc/booting-without-of.txt +9
-0+static int qe_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) +{ + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); + struct qe_gpio_chip *qe_gc = to_qe_gpio_chip(mm_gc); + unsigned long flags; + + spin_lock_irqsave(&qe_gc->lock, flags); + + __par_io_config_pin(mm_gc->regs, gpio, 2, 0, 0, 0);
No magic numbers, please.
Quoted 30 lines
Documentation/powerpc/booting-without-of.txt +30
-0+void __init qe_add_gpiochips(void) +{ + int ret; + struct device_node *np; + + for_each_compatible_node(np, NULL, "fsl,mpc8323-qe-pario-bank") { + struct qe_gpio_chip *qe_gc; + struct of_mm_gpio_chip *mm_gc; + struct of_gpio_chip *of_gc; + struct gpio_chip *gc; + + qe_gc = kzalloc(sizeof(*qe_gc), GFP_KERNEL); + if (!qe_gc) { + ret = -ENOMEM; + goto err; + } + + spin_lock_init(&qe_gc->lock); + + mm_gc = &qe_gc->mm_gc; + of_gc = &mm_gc->of_gc; + gc = &of_gc->gc; + + mm_gc->save_regs = qe_gpio_save_regs; + of_gc->gpio_cells = 2; + gc->ngpio = QE_PIO_PINS; + gc->direction_input = qe_gpio_dir_in; + gc->direction_output = qe_gpio_dir_out; + gc->get = qe_gpio_get; + gc->set = qe_gpio_set;
Documentation/powerpc/booting-without-of.txt
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt +10
-0+ + ret = of_mm_gpiochip_add(np, mm_gc); + if (ret) + goto err; + } + + return; +err: + pr_err("%s: registration failed with status %d\n", np->full_name, ret); + of_node_put(np);
Memory leak here. If of_mm_gpiochip_add() fails or if the 2nd call to kzalloc() fails, the already-allocated qe_gc objects won't be released.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Re: [PATCH 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 44 lines · Timur Tabi
Quoted 30 lines · Anton Vorontsov
This is needed to access QE GPIOs via Linux GPIO API.
Signed-off-by Anton Vorontsov <[email protected]>--- Documentation/powerpc/booting-without-of.txt | 37 ++++--- arch/powerpc/sysdev/qe_lib/Kconfig | 9 ++ arch/powerpc/sysdev/qe_lib/Makefile | 1 + arch/powerpc/sysdev/qe_lib/gpio.c | 145 ++++++++++++++++++++++++++ include/asm-powerpc/qe.h | 1 + 5 files changed, 180 insertions(+), 13 deletions(-) create mode 100644 arch/powerpc/sysdev/qe_lib/gpio.cDocumentation/powerpc/booting-without-of.txt +4
-4@@ -1723,24 +1723,35 @@ platforms are moved over to use the flattened-device-tree model. information. Required properties: - - device_type : should be "par_io". + - #gpio-cells : should be "2". + - compatible : should be "fsl,<chip>-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank". - reg : offset to the register set and its length. - - num-ports : number of Parallel I/O ports + - gpio-controller : node to identify gpio controllers. - Example: - par_io@1400 {Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 1733
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt +2
-8- reg = <1400 100>; - #address-cells = <1>; - #size-cells = <0>; - device_type = "par_io"; - num-ports = <7>; - ucc_pin@01 { - ...... - }; + For example, two QE Par I/O banks: + qe_pio_a: gpio-controller@1400 {I think this change will break a number of boards, because a lot of them do this:
Quoted 8 lines
if ((np = of_find_node_by_name(NULL, "par_io")) != NULL) { par_io_init(np);So if you're going to change the
par_ionodes, you need to change the code as well.A patch that changes the documentation should also change the code. And if you're code changes the device tree, it should also maintain compatibility for older device trees.
Well, I'm indeed removing [further] support for the par_io nodes, overwriting it with gpio nodes. That way we'll stop new use cases of these nodes.
Eventually I plan to adjust the existing code/device trees accordingly. If you think that code should be adjusted at the same time as documentation, I'm fine with it as well. I'll just add new documentation instead of replacing the old.
Quoted 17 lines
Quoted 17 lines
Documentation/powerpc/booting-without-of.txt +13
-0+ #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1400 0x18>; + gpio-controller; + }; + qe_pio_e: gpio-controller@1460 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1460 0x18>; + gpio-controller; + }; vi) Pin configuration nodes
Quoted 7 lines
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 1753
Quoted 3 lines
Documentation/powerpc/booting-without-of.txt +3
-0+ NOTE: pin configuration nodes are obsolete. Usually, their existance + is an evidence of the firmware shortcomings. Such fixups are + better handled by the Linux board file, not the device tree.You can't just delete the
par_iodocumentation without updating the code and planning for feature removal. Almost all of the existing code out there for QE boards expects apar_ionode, and the device trees still have them.
Yup, exactly. Old device tree still use them, but don't we want to get rid of this? If so, we should remove documentation, or someone will use it for the new device trees. ;-)
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model.
Quoted 7 lines
Documentation/powerpc/booting-without-of.txt +7
-0+static int qe_gpio_get(struct gpio_chip *gc, unsigned int gpio) +{ + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); + struct qe_pio_regs __iomem *regs = mm_gc->regs; + u32 pin_mask = 1 << (QE_PIO_PINS - 1 - gpio); + + return !!(in_be32(®s->cpdata) & pin_mask);Do we need to do "!!"? I thought as long as the result was non-zero, it didn't matter what the actual value is. "!!" converts non-zero to 1.
Just checked with the Documentation/gpio.txt... yup we don't need this. "The values are boolean, zero for low, nonzero for high."
Quoted 11 lines
Documentation/powerpc/booting-without-of.txt
Quoted 9 lines
Documentation/powerpc/booting-without-of.txt +9
-0+static int qe_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio) +{ + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); + struct qe_gpio_chip *qe_gc = to_qe_gpio_chip(mm_gc); + unsigned long flags; + + spin_lock_irqsave(&qe_gc->lock, flags); + + __par_io_config_pin(mm_gc->regs, gpio, 2, 0, 0, 0);No magic numbers, please.
Ok.
Quoted 35 lines
Quoted 35 lines
Documentation/powerpc/booting-without-of.txt +35
-0+void __init qe_add_gpiochips(void) +{ + int ret; + struct device_node *np; + + for_each_compatible_node(np, NULL, "fsl,mpc8323-qe-pario-bank") { + struct qe_gpio_chip *qe_gc; + struct of_mm_gpio_chip *mm_gc; + struct of_gpio_chip *of_gc; + struct gpio_chip *gc; + + qe_gc = kzalloc(sizeof(*qe_gc), GFP_KERNEL); + if (!qe_gc) { + ret = -ENOMEM; + goto err; + } + + spin_lock_init(&qe_gc->lock); + + mm_gc = &qe_gc->mm_gc; + of_gc = &mm_gc->of_gc; + gc = &of_gc->gc; + + mm_gc->save_regs = qe_gpio_save_regs; + of_gc->gpio_cells = 2; + gc->ngpio = QE_PIO_PINS; + gc->direction_input = qe_gpio_dir_in; + gc->direction_output = qe_gpio_dir_out; + gc->get = qe_gpio_get; + gc->set = qe_gpio_set; + + ret = of_mm_gpiochip_add(np, mm_gc); + if (ret) + goto err; + }
Quoted 8 lines
Documentation/powerpc/booting-without-of.txt
Quoted 5 lines
Documentation/powerpc/booting-without-of.txt +5
-0+ + return; +err: + pr_err("%s: registration failed with status %d\n", np->full_name, ret); + of_node_put(np);Memory leak here. If
of_mm_gpiochip_add()fails or if the 2nd call tokzalloc()fails, the already-allocatedqe_gcobjects won't be released.
Thanks for catching this.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Re: [PATCH 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 3 lines · Anton Vorontsov
Well, I'm indeed removing [further] support for the
par_ionodes, overwriting it with gpio nodes. That way we'll stop new use cases of these nodes.
I have no problem with replacing par_io nodes with gpio nodes.
Quoted 4 lines
Eventually I plan to adjust the existing code/device trees accordingly. If you think that code should be adjusted at the same time as documentation, I'm fine with it as well. I'll just add new documentation instead of replacing the old.
Yes, please.
Quoted 7 lines
Quoted 3 lines
You can't just delete the
par_iodocumentation without updating the code and planning for feature removal. Almost all of the existing code out there for QE boards expects apar_ionode, and the device trees still have them.Yup, exactly. Old device tree still use them, but don't we want to get rid of this? If so, we should remove documentation, or someone will use it for the new device trees. ;-)
It should still be documented, but marked as deprecated. The documentation can be removed only when all the DTS files *and* the code are scrubbed of those kinds of nodes. And you can't remove backwards compatibility for those from the code until at least the next major revision of the kernel.
Look at function of_get_mac_address() for an example. "mac-address" was removed mid last year, but we still support them. Try to isolate the code that support the newer gpio nodes and the older par_io nodes into one function, and it'll be easier to deal with.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
PATCH v2 4/6 QE: implement support for the GPIO LIB API
In reply to Anton VorontsovThis is needed to access QE GPIOs via Linux GPIO API.
---
Updated per Timur Tabi's comments.
Documentation/powerpc/booting-without-of.txt | 27 +++++ arch/powerpc/sysdev/qe_lib/Kconfig | 9 ++ arch/powerpc/sysdev/qe_lib/Makefile | 1 + arch/powerpc/sysdev/qe_lib/gpio.c | 146 ++++++++++++++++++++++++++ include/asm-powerpc/qe.h | 3 + 5 files changed, 186 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/sysdev/qe_lib/gpio.c
Documentation/powerpc/booting-without-of.txt +27 -0
@@ -1738,6 +1738,33 @@ platforms are moved over to use the flattened-device-tree model. ...... }; + Note that "par_io" nodes are obsolete, and should not be used for + the new device trees. Instead, each Par I/O bank should be represented + via its own gpio-controller node: + + Required properties: + - #gpio-cells : should be "2". + - compatible : should be "fsl,<chip>-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank". + - reg : offset to the register set and its length. + - gpio-controller : node to identify gpio controllers. + + Example: + qe_pio_a: gpio-controller@1400 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1400 0x18>; + gpio-controller; + }; + + qe_pio_e: gpio-controller@1460 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1460 0x18>; + gpio-controller; + }; vi) Pin configuration nodes
arch/powerpc/sysdev/qe_lib/Kconfig +9 -0
@@ -24,3 +24,12 @@ config QE_USB bool help QE USB Host Controller support + +config QE_GPIO + bool "QE GPIO support" + depends on QUICC_ENGINE + select GENERIC_GPIO + select HAVE_GPIO_LIB + help + Say Y here if you're going to use hardware that connects to the + QE GPIOs.
arch/powerpc/sysdev/qe_lib/Makefile +1 -0
@@ -7,3 +7,4 @@ obj-$(CONFIG_UCC) += ucc.o obj-$(CONFIG_UCC_SLOW) += ucc_slow.o obj-$(CONFIG_UCC_FAST) += ucc_fast.o obj-$(CONFIG_QE_USB) += usb.o +obj-$(CONFIG_QE_GPIO) += gpio.o
arch/powerpc/sysdev/qe_lib/gpio.c new file +146 -0
146 lines not on this page · raw message
include/asm-powerpc/qe.h +3 -0
@@ -100,8 +100,11 @@ struct qe_pio_regs {#endif }; +extern void __init qe_add_gpiochips (void );extern int par_io_init (struct device_node *np);extern int par_io_of_config (struct device_node *np); +#define QE_PIO_DIR_IN 2 +#define QE_PIO_DIR_OUT 1extern void __par_io_config_pin (struct qe_pio_regs __iomem *par_io,u8 pin,int dir,int open_drain,int assignment,int has_irq);
Signature · 1 line
1.5.5.1
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 1756
Quoted 5 lines · Anton Vorontsov
Documentation/powerpc/booting-without-of.txt +5
-0+ Example: + qe_pio_a: gpio-controller@1400 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank";
I know this is an example, but would we ever include both compatible strings in one DTS? Isn't the norm something like:
"fsl,mpc8360-qe-pario-bank", "fsl,qe-pario-bank";
I.e. specific version, then generic version?
Otherwise, every time we introduce a new QE part, we'll have to update *every* QE-enabled device tree *and* the QE gpio driver.
arch/powerpc/sysdev/qe_lib/gpio.c line 51
Quoted 8 lines
arch/powerpc/sysdev/qe_lib/gpio.c new file +8
-0+static int qe_gpio_get (struct gpio_chip *gc,unsigned int gpio) +{ +struct of_mm_gpio_chip *mm_gc =to_of_mm_gpio_chip (gc); +struct qe_pio_regs __iomem *regs = mm_gc->regs; +u32 pin_mask =1 << (QE_PIO_PINS -1 - gpio); + +return in_be32 (®s->cpdata) & pin_mask; +}
Return value should be "u32", not "int".
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 11 lines · Timur Tabi
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 1756
Quoted 5 lines · Anton Vorontsov
Documentation/powerpc/booting-without-of.txt +5
-0+ Example: + qe_pio_a: gpio-controller@1400 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank";I know this is an example, but would we ever include both compatible strings in one DTS? Isn't the norm something like:
Quoted 3 lines
"fsl,mpc8360-qe-pario-bank", "fsl,qe-pario-bank";
I.e. specific version, then generic version?
Per Grant Likely's comments, "fsl,qe-pario-bank" considered as a made up stuff. MPC8323 is the first QE chip, so every next QE chips should be compatible.
Though, for fsl,gtm we can't use this, since we really want generic name.
Quoted 2 lines
Otherwise, every time we introduce a new QE part, we'll have to update *every* QE-enabled device tree *and* the QE gpio driver.
Nope. If the the QE is compatible with the previous, just write "fsl,newchip-qe-pario-bank", "fsl,mpc8323-qe-pario-bank".
Btw, the same we do for the 8349 compatible PCI.
Quoted 10 lines
arch/powerpc/sysdev/qe_lib/gpio.c line 51
Quoted 8 lines
arch/powerpc/sysdev/qe_lib/gpio.c new file +8
-0+static int qe_gpio_get (struct gpio_chip *gc,unsigned int gpio) +{ +struct of_mm_gpio_chip *mm_gc =to_of_mm_gpio_chip (gc); +struct qe_pio_regs __iomem *regs = mm_gc->regs; +u32 pin_mask =1 << (QE_PIO_PINS -1 - gpio); + +return in_be32 (®s->cpdata) & pin_mask; +}Return value should be "u32", not "int".
gpio.h disagree
$ cat include/asm-generic/gpio.h | grep \*get
int (*get)(struct gpio_chip *chip,Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 3 lines · Anton Vorontsov
Per Grant Likely's comments, "fsl,qe-pario-bank" considered as a made up stuff. MPC8323 is the first QE chip, so every next QE chips should be compatible.
Ok.
Quoted 7 lines
Quoted 1 line
Return value should be "u32", not "int".
gpio.hdisagree$ cat include/asm-generic/gpio.h | grep \*get int (*get)(struct gpio_chip *chip,
In that case, perhaps you should return this:
return in_be32(®s->cpdata) & pin_mask ? 1 : 0;
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 12 lines · Timur Tabi
Quoted 3 lines · Anton Vorontsov
Per Grant Likely's comments, "fsl,qe-pario-bank" considered as a made up stuff. MPC8323 is the first QE chip, so every next QE chips should be compatible.
Ok.
Quoted 4 lines
Quoted 1 line
Return value should be "u32", not "int".
gpio.hdisagree
Quoted 7 lines
Quoted 3 lines
$ cat include/asm-generic/gpio.h | grep \*get int (*get)(struct gpio_chip *chip,In that case, perhaps you should return this:
return in_be32(®s->cpdata) & pin_mask ? 1 : 0;
What is the problem with returning (int)(u32 & u32) value?
You've asked to remove "!!" stuff and now purposing exactly the same... :-?
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 1 line · Anton Vorontsov
What is the problem with returning (int)(u32 & u32) value?
Technically, a signed int is smaller than an unsigned int, so a value of 0x80000000 won't fit in an 'int'.
Quoted 2 lines
You've asked to remove "!!" stuff and now purposing exactly the same... :-?
The !! stuff was because the function was returning a boolean value, so non-zero == TRUE. I don't think the return value from 'get' is a technically a boolean, so I'm assuming that the spec says the return value should be 0 or 1, to reflect the value of that GPIO pin.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 6 lines · Timur Tabi
Quoted 1 line · Anton Vorontsov
What is the problem with returning (int)(u32 & u32) value?
Technically, a signed int is smaller than an unsigned int, so a value of
0x80000000won't fit in an 'int'.
They're of the same size. And because of that, we'll not lose information, so (int)(0x80000000U) still != 0, it is just negative.
Quoted 7 lines
Quoted 2 lines
You've asked to remove "!!" stuff and now purposing exactly the same... :-?
The !! stuff was because the function was returning a boolean value, so non-zero == TRUE. I don't think the return value from 'get' is a technically a boolean, so I'm assuming that the spec says the return value should be 0 or 1, to reflect the value of that GPIO pin.
No. The spec indeed says that 0 for low, non-0 for high.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
Quoted 1 line · Anton Vorontsov
No. The spec indeed says that 0 for low, non-0 for high.
Fair enough.
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
Re: [PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API
In reply to Anton VorontsovQuoted 3 lines · Anton Vorontsov
This is needed to access QE GPIOs via Linux GPIO API.
Signed-off-by Anton Vorontsov <[email protected]>
Signature · 2 lines
Timur Tabi Linux kernel developer at Freescale
PATCH v4 5/6 83xx: new board support: MPC8360E-RDK
In reply to Anton VorontsovThis is patch adds board file, device tree, and defconfig for the new board, made by Freescale Semiconductor Inc. and Logic Product Development.
Currently supported:
1. UEC{1,2,7,4};
2. I2C;
3. SPI;
4. NS16550 serial;
5. PCI and miniPCI;
6. Intel NOR StrataFlash X16 64Mbit PC28F640P30T85;
7. Graphics controller, Fujitsu MB86277.
Not supported in this patch:
1. StMICRO NAND512W3A2BN6E, 512 Mbit (supported with FSL UPM NAND driver);
2. FHCI USB (supported with FHCI driver).
3. QE Serial UCCs (tested to not work with ucc_uart driver, reason unknown, yet);
4. ADC AD7843 (tested to work, but support via device tree depends on major SPI rework, GPIO API, etc);
--- arch/powerpc/boot/dts/mpc836x_rdk.dts | 397 +++++++++ arch/powerpc/configs/83xx/mpc836x_rdk_defconfig | 1090 +++++++++++++++++++++++ arch/powerpc/platforms/83xx/Kconfig | 11 + arch/powerpc/platforms/83xx/Makefile | 1 + arch/powerpc/platforms/83xx/mpc836x_rdk.c | 111 +++ 5 files changed, 1610 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/boot/dts/mpc836x_rdk.dts create mode 100644 arch/powerpc/configs/83xx/mpc836x_rdk_defconfig create mode 100644 arch/powerpc/platforms/83xx/mpc836x_rdk.c
arch/powerpc/boot/dts/mpc836x_rdk.dts new file +397 -0
@@ -0,0 +1,397 @@ +/* + * MPC8360E RDK Device Tree Source + * + * Copyright 2006 Freescale Semiconductor Inc. + * Copyright 2007-2008 MontaVista Software, Inc. + * + * Author: Anton Vorontsov <[email protected]> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your + * option) any later version. + */ + +/dts-v1/; + +/ { + #address-cells = <1>; + #size-cells = <1>; + compatible = "fsl,mpc8360rdk"; + + aliases { + serial0 = &serial0; + serial1 = &serial1; + serial2 = &serial2; + serial3 = &serial3; + ethernet0 = &enet0; + ethernet1 = &enet1; + ethernet2 = &enet2; + ethernet3 = &enet3; + pci0 = &pci0; + }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + PowerPC,8360@0 { + device_type = "cpu"; + reg = <0>; + d-cache-line-size = <32>; + i-cache-line-size = <32>; + d-cache-size = <32768>; + i-cache-size = <32768>; + /* filled by u-boot */ + timebase-frequency = <0>; + bus-frequency = <0>; + clock-frequency = <0>; + }; + }; + + memory { + device_type = "memory"; + /* filled by u-boot */ + reg = <0 0>; + }; + + soc@e0000000 { + #address-cells = <1>; + #size-cells = <1>; + device_type = "soc"; + compatible = "fsl,mpc8360-immr", "fsl,immr", "fsl,soc", + "simple-bus"; + ranges = <0 0xe0000000 0x200000>; + reg = <0xe0000000 0x200>; + /* filled by u-boot */ + bus-frequency = <0>; + + wdt@200 { + compatible = "mpc83xx_wdt"; + reg = <0x200 0x100>; + }; + + i2c@3000 { + #address-cells = <1>; + #size-cells = <0>; + cell-index = <0>; + compatible = "fsl-i2c"; + reg = <0x3000 0x100>; + interrupts = <14 8>; + interrupt-parent = <&ipic>; + dfsrr; + }; + + i2c@3100 { + #address-cells = <1>; + #size-cells = <0>; + cell-index = <1>; + compatible = "fsl-i2c"; + reg = <0x3100 0x100>; + interrupts = <16 8>; + interrupt-parent = <&ipic>; + dfsrr; + }; + + serial0: serial@4500 { + device_type = "serial"; + compatible = "ns16550"; + reg = <0x4500 0x100>; + interrupts = <9 8>; + interrupt-parent = <&ipic>; + /* filled by u-boot */ + clock-frequency = <0>; + }; + + serial1: serial@4600 { + device_type = "serial"; + compatible = "ns16550"; + reg = <0x4600 0x100>; + interrupts = <10 8>; + interrupt-parent = <&ipic>; + /* filled by u-boot */ + clock-frequency = <0>; + }; + + crypto@30000 { + compatible = "fsl,sec2-crypto"; + reg = <0x30000 0x10000>; + interrupts = <11 8>; + interrupt-parent = <&ipic>; + num-channels = <4>; + channel-fifo-len = <24>; + exec-units-mask = <0x7e>; + /* + * desc mask is for rev1.x, we need runtime fixup + * for >=2.x + */ + descriptor-types-mask = <0x1010ebf>; + }; + + ipic: interrupt-controller@700 { + #address-cells = <0>; + #interrupt-cells = <2>; + compatible = "fsl,pq2pro-pic", "fsl,ipic"; + interrupt-controller; + reg = <0x700 0x100>; + }; + + qe_pio_b: gpio-controller@1418 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1418 0x18>; + gpio-controller; + }; + + qe_pio_e: gpio-controller@1460 { + #gpio-cells = <2>; + compatible = "fsl,mpc8360-qe-pario-bank", + "fsl,mpc8323-qe-pario-bank"; + reg = <0x1460 0x18>; + gpio-controller; + }; + + qe@100000 { + #address-cells = <1>; + #size-cells = <1>; + device_type = "qe"; + compatible = "fsl,qe", "simple-bus"; + ranges = <0 0x100000 0x100000>; + reg = <0x100000 0x480>; + /* filled by u-boot */ + clock-frequency = <0>; + bus-frequency = <0>; + brg-frequency = <0>; + + muram@10000 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "fsl,qe-muram", "fsl,cpm-muram"; + ranges = <0 0x10000 0xc000>; + + data-only@0 { + compatible = "fsl,qe-muram-data", + "fsl,cpm-muram-data"; + reg = <0 0xc000>; + }; + }; + + timer@440 { + compatible = "fsl,mpc8360-qe-gtm", + "fsl,qe-gtm", "fsl,gtm"; + reg = <0x440 0x40>; + interrupts = <12 13 14 15>; + interrupt-parent = <&qeic>; + /* filled by u-boot */ + clock-frequency = <0>; + }; + + spi@4c0 { + cell-index = <0>; + compatible = "fsl,spi"; + reg = <0x4c0 0x40>; + interrupts = <2>; + interrupt-parent = <&qeic>; + mode = "cpu-qe"; + }; + + spi@500 { + cell-index = <1>; + compatible = "fsl,spi"; + reg = <0x500 0x40>; + interrupts = <1>; + interrupt-parent = <&qeic>; + mode = "cpu-qe"; + }; + + enet0: ucc@2000 { + device_type = "network"; + compatible = "ucc_geth"; + cell-index = <1>; + reg = <0x2000 0x200>; + interrupts = <32>; + interrupt-parent = <&qeic>; + rx-clock-name = "none"; + tx-clock-name = "clk9"; + phy-handle = <&phy2>; + phy-connection-type = "rgmii-rxid"; + /* filled by u-boot */ + local-mac-address = [ 00 00 00 00 00 00 ]; + }; + + enet1: ucc@3000 { + device_type = "network"; + compatible = "ucc_geth"; + cell-index = <2>; + reg = <0x3000 0x200>; + interrupts = <33>; + interrupt-parent = <&qeic>; + rx-clock-name = "none"; + tx-clock-name = "clk4"; + phy-handle = <&phy4>; + phy-connection-type = "rgmii-rxid"; + /* filled by u-boot */ + local-mac-address = [ 00 00 00 00 00 00 ]; + }; + + enet2: ucc@2600 { + device_type = "network"; + compatible = "ucc_geth"; + cell-index = <7>; + reg = <0x2600 0x200>; + interrupts = <42>; + interrupt-parent = <&qeic>; + rx-clock-name = "clk20"; + tx-clock-name = "clk19"; + phy-handle = <&phy1>; + phy-connection-type = "mii"; + /* filled by u-boot */ + local-mac-address = [ 00 00 00 00 00 00 ]; + }; + + enet3: ucc@3200 { + device_type = "network"; + compatible = "ucc_geth"; + cell-index = <4>; + reg = <0x3200 0x200>; + interrupts = <35>; + interrupt-parent = <&qeic>; + rx-clock-name = "clk8"; + tx-clock-name = "clk7"; + phy-handle = <&phy3>; + phy-connection-type = "mii"; + /* filled by u-boot */ + local-mac-address = [ 00 00 00 00 00 00 ]; + }; + + mdio@2120 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "fsl,ucc-mdio"; + reg = <0x2120 0x18>; + + phy1: ethernet-phy@1 { + device_type = "ethernet-phy"; + compatible = "national,DP83848VV"; + reg = <1>; + }; + + phy2: ethernet-phy@2 { + device_type = "ethernet-phy"; + compatible = "broadcom,BCM5481UA2KMLG"; + reg = <2>; + }; + + phy3: ethernet-phy@3 { + device_type = "ethernet-phy"; + compatible = "national,DP83848VV"; + reg = <3>; + }; + + phy4: ethernet-phy@4 { + device_type = "ethernet-phy"; + compatible = "broadcom,BCM5481UA2KMLG"; + reg = <4>; + }; + }; + + serial2: ucc@2400 { + device_type = "serial"; + compatible = "ucc_uart"; + reg = <0x2400 0x200>; + cell-index = <5>; + port-number = <0>; + rx-clock-name = "brg7"; + tx-clock-name = "brg8"; + interrupts = <40>; + interrupt-parent = <&qeic>; + soft-uart; + }; + + serial3: ucc@3400 { + device_type = "serial"; + compatible = "ucc_uart"; + reg = <0x3400 0x200>; + cell-index = <6>; + port-number = <1>; + rx-clock-name = "brg13"; + tx-clock-name = "brg14"; + interrupts = <41>; + interrupt-parent = <&qeic>; + soft-uart; + }; + + qeic: interrupt-controller@80 { + #address-cells = <0>; + #interrupt-cells = <1>; + compatible = "fsl,qe-ic"; + interrupt-controller; + reg = <0x80 0x80>; + big-endian; + interrupts = <32 8 33 8>; + interrupt-parent = <&ipic>; + }; + }; + }; + + localbus@e0005000 { + #address-cells = <2>; + #size-cells = <1>; + compatible = "fsl,mpc8360-localbus", "fsl,pq2pro-localbus", + "simple-bus"; + reg = <0xe0005000 0xd8>; + ranges = <0 0 0xff800000 0x0800000 + 1 0 0x60000000 0x0001000 + 2 0 0x70000000 0x4000000>; + + flash@0,0 { + compatible = "intel,PC28F640P30T85", "cfi-flash"; + reg = <0 0 0x800000>; + bank-width = <2>; + device-width = <1>; + }; + + display@2,0 { + device_type = "display"; + compatible = "fujitsu,MB86277", "fujitsu,mint"; + reg = <2 0 0x4000000>; + fujitsu,sh3; + little-endian; + /* filled by u-boot */ + address = <0>; + depth = <0>; + width = <0>; + height = <0>; + linebytes = <0>; + /* linux,opened; - added by uboot */ + }; + }; + + pci0: pci@e0008500 { + #address-cells = <3>; + #size-cells = <2>; + #interrupt-cells = <1>; + device_type = "pci"; + compatible = "fsl,mpc8360-pci", "fsl,mpc8349-pci"; + reg = <0xe0008500 0x100>; + ranges = <0x02000000 0 0x90000000 0x90000000 0 0x10000000 + 0x42000000 0 0x80000000 0x80000000 0 0x10000000 + 0x01000000 0 0xe0300000 0xe0300000 0 0x00100000>; + interrupts = <66 8>; + interrupt-parent = <&ipic>; + interrupt-map-mask = <0xf800 0 0 7>; + interrupt-map = </* miniPCI0 IDSEL 0x14 AD20 */ + 0xa000 0 0 1 &ipic 18 8 + 0xa000 0 0 2 &ipic 19 8 + + /* PCI1 IDSEL 0x15 AD21 */ + 0xa800 0 0 1 &ipic 19 8 + 0xa800 0 0 2 &ipic 20 8 + 0xa800 0 0 3 &ipic 21 8 + 0xa800 0 0 4 &ipic 18 8>; + /* filled by u-boot */ + bus-range = <0 0>; + clock-frequency = <0>; + }; +};
arch/powerpc/configs/83xx/mpc836x_rdk_defconfig new file +1090 -0
1,090 lines not on this page · raw message
arch/powerpc/platforms/83xx/Kconfig +11 -0
@@ -58,6 +58,17 @@ config MPC836x_MDS help This option enables support for the MPC836x MDS Processor Board. +config MPC836x_RDK + bool "Freescale/Logic MPC836x RDK" + select DEFAULT_UIMAGE + select QUICC_ENGINE + select QE_GPIO + select FSL_GTM + select FSL_LBC + help + This option enables support for the MPC836x RDK Processor Board, + also known as ZOOM PowerQUICC Kit. + config MPC837x_MDS bool "Freescale MPC837x MDS" select DEFAULT_UIMAGE
arch/powerpc/platforms/83xx/Makefile +1 -0
@@ -8,6 +8,7 @@ obj-$(CONFIG_MPC832x_RDB) += mpc832x_rdb.o obj-$(CONFIG_MPC834x_MDS) += mpc834x_mds.o obj-$(CONFIG_MPC834x_ITX) += mpc834x_itx.o obj-$(CONFIG_MPC836x_MDS) += mpc836x_mds.o +obj-$(CONFIG_MPC836x_RDK) += mpc836x_rdk.o obj-$(CONFIG_MPC832x_MDS) += mpc832x_mds.o obj-$(CONFIG_MPC837x_MDS) += mpc837x_mds.o obj-$(CONFIG_SBC834x) += sbc834x.o
arch/powerpc/platforms/83xx/mpc836x_rdk.c new file +111 -0
111 lines not on this page · raw message
Signature · 1 line
1.5.5.1
Re: [PATCH 5/6] [POWERPC] 83xx: new board support: MPC8360E-RDK
Quoted 25 lines · Anton Vorontsov
This is patch adds board file, device tree, and defconfig for the new board, made by Freescale Semiconductor Inc. and Logic Product Development.
Currently supported:
1. UEC{1,2,7,4};
2. I2C;
3. SPI;
4. NS16550 serial;
5. PCI and miniPCI;
6. Intel NOR StrataFlash X16 64Mbit PC28F640P30T85;
7. Graphics controller, Fujitsu MB86277.Not supported in this patch:
1. StMICRO NAND512W3A2BN6E, 512 Mbit (supported with FSL UPM NAND driver);
2. FHCI USB (supported with FHCI driver).
3. QE Serial UCCs (tested to not work withucc_uartdriver, reason unknown, yet);
4. ADC AD7843 (tested to work, but support via device tree depends on major SPI rework, GPIO API, etc);Signed-off-by Anton Vorontsov <[email protected]>---
arch/powerpc/boot/dts/mpc836x_rdk.dts| 397 +++++++++arch/powerpc/configs/83xx/mpc836x_rdk_defconfig| 1090 ++++++++++++++
+++++++++
Quoted 7 lines
arch/powerpc/platforms/83xx/Kconfig | 11 + arch/powerpc/platforms/83xx/Makefile | 1 + arch/powerpc/platforms/83xx/mpc836x_rdk.c | 111 +++ 5 files changed, 1610 insertions(+), 0 deletions(-)create mode 100644
arch/powerpc/boot/dts/mpc836x_rdk.dtscreate mode 100644arch/powerpc/configs/83xx/mpc836x_rdk_defconfigcreate mode 100644arch/powerpc/platforms/83xx/mpc836x_rdk.c
Can you do me a favor and update mpc83xx_defconfig and make sure that boots and provide that in a separate patch. I want to start making sure we have whatever features boards need enabled in the mpc83xx_defconfig.
thanks
- k
PATCH 1/1 powerpc: 83xx: update mpc83xx_defconfig to support MPC8360E-RDK
This patch updates mpc83xx_defconfig to support MPC8360E-RDK board.
---
On Tue, Jun 10, 2008 at 10:55:39AM -0500, Kumar Gala wrote:
[...]
Quoted 3 lines
Can you do me a favor and update
mpc83xx_defconfigand make sure that boots and provide that in a separate patch. I want to start making sure we have whatever features boards need enabled in thempc83xx_defconfig.
Done. This is on top of your current powerpc-next branch (HEAD at 917f0af9e5a9ce) + applied patches (seems like you forgot to push out the tree).
Thus mpc83xx_defconfig wasn't updated for a long time, so the patch isn't readable.
Here is what I enabled manually:
CONFIG_MPC836x_RDK=y
CONFIG_SERIAL_QE=y
^ it doesn't actually work on RDK (unable to receive the data), but I believe it's QE firmware issue, not linux's driver. So with appropriate firmware it should work.
CONFIG_FB=yCONFIG_FB_FOREIGN_ENDIAN=y
^ RDK's framebuffer is little endian.
CONFIG_FB_BOTH_ENDIAN=y
^ also support big-endian framebuffers, e.g. on a PCI
CONFIG_FB_OF=y
^ we use generic driver for the RDK's framebuffer
CONFIG_MTD_CFI_INTELEXT=y
^ to support NOR flash.
CONFIG_MTD_NAND_FSL_UPM=y
^ RDK's device tree doesn't specify nand yet, but as soon as bindings will be approved, I'll post an update to the dts.
CONFIG_PCI=y
^ Without this FB_OF driver doesn't build (will send a fix soon).
Other stuff in the patch was auto selected/updated.
For convenience full list of added =y:
CONFIG_STACKTRACE_SUPPORT=yCONFIG_LOCKDEP_SUPPORT=yCONFIG_GENERIC_GPIO=yCONFIG_SYSCTL_SYSCALL_CHECK=y
CONFIG_MPC836x_RDK=yCONFIG_PAGEFLAGS_EXTENDED=yCONFIG_FSL_LBC=yCONFIG_FSL_GTM=yCONFIG_PCI=yCONFIG_PCI_DOMAINS=yCONFIG_PCI_SYSCALL=yCONFIG_ARCH_SUPPORTS_MSI=yCONFIG_PCI_LEGACY=yCONFIG_FW_LOADER=yCONFIG_MTD_CFI_INTELEXT=yCONFIG_MTD_NAND_FSL_UPM=yCONFIG_OF_GPIO=yCONFIG_OF_I2C=yCONFIG_SERIAL_QE=yCONFIG_DEVPORT=yCONFIG_HAVE_GPIO_LIB=yCONFIG_FB=yCONFIG_FB_CFB_FILLRECT=yCONFIG_FB_CFB_COPYAREA=yCONFIG_FB_CFB_IMAGEBLIT=yCONFIG_FB_FOREIGN_ENDIAN=yCONFIG_FB_BOTH_ENDIAN=yCONFIG_FB_MACMODES=yCONFIG_FB_OF=yCONFIG_USB_ARCH_HAS_OHCI=yCONFIG_UCC_SLOW=yCONFIG_QE_GPIO=y
arch/powerpc/configs/mpc83xx_defconfig | 382 +++++++++++++++++++++++++++----- 1 files changed, 321 insertions(+), 61 deletions(-)
arch/powerpc/configs/mpc83xx_defconfig +321 -61
@@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit -# Linux kernel version: 2.6.25-rc9 -# Tue Apr 15 18:07:36 2008 +# Linux kernel version: 2.6.26-rc5 +# Tue Jun 10 23:19:54 2008 # # CONFIG_PPC64 is not set
@@ -31,11 +31,14 @@ CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_HARDIRQS=y # CONFIG_HAVE_SETUP_PER_CPU_AREA is not set CONFIG_IRQ_PER_CPU=y +CONFIG_STACKTRACE_SUPPORT=y +CONFIG_LOCKDEP_SUPPORT=y CONFIG_RWSEM_XCHGADD_ALGORITHM=y CONFIG_ARCH_HAS_ILOG2_U32=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_FIND_NEXT_BIT=y +CONFIG_GENERIC_GPIO=y # CONFIG_ARCH_NO_VIRT_TO_BUS is not set CONFIG_PPC=y CONFIG_EARLY_PRINTK=y
@@ -86,6 +89,7 @@ CONFIG_INITRAMFS_SOURCE="" CONFIG_SYSCTL=y CONFIG_EMBEDDED=y CONFIG_SYSCTL_SYSCALL=y +CONFIG_SYSCTL_SYSCALL_CHECK=y CONFIG_KALLSYMS=y # CONFIG_KALLSYMS_EXTRA_PASS is not set CONFIG_HOTPLUG=y
@@ -111,12 +115,14 @@ CONFIG_HAVE_OPROFILE=y # CONFIG_KPROBES is not set CONFIG_HAVE_KPROBES=y CONFIG_HAVE_KRETPROBES=y +# CONFIG_HAVE_DMA_ATTRS is not set CONFIG_PROC_PAGE_MONITOR=y CONFIG_SLABINFO=y CONFIG_RT_MUTEXES=y # CONFIG_TINY_SHMEM is not set CONFIG_BASE_SMALL=0 CONFIG_MODULES=y +# CONFIG_MODULE_FORCE_LOAD is not set CONFIG_MODULE_UNLOAD=y # CONFIG_MODULE_FORCE_UNLOAD is not set # CONFIG_MODVERSIONS is not set
@@ -161,9 +167,11 @@ CONFIG_MPC832x_RDB=y CONFIG_MPC834x_MDS=y CONFIG_MPC834x_ITX=y CONFIG_MPC836x_MDS=y +CONFIG_MPC836x_RDK=y CONFIG_MPC837x_MDS=y CONFIG_MPC837x_RDB=y CONFIG_SBC834x=y +# CONFIG_ASP834x is not set CONFIG_PPC_MPC831x=y CONFIG_PPC_MPC832x=y CONFIG_PPC_MPC834x=y
@@ -201,7 +209,6 @@ CONFIG_PREEMPT_NONE=y # CONFIG_PREEMPT is not set CONFIG_BINFMT_ELF=y # CONFIG_BINFMT_MISC is not set -CONFIG_FORCE_MAX_ZONEORDER=11 CONFIG_MATH_EMULATION=y # CONFIG_IOMMU_HELPER is not set CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
@@ -217,11 +224,13 @@ CONFIG_FLATMEM=y CONFIG_FLAT_NODE_MEM_MAP=y # CONFIG_SPARSEMEM_STATIC is not set # CONFIG_SPARSEMEM_VMEMMAP_ENABLE is not set +CONFIG_PAGEFLAGS_EXTENDED=y CONFIG_SPLIT_PTLOCK_CPUS=4 # CONFIG_RESOURCES_64BIT is not set CONFIG_ZONE_DMA_FLAG=1 CONFIG_BOUNCE=y CONFIG_VIRT_TO_BUS=y +CONFIG_FORCE_MAX_ZONEORDER=11 CONFIG_PROC_DEVICETREE=y # CONFIG_CMDLINE_BOOL is not set # CONFIG_PM is not set
@@ -235,11 +244,18 @@ CONFIG_ZONE_DMA=y CONFIG_GENERIC_ISA_DMA=y CONFIG_PPC_INDIRECT_PCI=y CONFIG_FSL_SOC=y -# CONFIG_PCI is not set -# CONFIG_PCI_DOMAINS is not set -# CONFIG_PCI_SYSCALL is not set -# CONFIG_ARCH_SUPPORTS_MSI is not set +CONFIG_FSL_LBC=y +CONFIG_FSL_GTM=y +CONFIG_PCI=y +CONFIG_PCI_DOMAINS=y +CONFIG_PCI_SYSCALL=y +# CONFIG_PCIEPORTBUS is not set +CONFIG_ARCH_SUPPORTS_MSI=y +# CONFIG_PCI_MSI is not set +CONFIG_PCI_LEGACY=y # CONFIG_PCCARD is not set +# CONFIG_HOTPLUG_PCI is not set +# CONFIG_HAS_RAPIDIO is not set # # Advanced setup
@@ -249,11 +265,11 @@ CONFIG_FSL_SOC=y # # Default settings for advanced configuration options are used # -CONFIG_HIGHMEM_START=0xfe000000 CONFIG_LOWMEM_SIZE=0x30000000 +CONFIG_PAGE_OFFSET=0xc0000000 CONFIG_KERNEL_START=0xc0000000 +CONFIG_PHYSICAL_START=0x00000000 CONFIG_TASK_SIZE=0xc0000000 -CONFIG_BOOT_LOAD=0x00800000 # # Networking
@@ -301,8 +317,6 @@ CONFIG_TCP_CONG_CUBIC=y CONFIG_DEFAULT_TCP_CONG="cubic" # CONFIG_TCP_MD5SIG is not set # CONFIG_IPV6 is not set -# CONFIG_INET6_XFRM_TUNNEL is not set -# CONFIG_INET6_TUNNEL is not set # CONFIG_NETWORK_SECMARK is not set # CONFIG_NETFILTER is not set # CONFIG_IP_DCCP is not set
@@ -351,7 +365,7 @@ CONFIG_DEFAULT_TCP_CONG="cubic" CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" CONFIG_STANDALONE=y CONFIG_PREVENT_FIRMWARE_BUILD=y -# CONFIG_FW_LOADER is not set +CONFIG_FW_LOADER=y # CONFIG_SYS_HYPERVISOR is not set # CONFIG_CONNECTOR is not set CONFIG_MTD=y
@@ -361,6 +375,7 @@ CONFIG_MTD_PARTITIONS=y # CONFIG_MTD_REDBOOT_PARTS is not set # CONFIG_MTD_CMDLINE_PARTS is not set CONFIG_MTD_OF_PARTS=y +# CONFIG_MTD_AR7_PARTS is not set # # User Modules And Translation Layers
@@ -392,7 +407,7 @@ CONFIG_MTD_CFI_I1=y CONFIG_MTD_CFI_I2=y # CONFIG_MTD_CFI_I4 is not set # CONFIG_MTD_CFI_I8 is not set -# CONFIG_MTD_CFI_INTELEXT is not set +CONFIG_MTD_CFI_INTELEXT=y CONFIG_MTD_CFI_AMDSTD=y # CONFIG_MTD_CFI_STAA is not set CONFIG_MTD_CFI_UTIL=y
@@ -406,11 +421,13 @@ CONFIG_MTD_CFI_UTIL=y # CONFIG_MTD_COMPLEX_MAPPINGS is not set # CONFIG_MTD_PHYSMAP is not set CONFIG_MTD_PHYSMAP_OF=y +# CONFIG_MTD_INTEL_VR_NOR is not set # CONFIG_MTD_PLATRAM is not set # # Self-contained MTD device drivers # +# CONFIG_MTD_PMC551 is not set # CONFIG_MTD_SLRAM is not set # CONFIG_MTD_PHRAM is not set # CONFIG_MTD_MTDRAM is not set
@@ -428,10 +445,12 @@ CONFIG_MTD_NAND_VERIFY_WRITE=y # CONFIG_MTD_NAND_MUSEUM_IDS is not set CONFIG_MTD_NAND_IDS=y # CONFIG_MTD_NAND_DISKONCHIP is not set +# CONFIG_MTD_NAND_CAFE is not set # CONFIG_MTD_NAND_NANDSIM is not set # CONFIG_MTD_NAND_PLATFORM is not set # CONFIG_MTD_ALAUDA is not set CONFIG_MTD_NAND_FSL_ELBC=y +CONFIG_MTD_NAND_FSL_UPM=y # CONFIG_MTD_ONENAND is not set #
@@ -439,13 +458,20 @@ CONFIG_MTD_NAND_FSL_ELBC=y # # CONFIG_MTD_UBI is not set CONFIG_OF_DEVICE=y +CONFIG_OF_GPIO=y +CONFIG_OF_I2C=y # CONFIG_PARPORT is not set CONFIG_BLK_DEV=y # CONFIG_BLK_DEV_FD is not set +# CONFIG_BLK_CPQ_DA is not set +# CONFIG_BLK_CPQ_CISS_DA is not set +# CONFIG_BLK_DEV_DAC960 is not set +# CONFIG_BLK_DEV_UMEM is not set # CONFIG_BLK_DEV_COW_COMMON is not set CONFIG_BLK_DEV_LOOP=y # CONFIG_BLK_DEV_CRYPTOLOOP is not set # CONFIG_BLK_DEV_NBD is not set +# CONFIG_BLK_DEV_SX8 is not set # CONFIG_BLK_DEV_UB is not set CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_COUNT=16
@@ -454,7 +480,10 @@ CONFIG_BLK_DEV_RAM_SIZE=32768 # CONFIG_CDROM_PKTCDVD is not set # CONFIG_ATA_OVER_ETH is not set CONFIG_MISC_DEVICES=y +# CONFIG_PHANTOM is not set # CONFIG_EEPROM_93CX6 is not set +# CONFIG_SGI_IOC4 is not set +# CONFIG_TIFM_CORE is not set # CONFIG_ENCLOSURE_SERVICES is not set CONFIG_HAVE_IDE=y # CONFIG_IDE is not set
@@ -498,13 +527,58 @@ CONFIG_SCSI_WAIT_SCAN=m # CONFIG_SCSI_SRP_ATTRS is not set CONFIG_SCSI_LOWLEVEL=y # CONFIG_ISCSI_TCP is not set +# CONFIG_BLK_DEV_3W_XXXX_RAID is not set +# CONFIG_SCSI_3W_9XXX is not set +# CONFIG_SCSI_ACARD is not set +# CONFIG_SCSI_AACRAID is not set +# CONFIG_SCSI_AIC7XXX is not set +# CONFIG_SCSI_AIC7XXX_OLD is not set +# CONFIG_SCSI_AIC79XX is not set +# CONFIG_SCSI_AIC94XX is not set +# CONFIG_SCSI_DPT_I2O is not set +# CONFIG_SCSI_ADVANSYS is not set +# CONFIG_SCSI_ARCMSR is not set +# CONFIG_MEGARAID_NEWGEN is not set +# CONFIG_MEGARAID_LEGACY is not set +# CONFIG_MEGARAID_SAS is not set +# CONFIG_SCSI_HPTIOP is not set +# CONFIG_SCSI_BUSLOGIC is not set +# CONFIG_SCSI_DMX3191D is not set +# CONFIG_SCSI_EATA is not set +# CONFIG_SCSI_FUTURE_DOMAIN is not set +# CONFIG_SCSI_GDTH is not set +# CONFIG_SCSI_IPS is not set +# CONFIG_SCSI_INITIO is not set +# CONFIG_SCSI_INIA100 is not set +# CONFIG_SCSI_MVSAS is not set +# CONFIG_SCSI_STEX is not set +# CONFIG_SCSI_SYM53C8XX_2 is not set +# CONFIG_SCSI_IPR is not set +# CONFIG_SCSI_QLOGIC_1280 is not set +# CONFIG_SCSI_QLA_FC is not set +# CONFIG_SCSI_QLA_ISCSI is not set +# CONFIG_SCSI_LPFC is not set +# CONFIG_SCSI_DC395x is not set +# CONFIG_SCSI_DC390T is not set +# CONFIG_SCSI_NSP32 is not set # CONFIG_SCSI_DEBUG is not set +# CONFIG_SCSI_SRP is not set CONFIG_ATA=y # CONFIG_ATA_NONSTANDARD is not set -# CONFIG_SATA_MV is not set +# CONFIG_SATA_PMP is not set +# CONFIG_SATA_AHCI is not set +# CONFIG_SATA_SIL24 is not set CONFIG_SATA_FSL=y -# CONFIG_PATA_PLATFORM is not set +# CONFIG_ATA_SFF is not set # CONFIG_MD is not set +# CONFIG_FUSION is not set + +# +# IEEE 1394 (FireWire) support +# +# CONFIG_FIREWIRE is not set +# CONFIG_IEEE1394 is not set +# CONFIG_I2O is not set # CONFIG_MACINTOSH_DRIVERS is not set CONFIG_NETDEVICES=y # CONFIG_NETDEVICES_MULTIQUEUE is not set
@@ -514,6 +588,7 @@ CONFIG_NETDEVICES=y # CONFIG_EQUALIZER is not set # CONFIG_TUN is not set # CONFIG_VETH is not set +# CONFIG_ARCNET is not set CONFIG_PHYLIB=y #
@@ -533,13 +608,36 @@ CONFIG_ICPLUS_PHY=y # CONFIG_MDIO_BITBANG is not set CONFIG_NET_ETHERNET=y CONFIG_MII=y +# CONFIG_HAPPYMEAL is not set +# CONFIG_SUNGEM is not set +# CONFIG_CASSINI is not set +# CONFIG_NET_VENDOR_3COM is not set +# CONFIG_NET_TULIP is not set +# CONFIG_HP100 is not set # CONFIG_IBM_NEW_EMAC_ZMII is not set # CONFIG_IBM_NEW_EMAC_RGMII is not set # CONFIG_IBM_NEW_EMAC_TAH is not set # CONFIG_IBM_NEW_EMAC_EMAC4 is not set +# CONFIG_NET_PCI is not set # CONFIG_B44 is not set CONFIG_NETDEV_1000=y +# CONFIG_ACENIC is not set +# CONFIG_DL2K is not set +# CONFIG_E1000 is not set +# CONFIG_E1000E is not set # CONFIG_E1000E_ENABLED is not set +# CONFIG_IP1000 is not set +# CONFIG_IGB is not set +# CONFIG_NS83820 is not set +# CONFIG_HAMACHI is not set +# CONFIG_YELLOWFIN is not set +# CONFIG_R8169 is not set +# CONFIG_SIS190 is not set +# CONFIG_SKGE is not set +# CONFIG_SKY2 is not set +# CONFIG_VIA_VELOCITY is not set +# CONFIG_TIGON3 is not set +# CONFIG_BNX2 is not set CONFIG_GIANFAR=y # CONFIG_GFAR_NAPI is not set CONFIG_UCC_GETH=y
@@ -547,13 +645,29 @@ CONFIG_UCC_GETH=y # CONFIG_UGETH_MAGIC_PACKET is not set # CONFIG_UGETH_FILTERING is not set # CONFIG_UGETH_TX_ON_DEMAND is not set +# CONFIG_QLA3XXX is not set +# CONFIG_ATL1 is not set CONFIG_NETDEV_10000=y +# CONFIG_CHELSIO_T1 is not set +# CONFIG_CHELSIO_T3 is not set +# CONFIG_IXGBE is not set +# CONFIG_IXGB is not set +# CONFIG_S2IO is not set +# CONFIG_MYRI10GE is not set +# CONFIG_NETXEN_NIC is not set +# CONFIG_NIU is not set +# CONFIG_MLX4_CORE is not set +# CONFIG_TEHUTI is not set +# CONFIG_BNX2X is not set +# CONFIG_SFC is not set +# CONFIG_TR is not set # # Wireless LAN # # CONFIG_WLAN_PRE80211 is not set # CONFIG_WLAN_80211 is not set +# CONFIG_IWLWIFI_LEDS is not set # # USB Network Adapters
@@ -564,8 +678,11 @@ CONFIG_NETDEV_10000=y # CONFIG_USB_RTL8150 is not set # CONFIG_USB_USBNET is not set # CONFIG_WAN is not set +# CONFIG_FDDI is not set +# CONFIG_HIPPI is not set # CONFIG_PPP is not set # CONFIG_SLIP is not set +# CONFIG_NET_FC is not set # CONFIG_NETCONSOLE is not set # CONFIG_NETPOLL is not set # CONFIG_NET_POLL_CONTROLLER is not set
@@ -607,13 +724,16 @@ CONFIG_INPUT=y # Character devices # # CONFIG_VT is not set +# CONFIG_DEVKMEM is not set # CONFIG_SERIAL_NONSTANDARD is not set +# CONFIG_NOZOMI is not set # # Serial drivers # CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_CONSOLE=y +# CONFIG_SERIAL_8250_PCI is not set CONFIG_SERIAL_8250_NR_UARTS=4 CONFIG_SERIAL_8250_RUNTIME_UARTS=4 # CONFIG_SERIAL_8250_EXTENDED is not set
@@ -624,8 +744,9 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=4 # CONFIG_SERIAL_UARTLITE is not set CONFIG_SERIAL_CORE=y CONFIG_SERIAL_CORE_CONSOLE=y +# CONFIG_SERIAL_JSM is not set # CONFIG_SERIAL_OF_PLATFORM is not set -# CONFIG_SERIAL_QE is not set +CONFIG_SERIAL_QE=y CONFIG_UNIX98_PTYS=y CONFIG_LEGACY_PTYS=y CONFIG_LEGACY_PTY_COUNT=256
@@ -635,29 +756,43 @@ CONFIG_LEGACY_PTY_COUNT=256 CONFIG_GEN_RTC=y # CONFIG_GEN_RTC_X is not set # CONFIG_R3964 is not set +# CONFIG_APPLICOM is not set # CONFIG_RAW_DRIVER is not set # CONFIG_TCG_TPM is not set +CONFIG_DEVPORT=y CONFIG_I2C=y CONFIG_I2C_BOARDINFO=y CONFIG_I2C_CHARDEV=y # -# I2C Algorithms -# -# CONFIG_I2C_ALGOBIT is not set -# CONFIG_I2C_ALGOPCF is not set -# CONFIG_I2C_ALGOPCA is not set - -# # I2C Hardware Bus support # +# CONFIG_I2C_ALI1535 is not set +# CONFIG_I2C_ALI1563 is not set +# CONFIG_I2C_ALI15X3 is not set +# CONFIG_I2C_AMD756 is not set +# CONFIG_I2C_AMD8111 is not set +# CONFIG_I2C_GPIO is not set +# CONFIG_I2C_I801 is not set +# CONFIG_I2C_I810 is not set +# CONFIG_I2C_PIIX4 is not set CONFIG_I2C_MPC=y +# CONFIG_I2C_NFORCE2 is not set # CONFIG_I2C_OCORES is not set # CONFIG_I2C_PARPORT_LIGHT is not set +# CONFIG_I2C_PROSAVAGE is not set +# CONFIG_I2C_SAVAGE4 is not set # CONFIG_I2C_SIMTEC is not set +# CONFIG_I2C_SIS5595 is not set +# CONFIG_I2C_SIS630 is not set +# CONFIG_I2C_SIS96X is not set # CONFIG_I2C_TAOS_EVM is not set # CONFIG_I2C_STUB is not set # CONFIG_I2C_TINY_USB is not set +# CONFIG_I2C_VIA is not set +# CONFIG_I2C_VIAPRO is not set +# CONFIG_I2C_VOODOO3 is not set +# CONFIG_I2C_PCA_PLATFORM is not set # # Miscellaneous I2C Chip support
@@ -674,12 +809,22 @@ CONFIG_I2C_MPC=y # CONFIG_I2C_DEBUG_ALGO is not set # CONFIG_I2C_DEBUG_BUS is not set # CONFIG_I2C_DEBUG_CHIP is not set +# CONFIG_SPI is not set +CONFIG_HAVE_GPIO_LIB=y # -# SPI support +# GPIO Support +# + +# +# I2C GPIO expanders: +# +# CONFIG_GPIO_PCA953X is not set +# CONFIG_GPIO_PCF857X is not set + +# +# SPI GPIO expanders: # -# CONFIG_SPI is not set -# CONFIG_SPI_MASTER is not set # CONFIG_W1 is not set # CONFIG_POWER_SUPPLY is not set CONFIG_HWMON=y
@@ -695,6 +840,7 @@ CONFIG_HWMON=y # CONFIG_SENSORS_ADT7473 is not set # CONFIG_SENSORS_ATXP1 is not set # CONFIG_SENSORS_DS1621 is not set +# CONFIG_SENSORS_I5K_AMB is not set # CONFIG_SENSORS_F71805F is not set # CONFIG_SENSORS_F71882FG is not set # CONFIG_SENSORS_F75375S is not set
@@ -716,13 +862,16 @@ CONFIG_HWMON=y # CONFIG_SENSORS_MAX6650 is not set # CONFIG_SENSORS_PC87360 is not set # CONFIG_SENSORS_PC87427 is not set +# CONFIG_SENSORS_SIS5595 is not set # CONFIG_SENSORS_DME1737 is not set # CONFIG_SENSORS_SMSC47M1 is not set # CONFIG_SENSORS_SMSC47M192 is not set # CONFIG_SENSORS_SMSC47B397 is not set # CONFIG_SENSORS_ADS7828 is not set # CONFIG_SENSORS_THMC50 is not set +# CONFIG_SENSORS_VIA686A is not set # CONFIG_SENSORS_VT1211 is not set +# CONFIG_SENSORS_VT8231 is not set # CONFIG_SENSORS_W83781D is not set # CONFIG_SENSORS_W83791D is not set # CONFIG_SENSORS_W83792D is not set
@@ -743,6 +892,12 @@ CONFIG_WATCHDOG=y CONFIG_83xx_WDT=y # +# PCI-based Watchdog Cards +# +# CONFIG_PCIPCWATCHDOG is not set +# CONFIG_WDTPCI is not set + +# # USB-based Watchdog Cards # # CONFIG_USBPCWATCHDOG is not set
@@ -757,27 +912,92 @@ CONFIG_SSB_POSSIBLE=y # Multifunction device drivers # # CONFIG_MFD_SM501 is not set +# CONFIG_HTC_PASIC3 is not set # # Multimedia devices # + +# +# Multimedia core support +# # CONFIG_VIDEO_DEV is not set # CONFIG_DVB_CORE is not set +# CONFIG_VIDEO_MEDIA is not set + +# +# Multimedia drivers +# CONFIG_DAB=y # CONFIG_USB_DABUSB is not set # # Graphics support # +# CONFIG_AGP is not set +# CONFIG_DRM is not set # CONFIG_VGASTATE is not set CONFIG_VIDEO_OUTPUT_CONTROL=m -# CONFIG_FB is not set +CONFIG_FB=y +# CONFIG_FIRMWARE_EDID is not set +# CONFIG_FB_DDC is not set +CONFIG_FB_CFB_FILLRECT=y +CONFIG_FB_CFB_COPYAREA=y +CONFIG_FB_CFB_IMAGEBLIT=y +# CONFIG_FB_CFB_REV_PIXELS_IN_BYTE is not set +# CONFIG_FB_SYS_FILLRECT is not set +# CONFIG_FB_SYS_COPYAREA is not set +# CONFIG_FB_SYS_IMAGEBLIT is not set +CONFIG_FB_FOREIGN_ENDIAN=y +CONFIG_FB_BOTH_ENDIAN=y +# CONFIG_FB_BIG_ENDIAN is not set +# CONFIG_FB_LITTLE_ENDIAN is not set +# CONFIG_FB_SYS_FOPS is not set +# CONFIG_FB_SVGALIB is not set +CONFIG_FB_MACMODES=y +# CONFIG_FB_BACKLIGHT is not set +# CONFIG_FB_MODE_HELPERS is not set +# CONFIG_FB_TILEBLITTING is not set + +# +# Frame buffer hardware drivers +# +# CONFIG_FB_CIRRUS is not set +# CONFIG_FB_PM2 is not set +# CONFIG_FB_CYBER2000 is not set +CONFIG_FB_OF=y +# CONFIG_FB_CT65550 is not set +# CONFIG_FB_ASILIANT is not set +# CONFIG_FB_IMSTT is not set +# CONFIG_FB_VGA16 is not set +# CONFIG_FB_S1D13XXX is not set +# CONFIG_FB_NVIDIA is not set +# CONFIG_FB_RIVA is not set +# CONFIG_FB_MATROX is not set +# CONFIG_FB_RADEON is not set +# CONFIG_FB_ATY128 is not set +# CONFIG_FB_ATY is not set +# CONFIG_FB_S3 is not set +# CONFIG_FB_SAVAGE is not set +# CONFIG_FB_SIS is not set +# CONFIG_FB_NEOMAGIC is not set +# CONFIG_FB_KYRO is not set +# CONFIG_FB_3DFX is not set +# CONFIG_FB_VOODOO1 is not set +# CONFIG_FB_VT8623 is not set +# CONFIG_FB_TRIDENT is not set +# CONFIG_FB_ARK is not set +# CONFIG_FB_PM3 is not set +# CONFIG_FB_FSL_DIU is not set +# CONFIG_FB_IBM_GXT4500 is not set +# CONFIG_FB_VIRTUAL is not set # CONFIG_BACKLIGHT_LCD_SUPPORT is not set # # Display device support # # CONFIG_DISPLAY_SUPPORT is not set +# CONFIG_LOGO is not set # # Sound
@@ -797,7 +1017,7 @@ CONFIG_USB_HID=y # CONFIG_USB_HIDDEV is not set CONFIG_USB_SUPPORT=y CONFIG_USB_ARCH_HAS_HCD=y -# CONFIG_USB_ARCH_HAS_OHCI is not set +CONFIG_USB_ARCH_HAS_OHCI=y CONFIG_USB_ARCH_HAS_EHCI=y CONFIG_USB=y # CONFIG_USB_DEBUG is not set
@@ -810,16 +1030,22 @@ CONFIG_USB=y CONFIG_USB_DEVICE_CLASS=y # CONFIG_USB_DYNAMIC_MINORS is not set # CONFIG_USB_OTG is not set +# CONFIG_USB_OTG_WHITELIST is not set +# CONFIG_USB_OTG_BLACKLIST_HUB is not set # # USB Host Controller Drivers # +# CONFIG_USB_C67X00_HCD is not set CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI_ROOT_HUB_TT=y # CONFIG_USB_EHCI_TT_NEWSCHED is not set CONFIG_USB_EHCI_FSL=y CONFIG_USB_EHCI_HCD_PPC_OF=y # CONFIG_USB_ISP116X_HCD is not set +# CONFIG_USB_ISP1760_HCD is not set +# CONFIG_USB_OHCI_HCD is not set +# CONFIG_USB_UHCI_HCD is not set # CONFIG_USB_SL811_HCD is not set # CONFIG_USB_R8A66597_HCD is not set
@@ -828,6 +1054,7 @@ CONFIG_USB_EHCI_HCD_PPC_OF=y # # CONFIG_USB_ACM is not set # CONFIG_USB_PRINTER is not set +# CONFIG_USB_WDM is not set # # NOTE: USB_STORAGE enables SCSI, and 'SCSI disk support'
@@ -873,17 +1100,16 @@ CONFIG_USB_MON=y # CONFIG_USB_LD is not set # CONFIG_USB_TRANCEVIBRATOR is not set # CONFIG_USB_IOWARRIOR is not set +# CONFIG_USB_ISIGHTFW is not set # CONFIG_USB_GADGET is not set # CONFIG_MMC is not set # CONFIG_MEMSTICK is not set # CONFIG_NEW_LEDS is not set +# CONFIG_ACCESSIBILITY is not set +# CONFIG_INFINIBAND is not set # CONFIG_EDAC is not set # CONFIG_RTC_CLASS is not set # CONFIG_DMADEVICES is not set - -# -# Userspace I/O -# # CONFIG_UIO is not set #
@@ -903,7 +1129,6 @@ CONFIG_FS_MBCACHE=y # CONFIG_JFS_FS is not set # CONFIG_FS_POSIX_ACL is not set # CONFIG_XFS_FS is not set -# CONFIG_GFS2_FS is not set # CONFIG_OCFS2_FS is not set CONFIG_DNOTIFY=y CONFIG_INOTIFY=y
@@ -962,7 +1187,6 @@ CONFIG_NFS_FS=y CONFIG_NFS_V3=y # CONFIG_NFS_V3_ACL is not set CONFIG_NFS_V4=y -# CONFIG_NFS_DIRECTIO is not set # CONFIG_NFSD is not set CONFIG_ROOT_NFS=y CONFIG_LOCKD=y
@@ -1002,13 +1226,16 @@ CONFIG_MSDOS_PARTITION=y # CONFIG_SYSV68_PARTITION is not set # CONFIG_NLS is not set # CONFIG_DLM is not set +CONFIG_UCC_SLOW=y CONFIG_UCC_FAST=y CONFIG_UCC=y +CONFIG_QE_GPIO=y # # Library routines # CONFIG_BITREVERSE=y +# CONFIG_GENERIC_FIND_FIRST_BIT is not set # CONFIG_CRC_CCITT is not set # CONFIG_CRC16 is not set # CONFIG_CRC_ITU_T is not set
@@ -1027,6 +1254,7 @@ CONFIG_HAVE_LMB=y # CONFIG_PRINTK_TIME is not set CONFIG_ENABLE_WARN_DEPRECATED=y CONFIG_ENABLE_MUST_CHECK=y +CONFIG_FRAME_WARN=1024 # CONFIG_MAGIC_SYSRQ is not set # CONFIG_UNUSED_SYMBOLS is not set # CONFIG_DEBUG_FS is not set
@@ -1034,6 +1262,7 @@ CONFIG_ENABLE_MUST_CHECK=y # CONFIG_DEBUG_KERNEL is not set # CONFIG_DEBUG_BUGVERBOSE is not set # CONFIG_SAMPLES is not set +# CONFIG_IRQSTACKS is not set # CONFIG_PPC_EARLY_DEBUG is not set #
@@ -1043,51 +1272,82 @@ CONFIG_ENABLE_MUST_CHECK=y # CONFIG_SECURITY is not set # CONFIG_SECURITY_FILE_CAPABILITIES is not set CONFIG_CRYPTO=y + +# +# Crypto core or helper +# CONFIG_CRYPTO_ALGAPI=y CONFIG_CRYPTO_BLKCIPHER=y -# CONFIG_CRYPTO_SEQIV is not set CONFIG_CRYPTO_MANAGER=y +# CONFIG_CRYPTO_GF128MUL is not set +# CONFIG_CRYPTO_NULL is not set +# CONFIG_CRYPTO_CRYPTD is not set +# CONFIG_CRYPTO_AUTHENC is not set +# CONFIG_CRYPTO_TEST is not set + +# +# Authenticated Encryption with Associated Data +# +# CONFIG_CRYPTO_CCM is not set +# CONFIG_CRYPTO_GCM is not set +# CONFIG_CRYPTO_SEQIV is not set + +# +# Block modes +# +CONFIG_CRYPTO_CBC=y +# CONFIG_CRYPTO_CTR is not set +# CONFIG_CRYPTO_CTS is not set +# CONFIG_CRYPTO_ECB is not set +# CONFIG_CRYPTO_LRW is not set +# CONFIG_CRYPTO_PCBC is not set +# CONFIG_CRYPTO_XTS is not set + +# +# Hash modes +# # CONFIG_CRYPTO_HMAC is not set # CONFIG_CRYPTO_XCBC is not set -# CONFIG_CRYPTO_NULL is not set + +# +# Digest +# +# CONFIG_CRYPTO_CRC32C is not set # CONFIG_CRYPTO_MD4 is not set CONFIG_CRYPTO_MD5=y +# CONFIG_CRYPTO_MICHAEL_MIC is not set # CONFIG_CRYPTO_SHA1 is not set # CONFIG_CRYPTO_SHA256 is not set # CONFIG_CRYPTO_SHA512 is not set -# CONFIG_CRYPTO_WP512 is not set # CONFIG_CRYPTO_TGR192 is not set -# CONFIG_CRYPTO_GF128MUL is not set -CONFIG_CRYPTO_ECB=m -CONFIG_CRYPTO_CBC=y -CONFIG_CRYPTO_PCBC=m -# CONFIG_CRYPTO_LRW is not set -# CONFIG_CRYPTO_XTS is not set -# CONFIG_CRYPTO_CTR is not set -# CONFIG_CRYPTO_GCM is not set -# CONFIG_CRYPTO_CCM is not set -# CONFIG_CRYPTO_CRYPTD is not set -CONFIG_CRYPTO_DES=y -# CONFIG_CRYPTO_FCRYPT is not set -# CONFIG_CRYPTO_BLOWFISH is not set -# CONFIG_CRYPTO_TWOFISH is not set -# CONFIG_CRYPTO_SERPENT is not set +# CONFIG_CRYPTO_WP512 is not set + +# +# Ciphers +# # CONFIG_CRYPTO_AES is not set +# CONFIG_CRYPTO_ANUBIS is not set +# CONFIG_CRYPTO_ARC4 is not set +# CONFIG_CRYPTO_BLOWFISH is not set +# CONFIG_CRYPTO_CAMELLIA is not set # CONFIG_CRYPTO_CAST5 is not set # CONFIG_CRYPTO_CAST6 is not set -# CONFIG_CRYPTO_TEA is not set -# CONFIG_CRYPTO_ARC4 is not set +CONFIG_CRYPTO_DES=y +# CONFIG_CRYPTO_FCRYPT is not set # CONFIG_CRYPTO_KHAZAD is not set -# CONFIG_CRYPTO_ANUBIS is not set -# CONFIG_CRYPTO_SEED is not set # CONFIG_CRYPTO_SALSA20 is not set +# CONFIG_CRYPTO_SEED is not set +# CONFIG_CRYPTO_SERPENT is not set +# CONFIG_CRYPTO_TEA is not set +# CONFIG_CRYPTO_TWOFISH is not set + +# +# Compression +# # CONFIG_CRYPTO_DEFLATE is not set -# CONFIG_CRYPTO_MICHAEL_MIC is not set -# CONFIG_CRYPTO_CRC32C is not set -# CONFIG_CRYPTO_CAMELLIA is not set -# CONFIG_CRYPTO_TEST is not set -# CONFIG_CRYPTO_AUTHENC is not set # CONFIG_CRYPTO_LZO is not set CONFIG_CRYPTO_HW=y +# CONFIG_CRYPTO_DEV_HIFN_795X is not set # CONFIG_PPC_CLOCK is not set CONFIG_PPC_LIB_RHEAP=y +# CONFIG_VIRTUALIZATION is not set
Signature · 1 line
1.5.5.4
Re: [PATCH] powerpc: 83xx: update mpc83xx_defconfig to support MPC8360E-RDK
Quoted 11 lines · Anton Vorontsov
This patch updates
mpc83xx_defconfigto support MPC8360E-RDK board.Signed-off-by Anton Vorontsov <[email protected]>---
On Tue, Jun 10, 2008 at 10:55:39AM -0500, Kumar Gala wrote:
[...]Quoted 3 lines
Can you do me a favor and update
mpc83xx_defconfigand make sure that boots and provide that in a separate patch. I want to start making sure we have whatever features boards need enabled in thempc83xx_defconfig.
Quoted 8 lines
Done. This is on top of your current powerpc-next branch (HEAD at
917f0af9e5a9ce) + applied patches (seems like you forgot to push out the tree).Thus
mpc83xx_defconfigwasn't updated for a long time, so the patch isn't readable.Here is what I enabled manually:
Can you look at refreshing this against my for-2.6.26 tree (its got an updated defconfig)
Or update the mpc83xx_defconfig and than enable what you needed and provide a patch of just the things being enabled.
- k
PATCH v2 1/1 powerpc/83xx: update mpc83xx_defconfig to support MPC8360E-RDK
This patch updates mpc83xx_defconfig to support MPC8360E-RDK board.
---
On Tue, Jun 10, 2008 at 05:01:17PM -0500, Kumar Gala wrote:
[...]
Quoted 2 lines
Can you look at refreshing this against my for-2.6.26 tree (its got an updated defconfig)
That's an idea. Cherry-picked the defconfig update commit, and here is the patch on top.
I'm assuming that CONFIG_PCI=n + CONFIG_FB_OF build breakage fix will be committed prior to this patch. If not, we'll have to enable the CONFIG_PCI in the defconfig as a separate patch, since it will produce unreadable changes again. (btw, is there any particular reason why PCI is disabled?)
arch/powerpc/configs/mpc83xx_defconfig | 65 +++++++++++++++++++++++++++++-- 1 files changed, 60 insertions(+), 5 deletions(-)
arch/powerpc/configs/mpc83xx_defconfig +60 -5
@@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit # Linux kernel version: 2.6.26-rc5 -# Mon Jun 9 08:52:14 2008 +# Wed Jun 11 02:59:37 2008 # # CONFIG_PPC64 is not set
@@ -38,6 +38,7 @@ CONFIG_ARCH_HAS_ILOG2_U32=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_FIND_NEXT_BIT=y +CONFIG_GENERIC_GPIO=y # CONFIG_ARCH_NO_VIRT_TO_BUS is not set CONFIG_PPC=y CONFIG_EARLY_PRINTK=y
@@ -166,6 +167,7 @@ CONFIG_MPC832x_RDB=y CONFIG_MPC834x_MDS=y CONFIG_MPC834x_ITX=y CONFIG_MPC836x_MDS=y +CONFIG_MPC836x_RDK=y CONFIG_MPC837x_MDS=y CONFIG_MPC837x_RDB=y CONFIG_SBC834x=y
@@ -241,6 +243,8 @@ CONFIG_ZONE_DMA=y CONFIG_GENERIC_ISA_DMA=y CONFIG_PPC_INDIRECT_PCI=y CONFIG_FSL_SOC=y +CONFIG_FSL_LBC=y +CONFIG_FSL_GTM=y # CONFIG_PCI is not set # CONFIG_PCI_DOMAINS is not set # CONFIG_PCI_SYSCALL is not set
@@ -356,7 +360,7 @@ CONFIG_DEFAULT_TCP_CONG="cubic" CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" CONFIG_STANDALONE=y CONFIG_PREVENT_FIRMWARE_BUILD=y -# CONFIG_FW_LOADER is not set +CONFIG_FW_LOADER=y # CONFIG_SYS_HYPERVISOR is not set # CONFIG_CONNECTOR is not set CONFIG_MTD=y
@@ -398,7 +402,7 @@ CONFIG_MTD_CFI_I1=y CONFIG_MTD_CFI_I2=y # CONFIG_MTD_CFI_I4 is not set # CONFIG_MTD_CFI_I8 is not set -# CONFIG_MTD_CFI_INTELEXT is not set +CONFIG_MTD_CFI_INTELEXT=y CONFIG_MTD_CFI_AMDSTD=y # CONFIG_MTD_CFI_STAA is not set CONFIG_MTD_CFI_UTIL=y
@@ -438,6 +442,7 @@ CONFIG_MTD_NAND_IDS=y # CONFIG_MTD_NAND_PLATFORM is not set # CONFIG_MTD_ALAUDA is not set CONFIG_MTD_NAND_FSL_ELBC=y +CONFIG_MTD_NAND_FSL_UPM=y # CONFIG_MTD_ONENAND is not set #
@@ -445,6 +450,7 @@ CONFIG_MTD_NAND_FSL_ELBC=y # # CONFIG_MTD_UBI is not set CONFIG_OF_DEVICE=y +CONFIG_OF_GPIO=y CONFIG_OF_I2C=y # CONFIG_PARPORT is not set CONFIG_BLK_DEV=y
@@ -636,7 +642,7 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=4 CONFIG_SERIAL_CORE=y CONFIG_SERIAL_CORE_CONSOLE=y # CONFIG_SERIAL_OF_PLATFORM is not set -# CONFIG_SERIAL_QE is not set +CONFIG_SERIAL_QE=y CONFIG_UNIX98_PTYS=y CONFIG_LEGACY_PTYS=y CONFIG_LEGACY_PTY_COUNT=256
@@ -655,6 +661,7 @@ CONFIG_I2C_CHARDEV=y # # I2C Hardware Bus support # +# CONFIG_I2C_GPIO is not set CONFIG_I2C_MPC=y # CONFIG_I2C_OCORES is not set # CONFIG_I2C_PARPORT_LIGHT is not set
@@ -672,6 +679,7 @@ CONFIG_I2C_MPC=y # CONFIG_SENSORS_PCF8574 is not set # CONFIG_PCF8575 is not set # CONFIG_SENSORS_PCF8591 is not set +# CONFIG_TPS65010 is not set # CONFIG_SENSORS_MAX6875 is not set # CONFIG_SENSORS_TSL2550 is not set # CONFIG_I2C_DEBUG_CORE is not set
@@ -679,6 +687,21 @@ CONFIG_I2C_MPC=y # CONFIG_I2C_DEBUG_BUS is not set # CONFIG_I2C_DEBUG_CHIP is not set # CONFIG_SPI is not set +CONFIG_HAVE_GPIO_LIB=y + +# +# GPIO Support +# + +# +# I2C GPIO expanders: +# +# CONFIG_GPIO_PCA953X is not set +# CONFIG_GPIO_PCF857X is not set + +# +# SPI GPIO expanders: +# # CONFIG_W1 is not set # CONFIG_POWER_SUPPLY is not set CONFIG_HWMON=y
@@ -780,13 +803,43 @@ CONFIG_DAB=y # # CONFIG_VGASTATE is not set CONFIG_VIDEO_OUTPUT_CONTROL=m -# CONFIG_FB is not set +CONFIG_FB=y +# CONFIG_FIRMWARE_EDID is not set +# CONFIG_FB_DDC is not set +CONFIG_FB_CFB_FILLRECT=y +CONFIG_FB_CFB_COPYAREA=y +CONFIG_FB_CFB_IMAGEBLIT=y +# CONFIG_FB_CFB_REV_PIXELS_IN_BYTE is not set +# CONFIG_FB_SYS_FILLRECT is not set +# CONFIG_FB_SYS_COPYAREA is not set +# CONFIG_FB_SYS_IMAGEBLIT is not set +CONFIG_FB_FOREIGN_ENDIAN=y +CONFIG_FB_BOTH_ENDIAN=y +# CONFIG_FB_BIG_ENDIAN is not set +# CONFIG_FB_LITTLE_ENDIAN is not set +# CONFIG_FB_SYS_FOPS is not set +# CONFIG_FB_SVGALIB is not set +CONFIG_FB_MACMODES=y +# CONFIG_FB_BACKLIGHT is not set +# CONFIG_FB_MODE_HELPERS is not set +# CONFIG_FB_TILEBLITTING is not set + +# +# Frame buffer hardware drivers +# +CONFIG_FB_OF=y +# CONFIG_FB_VGA16 is not set +# CONFIG_FB_S1D13XXX is not set +# CONFIG_FB_FSL_DIU is not set +# CONFIG_FB_IBM_GXT4500 is not set +# CONFIG_FB_VIRTUAL is not set # CONFIG_BACKLIGHT_LCD_SUPPORT is not set # # Display device support # # CONFIG_DISPLAY_SUPPORT is not set +# CONFIG_LOGO is not set # # Sound
@@ -1012,8 +1065,10 @@ CONFIG_MSDOS_PARTITION=y # CONFIG_SYSV68_PARTITION is not set # CONFIG_NLS is not set # CONFIG_DLM is not set +CONFIG_UCC_SLOW=y CONFIG_UCC_FAST=y CONFIG_UCC=y +CONFIG_QE_GPIO=y # # Library routines
Signature · 1 line
1.5.5.4
PATCH v3 1/1 powerpc/83xx: update mpc83xx_defconfig to support MPC8360E-RDK
This patch updates mpc83xx_defconfig to support MPC8360E-RDK board.
---
Completely forgot about BROADCOM_PHY, added now. Without it, only u-boot initialized BCM PHY will work, second one will unable to receive/transmit any data.
arch/powerpc/configs/mpc83xx_defconfig | 67 +++++++++++++++++++++++++++++--- 1 files changed, 61 insertions(+), 6 deletions(-)
arch/powerpc/configs/mpc83xx_defconfig +61 -6
@@ -1,7 +1,7 @@ # # Automatically generated make config: don't edit # Linux kernel version: 2.6.26-rc5 -# Mon Jun 9 08:52:14 2008 +# Wed Jun 11 15:35:09 2008 # # CONFIG_PPC64 is not set
@@ -38,6 +38,7 @@ CONFIG_ARCH_HAS_ILOG2_U32=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_FIND_NEXT_BIT=y +CONFIG_GENERIC_GPIO=y # CONFIG_ARCH_NO_VIRT_TO_BUS is not set CONFIG_PPC=y CONFIG_EARLY_PRINTK=y
@@ -166,6 +167,7 @@ CONFIG_MPC832x_RDB=y CONFIG_MPC834x_MDS=y CONFIG_MPC834x_ITX=y CONFIG_MPC836x_MDS=y +CONFIG_MPC836x_RDK=y CONFIG_MPC837x_MDS=y CONFIG_MPC837x_RDB=y CONFIG_SBC834x=y
@@ -241,6 +243,8 @@ CONFIG_ZONE_DMA=y CONFIG_GENERIC_ISA_DMA=y CONFIG_PPC_INDIRECT_PCI=y CONFIG_FSL_SOC=y +CONFIG_FSL_LBC=y +CONFIG_FSL_GTM=y # CONFIG_PCI is not set # CONFIG_PCI_DOMAINS is not set # CONFIG_PCI_SYSCALL is not set
@@ -356,7 +360,7 @@ CONFIG_DEFAULT_TCP_CONG="cubic" CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" CONFIG_STANDALONE=y CONFIG_PREVENT_FIRMWARE_BUILD=y -# CONFIG_FW_LOADER is not set +CONFIG_FW_LOADER=y # CONFIG_SYS_HYPERVISOR is not set # CONFIG_CONNECTOR is not set CONFIG_MTD=y
@@ -398,7 +402,7 @@ CONFIG_MTD_CFI_I1=y CONFIG_MTD_CFI_I2=y # CONFIG_MTD_CFI_I4 is not set # CONFIG_MTD_CFI_I8 is not set -# CONFIG_MTD_CFI_INTELEXT is not set +CONFIG_MTD_CFI_INTELEXT=y CONFIG_MTD_CFI_AMDSTD=y # CONFIG_MTD_CFI_STAA is not set CONFIG_MTD_CFI_UTIL=y
@@ -438,6 +442,7 @@ CONFIG_MTD_NAND_IDS=y # CONFIG_MTD_NAND_PLATFORM is not set # CONFIG_MTD_ALAUDA is not set CONFIG_MTD_NAND_FSL_ELBC=y +CONFIG_MTD_NAND_FSL_UPM=y # CONFIG_MTD_ONENAND is not set #
@@ -445,6 +450,7 @@ CONFIG_MTD_NAND_FSL_ELBC=y # # CONFIG_MTD_UBI is not set CONFIG_OF_DEVICE=y +CONFIG_OF_GPIO=y CONFIG_OF_I2C=y # CONFIG_PARPORT is not set CONFIG_BLK_DEV=y
@@ -535,7 +541,7 @@ CONFIG_DAVICOM_PHY=y # CONFIG_CICADA_PHY is not set CONFIG_VITESSE_PHY=y # CONFIG_SMSC_PHY is not set -# CONFIG_BROADCOM_PHY is not set +CONFIG_BROADCOM_PHY=y CONFIG_ICPLUS_PHY=y # CONFIG_REALTEK_PHY is not set # CONFIG_FIXED_PHY is not set
@@ -636,7 +642,7 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=4 CONFIG_SERIAL_CORE=y CONFIG_SERIAL_CORE_CONSOLE=y # CONFIG_SERIAL_OF_PLATFORM is not set -# CONFIG_SERIAL_QE is not set +CONFIG_SERIAL_QE=y CONFIG_UNIX98_PTYS=y CONFIG_LEGACY_PTYS=y CONFIG_LEGACY_PTY_COUNT=256
@@ -655,6 +661,7 @@ CONFIG_I2C_CHARDEV=y # # I2C Hardware Bus support # +# CONFIG_I2C_GPIO is not set CONFIG_I2C_MPC=y # CONFIG_I2C_OCORES is not set # CONFIG_I2C_PARPORT_LIGHT is not set
@@ -672,6 +679,7 @@ CONFIG_I2C_MPC=y # CONFIG_SENSORS_PCF8574 is not set # CONFIG_PCF8575 is not set # CONFIG_SENSORS_PCF8591 is not set +# CONFIG_TPS65010 is not set # CONFIG_SENSORS_MAX6875 is not set # CONFIG_SENSORS_TSL2550 is not set # CONFIG_I2C_DEBUG_CORE is not set
@@ -679,6 +687,21 @@ CONFIG_I2C_MPC=y # CONFIG_I2C_DEBUG_BUS is not set # CONFIG_I2C_DEBUG_CHIP is not set # CONFIG_SPI is not set +CONFIG_HAVE_GPIO_LIB=y + +# +# GPIO Support +# + +# +# I2C GPIO expanders: +# +# CONFIG_GPIO_PCA953X is not set +# CONFIG_GPIO_PCF857X is not set + +# +# SPI GPIO expanders: +# # CONFIG_W1 is not set # CONFIG_POWER_SUPPLY is not set CONFIG_HWMON=y
@@ -780,13 +803,43 @@ CONFIG_DAB=y # # CONFIG_VGASTATE is not set CONFIG_VIDEO_OUTPUT_CONTROL=m -# CONFIG_FB is not set +CONFIG_FB=y +# CONFIG_FIRMWARE_EDID is not set +# CONFIG_FB_DDC is not set +CONFIG_FB_CFB_FILLRECT=y +CONFIG_FB_CFB_COPYAREA=y +CONFIG_FB_CFB_IMAGEBLIT=y +# CONFIG_FB_CFB_REV_PIXELS_IN_BYTE is not set +# CONFIG_FB_SYS_FILLRECT is not set +# CONFIG_FB_SYS_COPYAREA is not set +# CONFIG_FB_SYS_IMAGEBLIT is not set +CONFIG_FB_FOREIGN_ENDIAN=y +CONFIG_FB_BOTH_ENDIAN=y +# CONFIG_FB_BIG_ENDIAN is not set +# CONFIG_FB_LITTLE_ENDIAN is not set +# CONFIG_FB_SYS_FOPS is not set +# CONFIG_FB_SVGALIB is not set +CONFIG_FB_MACMODES=y +# CONFIG_FB_BACKLIGHT is not set +# CONFIG_FB_MODE_HELPERS is not set +# CONFIG_FB_TILEBLITTING is not set + +# +# Frame buffer hardware drivers +# +CONFIG_FB_OF=y +# CONFIG_FB_VGA16 is not set +# CONFIG_FB_S1D13XXX is not set +# CONFIG_FB_FSL_DIU is not set +# CONFIG_FB_IBM_GXT4500 is not set +# CONFIG_FB_VIRTUAL is not set # CONFIG_BACKLIGHT_LCD_SUPPORT is not set # # Display device support # # CONFIG_DISPLAY_SUPPORT is not set +# CONFIG_LOGO is not set # # Sound
@@ -1012,8 +1065,10 @@ CONFIG_MSDOS_PARTITION=y # CONFIG_SYSV68_PARTITION is not set # CONFIG_NLS is not set # CONFIG_DLM is not set +CONFIG_UCC_SLOW=y CONFIG_UCC_FAST=y CONFIG_UCC=y +CONFIG_QE_GPIO=y # # Library routines
Signature · 1 line
1.5.5.4
PATCH v4 6/6 booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings
In reply to Anton VorontsovThis patch adds few bindings for the new drivers to be submitted through appropriate maintainers.
--- Documentation/powerpc/booting-without-of.txt | 125 ++++++++++++++++++++++++++ 1 files changed, 125 insertions(+), 0 deletions(-)
Documentation/powerpc/booting-without-of.txt +125 -0
@@ -61,6 +61,10 @@ Table of Contents r) Freescale Display Interface Unit s) Freescale on board FPGA t) Freescale General-purpose Timers Module + u) Freescale QUICC Engine USB Controller + v) LEDs on GPIOs + w) Freescale MCU with MPC8349E-mITX compatible firmware + x) Freescale Localbus UPM programmed to work with NAND flash VII - Marvell Discovery mv64[345]6x System Controller chips 1) The /system-controller node
@@ -2916,6 +2920,127 @@ platforms are moved over to use the flattened-device-tree model. clock-frequency = <0>; }; + u) Freescale QUICC Engine USB Controller + + Required properties: + - compatible : should be "fsl,<chip>-qe-usb", "fsl,mpc8323-qe-usb"; + - reg : the first two cells should contain gtm registers location and + length, the next two two cells should contain PRAM location and + length. + - interrupts : should contain USB interrupt. + - interrupt-parent : interrupt source phandle. + - fsl,fullspeed-clock : specifies the full speed USB clock source in + "clk<num>" or "brg<num>" format. + - fsl,lowspeed-clock : specifies the low speed USB clock source in + "clk<num>" or "brg<num>" format. + - fsl,usb-mode : should be "host". + - linux,hub-power-budget : optional, USB power budget for the root hub + in mA. + - gpios : should specify GPIOs in this order: USBOE, USBTP, USBTN, USBRP, + USBRN, SPEED (optional), and POWER (optional). + + Example: + + usb@6c0 { + compatible = "fsl,mpc8360-qe-usb", "fsl,mpc8323-qe-usb"; + reg = <0x6c0 0x40 0x8b00 0x100>; + interrupts = <11>; + interrupt-parent = <&qeic>; + fsl,fullspeed-clock = "clk21"; + fsl,usb-mode = "host"; + gpios = <&qe_pio_b 2 0 /* USBOE */ + &qe_pio_b 3 0 /* USBTP */ + &qe_pio_b 8 0 /* USBTN */ + &qe_pio_b 9 0 /* USBRP */ + &qe_pio_b 11 0 /* USBRN */ + &qe_pio_e 20 0 /* SPEED */ + &qe_pio_e 21 0 /* POWER */>; + }; + + v) LEDs on GPIOs + + Required properties: + - compatible : should be "linux,gpio-led". + - linux,name : LED name. + - linux,active-low : property should be present if LED wired as + active-low. + - linux,default-trigger : Linux default trigger for this LED. + - linux,brightness : default brightness. + - gpios : should specify LED GPIO. + + Example: + + led@0 { + compatible = "linux,gpio-led"; + linux,name = "pwr"; + linux,brightness = <1>; + linux,active-low; + gpios = <&mcu_pio 0>; + }; + + led@1 { + compatible = "linux,gpio-led"; + linux,name = "hdd"; + linux,default-trigger = "ide-disk"; + linux,active-low; + gpios = <&mcu_pio 1>; + }; + + w) Freescale MCU with MPC8349E-mITX compatible firmware + + Required properties: + - compatible : "fsl,<mcu-chip>-<board>", "fsl,mcu-mpc8349emitx"; + - reg : should specify I2C address (0x0a). + - #address-cells : should be 0. + - #size-cells : should be 0. + - #gpio-cells : should be 2. + - gpio-controller : should be present; + + Example: + + mcu_pio: mcu@0a { + #address-cells = <0>; + #size-cells = <0>; + #gpio-cells = <2>; + compatible = "fsl,mc9s08qg8-mpc8349emitx", + "fsl,mcu-mpc8349emitx"; + reg = <0x0a>; + gpio-controller; + }; + + x) Freescale Localbus UPM programmed to work with NAND flash + + Required properties: + - #address-cells : should be 0; + - #size-cells : should be 0; + - compatible : "fsl,upm-nand". + - reg : should specify localbus chip select and size used for the chip. + - fsl,upm-addr-offset : UPM pattern offset for the address latch. + - fsl,upm-cmd-offset : UPM pattern offset for the command latch. + - gpios : may specify optional GPIO connected to the Ready-Not-Busy pin. + + Example: + + upm@1,0 { + #address-cells = <0>; + #size-cells = <0>; + compatible = "fsl,upm-nand"; + reg = <1 0 1>; + fsl,upm-addr-offset = <16>; + fsl,upm-cmd-offset = <8>; + gpios = <&qe_pio_e 18 0>; + + flash { + #address-cells = <1>; + #size-cells = <1>; + compatible = "stmicro,NAND512W3A2BN6E"; + + partition@0 { + ... + }; + }; + }; + VII - Marvell Discovery mv64[345]6x System Controller chips ===========================================================
Signature · 1 line
1.5.5.1
Re: [PATCH 6/6] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings
Hi Anton,
Quoted 137 lines · Anton Vorontsov
This patch adds few bindings for the new drivers to be submitted through appropriate maintainers.
Signed-off-by Anton Vorontsov <[email protected]>--- Documentation/powerpc/booting-without-of.txt | 125 ++++++++++++++++++++++++++ 1 files changed, 125 insertions(+), 0 deletions(-)Documentation/powerpc/booting-without-of.txt +114
-0@@ -61,6 +61,10 @@ Table of Contents r) Freescale Display Interface Unit s) Freescale on board FPGA t) Freescale General-purpose Timers Module + u) Freescale QUICC Engine USB Controller + v) LEDs on GPIOs + w) Freescale MCU with MPC8349E-mITX compatible firmware + x) Freescale Localbus UPM programmed to work with NAND flash VII - Marvell Discovery mv64[345]6x System Controller chips 1) The /system-controller node@@ -2916,6 +2920,127 @@ platforms are moved over to use the flattened-device-tree model. clock-frequency = <0>; }; + u) Freescale QUICC Engine USB Controller + + Required properties: + - compatible : should be "fsl,<chip>-qe-usb", "fsl,mpc8323-qe-usb"; + - reg : the first two cells should contain gtm registers location and + length, the next two two cells should contain PRAM location and + length. + - interrupts : should contain USB interrupt. + - interrupt-parent : interrupt source phandle. + - fsl,fullspeed-clock : specifies the full speed USB clock source in + "clk<num>" or "brg<num>" format. + - fsl,lowspeed-clock : specifies the low speed USB clock source in + "clk<num>" or "brg<num>" format. + - fsl,usb-mode : should be "host". + - linux,hub-power-budget : optional, USB power budget for the root hub + in mA. + - gpios : should specify GPIOs in this order: USBOE, USBTP, USBTN, USBRP, + USBRN, SPEED (optional), and POWER (optional). + + Example: + + usb@6c0 { + compatible = "fsl,mpc8360-qe-usb", "fsl,mpc8323-qe-usb"; + reg = <0x6c0 0x40 0x8b00 0x100>; + interrupts = <11>; + interrupt-parent = <&qeic>; + fsl,fullspeed-clock = "clk21"; + fsl,usb-mode = "host"; + gpios = <&qe_pio_b 2 0 /* USBOE */ + &qe_pio_b 3 0 /* USBTP */ + &qe_pio_b 8 0 /* USBTN */ + &qe_pio_b 9 0 /* USBRP */ + &qe_pio_b 11 0 /* USBRN */ + &qe_pio_e 20 0 /* SPEED */ + &qe_pio_e 21 0 /* POWER */>; + }; + + v) LEDs on GPIOs + + Required properties: + - compatible : should be "linux,gpio-led". + - linux,name : LED name. + - linux,active-low : property should be present if LED wired as + active-low. + - linux,default-trigger : Linux default trigger for this LED. + - linux,brightness : default brightness. + - gpios : should specify LED GPIO. + + Example: + + led@0 { + compatible = "linux,gpio-led"; + linux,name = "pwr"; + linux,brightness = <1>; + linux,active-low; + gpios = <&mcu_pio 0>; + }; + + led@1 { + compatible = "linux,gpio-led"; + linux,name = "hdd"; + linux,default-trigger = "ide-disk"; + linux,active-low; + gpios = <&mcu_pio 1>; + }; + + w) Freescale MCU with MPC8349E-mITX compatible firmware + + Required properties: + - compatible : "fsl,<mcu-chip>-<board>", "fsl,mcu-mpc8349emitx"; + - reg : should specify I2C address (0x0a). + - #address-cells : should be 0. + - #size-cells : should be 0. + - #gpio-cells : should be 2. + - gpio-controller : should be present; + + Example: + + mcu_pio: mcu@0a { + #address-cells = <0>; + #size-cells = <0>; + #gpio-cells = <2>; + compatible = "fsl,mc9s08qg8-mpc8349emitx", + "fsl,mcu-mpc8349emitx"; + reg = <0x0a>; + gpio-controller; + }; + + x) Freescale Localbus UPM programmed to work with NAND flash + + Required properties: + - #address-cells : should be 0; + - #size-cells : should be 0; + - compatible : "fsl,upm-nand". + - reg : should specify localbus chip select and size used for the chip. + - fsl,upm-addr-offset : UPM pattern offset for the address latch. + - fsl,upm-cmd-offset : UPM pattern offset for the command latch. + - gpios : may specify optional GPIO connected to the Ready-Not-Busy pin. + + Example: + + upm@1,0 { + #address-cells = <0>; + #size-cells = <0>; + compatible = "fsl,upm-nand"; + reg = <1 0 1>; + fsl,upm-addr-offset = <16>; + fsl,upm-cmd-offset = <8>; + gpios = <&qe_pio_e 18 0>; +
Documentation/powerpc/booting-without-of.txt platforms are moved over to use the flattened-device-tree model. · line 3042
Quoted 10 lines
Documentation/powerpc/booting-without-of.txt +10
-0+ flash { + #address-cells = <1>; + #size-cells = <1>; + compatible = "stmicro,NAND512W3A2BN6E"; + + partition@0 { + ... + }; + }; + };
Where can I find the code for that binding? fsl_upm_nand.c from
http://patchwork.ozlabs.org/linuxppc/patch?q=upm&id=17306 does not parse OF partitions. Are there any plans to push the fsl_upm_nand driver upstream? I'm currently implementing NAND support for the TQM8548 and want to base it on common code.
Thanks,
Wolfgang.
Re: [PATCH 6/6] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings
Quoted 1 line · Wolfgang Grandegger
Hi Anton,
[...]
Quoted 16 lines
Quoted 16 lines
(quoted diff) +16
-0+ upm@1,0 { + #address-cells = <0>; + #size-cells = <0>; + compatible = "fsl,upm-nand"; + reg = <1 0 1>; + fsl,upm-addr-offset = <16>; + fsl,upm-cmd-offset = <8>; + gpios = <&qe_pio_e 18 0>; + + flash { + #address-cells = <1>; + #size-cells = <1>; + compatible = "stmicro,NAND512W3A2BN6E"; + + partition@0 { + ...
Quoted 8 lines
Review
Quoted 3 lines
(quoted diff) +3
-0+ }; + }; + };Where can I find the code for that binding?
fsl_upm_nand.cfrom
http://patchwork.ozlabs.org/linuxppc/patch?q=upm&id=17306 does not parse OF partitions. Are there any plans to push thefsl_upm_nanddriver upstream?
David already pushed UPM NAND driver upstream, but true, it was an "old" version, i.e. without approved bindings. I'll send the update (inlining here) if/when these bindings will be applied to the powerpc tree.
- - - -
From: Anton Vorontsov <[email protected]>
Subject: [NAND] update FSL UPM NAND driver for the new OF bindings
- get rid of fsl,wait-pattern and fsl,wait-write. I think this isn't chip-specific, and we should always do waits. I saw one board that didn't need fsl,wait-pattern, but I assume it was exception that proves general rule;
- get rid of chip-delay. Today there are no users for this, and if anyone really need this they should push the OF bindings beforehand;
- Now flash chips should be child nodes of the FSL UPM nand controller;
- Implement OF partition parsing.
--- drivers/mtd/nand/fsl_upm.c | 62 +++++++++++++++++++++++++++----------------- 1 files changed, 38 insertions(+), 24 deletions(-)
drivers/mtd/nand/fsl_upm.c +38 -24
@@ -36,9 +36,6 @@ struct fsl_upm_nand {uint8_t upm_cmd_offset;void __iomem *io_base;int rnb_gpio; -const uint32_t *wait_pattern; -const uint32_t *wait_write; -int chip_delay; };#define to_fsl_upm_nand (mtd) container_of(mtd, struct fsl_upm_nand, mtd)
@@ -89,8 +86,7 @@ static void fun_cmd_ctrl(struct mtd_info *mtd, int cmd, unsigned int ctrl)fsl_upm_run_pattern (&fun->upm, fun->io_base, cmd); -if (fun->wait_pattern) -fun_wait_rnb (fun); +fun_wait_rnb (fun); }static uint8_t fun_read_byte (struct mtd_info *mtd)
@@ -116,14 +112,16 @@ static void fun_write_buf(struct mtd_info *mtd, const uint8_t *buf, int len)for (i =0 ; i < len; i++) {out_8 (fun->chip.IO_ADDR_W, buf[i]); -if (fun->wait_write) -fun_wait_rnb (fun); +fun_wait_rnb (fun); } } -static int __devinit fun_chip_init (struct fsl_upm_nand *fun) +static int __devinit fun_chip_init (struct fsl_upm_nand *fun, +const struct device_node *upm_np, +const struct resource *io_res) {int ret; +struct device_node *flash_np;#ifdef CONFIG_MTD_PARTITIONS static const char *part_types[] = {"cmdlinepart" ,NULL , };#endif
@@ -131,7 +129,7 @@ static int __devinit fun_chip_init(struct fsl_upm_nand *fun) fun->chip.IO_ADDR_R = fun->io_base; fun->chip.IO_ADDR_W = fun->io_base; fun->chip.cmd_ctrl = fun_cmd_ctrl; - fun->chip.chip_delay = fun->chip_delay; + fun->chip.chip_delay =50 ; fun->chip.read_byte = fun_read_byte; fun->chip.read_buf = fun_read_buf; fun->chip.write_buf = fun_write_buf;
@@ -143,18 +141,42 @@ static int __devinit fun_chip_init(struct fsl_upm_nand *fun) fun->mtd.priv = &fun->chip; fun->mtd.owner =THIS_MODULE ; + flash_np =of_get_next_child (upm_np,NULL ); +if (!flash_np) +return -ENODEV ; + + fun->mtd.name =kasprintf (GFP_KERNEL ,"%x.%s" , io_res->start, + flash_np->name); +if (!fun->mtd.name) { + ret = -ENOMEM ; + goto err; + } + ret =nand_scan (&fun->mtd,1 );if (ret) -return ret; - - fun->mtd.name = fun->dev->bus_id; + goto err;#ifdef CONFIG_MTD_PARTITIONS ret =parse_mtd_partitions (&fun->mtd, part_types, &fun->parts,0 ); + +#ifdef CONFIG_MTD_OF_PARTS +if (ret <=0 ) { + ret =of_mtd_parse_partitions (fun->dev, &fun->mtd, + flash_np, &fun->parts); +if (ret <0 ) { + ret = -EINVAL ; + goto err; + } + } +#endif if (ret >0 ) -return add_mtd_partitions (&fun->mtd, fun->parts, ret); + ret =add_mtd_partitions (&fun->mtd, fun->parts, ret); + else#endif -return add_mtd_device (&fun->mtd); + ret =add_mtd_device (&fun->mtd); +err: +of_node_put (flash_np); +return ret; } static int __devinit fun_probe(struct of_device *ofdev,
@@ -220,17 +242,8 @@ static int __devinit fun_probe(struct of_device *ofdev, fun->dev = &ofdev->dev; fun->last_ctrl =NAND_CLE ; - fun->wait_pattern =of_get_property (ofdev->node,"fsl,wait-pattern" , -NULL ); - fun->wait_write =of_get_property (ofdev->node,"fsl,wait-write" ,NULL ); - - prop =of_get_property (ofdev->node,"chip-delay" ,NULL ); -if (prop) - fun->chip_delay = *prop; -else - fun->chip_delay =50 ; - ret =fun_chip_init (fun); + ret =fun_chip_init (fun, ofdev->node, &io_res);if (ret) goto err2;
@@ -251,6 +264,7 @@ static int __devexit fun_remove(struct of_device *ofdev)struct fsl_upm_nand *fun =dev_get_drvdata (&ofdev->dev);nand_release (&fun->mtd); +kfree (fun->mtd.name);if (fun->rnb_gpio >=0 )gpio_free (fun->rnb_gpio);
Signature · 1 line
1.5.5.1
Re: [PATCH 6/6] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings
Quoted 27 lines · Anton Vorontsov
Quoted 1 line · Wolfgang Grandegger
Hi Anton,
[...]
Quoted 15 lines
Quoted 15 lines
(quoted diff) +15
-0+ upm@1,0 { + #address-cells = <0>; + #size-cells = <0>; + compatible = "fsl,upm-nand"; + reg = <1 0 1>; + fsl,upm-addr-offset = <16>; + fsl,upm-cmd-offset = <8>; + gpios = <&qe_pio_e 18 0>; + + flash { + #address-cells = <1>; + #size-cells = <1>; + compatible = "stmicro,NAND512W3A2BN6E"; + + partition@0 {Quoted 8 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ ... + }; + }; + };Where can I find the code for that binding?
fsl_upm_nand.cfrom
http://patchwork.ozlabs.org/linuxppc/patch?q=upm&id=17306 does not parse OF partitions. Are there any plans to push thefsl_upm_nanddriver upstream?
Quoted 3 lines
David already pushed UPM NAND driver upstream, but true, it was an "old" version, i.e. without approved bindings. I'll send the update (inlining here) if/when these bindings will be applied to the powerpc tree.
OK, thanks a lot.
Quoted 4 lines
- - - -
From: Anton Vorontsov <[email protected]>
Subject: [NAND] update FSL UPM NAND driver for the new OF bindings
Quoted 8 lines
- get rid of fsl,wait-pattern and fsl,wait-write. I think this isn't chip-specific, and we should always do waits. I saw one board that didn't need fsl,wait-pattern, but I assume it was exception that proves general rule;
- get rid of chip-delay. Today there are no users for this, and if anyone really need this they should push the OF bindings beforehand;
- Now flash chips should be child nodes of the FSL UPM nand controller;
- Implement OF partition parsing.
On what hardware did you test the NAND-UPM driver? Unfortunately, the TQM8548 does not support the R/B pin and therefore GPIO support is not needed but a chip delay. Furthermore some "asm sync" are required when executing the run pattern:
static inline int fsl_upm_run_pattern(struct fsl_upm *upm,
void __iomem *io_base, u32 mar)
{
int ret = 0, i;
unsigned long flags; spin_lock_irqsave(&fsl_lbc_lock, flags);
out_be32(&fsl_lbc_regs->mar, mar << (32 - upm->width));
asm("sync; isync; msync");
switch (upm->width) {
case 8:
out_8(io_base, 0x0);
break;
case 16:
out_be16(io_base, 0x0);
break;
case 32:
out_be32(io_base, 0x0);
break;
default:
ret = -EINVAL;
break;
}
asm("sync; isync; msync");
spin_unlock_irqrestore(&fsl_lbc_lock, flags);
return ret;}
Is this a known problem with the MPC85xx? How do we handle it?
Wolfgang.
Re: [PATCH 6/6] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings
Quoted 47 lines · Wolfgang Grandegger
Quoted 27 lines · Anton Vorontsov
Quoted 1 line · Wolfgang Grandegger
Hi Anton,
[...]
Quoted 15 lines
Quoted 15 lines
(quoted diff) +15
-0+ upm@1,0 { + #address-cells = <0>; + #size-cells = <0>; + compatible = "fsl,upm-nand"; + reg = <1 0 1>; + fsl,upm-addr-offset = <16>; + fsl,upm-cmd-offset = <8>; + gpios = <&qe_pio_e 18 0>; + + flash { + #address-cells = <1>; + #size-cells = <1>; + compatible = "stmicro,NAND512W3A2BN6E"; + + partition@0 {Quoted 8 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ ... + }; + }; + };Where can I find the code for that binding?
fsl_upm_nand.cfrom
http://patchwork.ozlabs.org/linuxppc/patch?q=upm&id=17306 does not parse OF partitions. Are there any plans to push thefsl_upm_nanddriver upstream?Quoted 3 lines
David already pushed UPM NAND driver upstream, but true, it was an "old" version, i.e. without approved bindings. I'll send the update (inlining here) if/when these bindings will be applied to the powerpc tree.
OK, thanks a lot.
Quoted 4 lines
- - - -
From: Anton Vorontsov <[email protected]>
Subject: [NAND] update FSL UPM NAND driver for the new OF bindingsQuoted 8 lines
- get rid of fsl,wait-pattern and fsl,wait-write. I think this isn't chip-specific, and we should always do waits. I saw one board that didn't need fsl,wait-pattern, but I assume it was exception that proves general rule;
- get rid of chip-delay. Today there are no users for this, and if anyone really need this they should push the OF bindings beforehand;
- Now flash chips should be child nodes of the FSL UPM nand controller;
- Implement OF partition parsing.
Quoted 4 lines
On what hardware did you test the NAND-UPM driver? Unfortunately, the TQM8548 does not support the R/B pin and therefore GPIO support is not needed but a chip delay. Furthermore some "asm sync" are required when executing the run pattern:
Too bad you need this. Oh well, you need to discuss property name with the OF guys, or think out some other way to deliver the chip delay value.
Quoted 32 lines
static inline int fsl_upm_run_pattern(struct fsl_upm *upm, void __iomem *io_base, u32 mar) { int ret = 0, i; unsigned long flags;spin_lock_irqsave(&fsl_lbc_lock, flags); out_be32(&fsl_lbc_regs->mar, mar << (32 - upm->width)); asm("sync; isync; msync"); switch (upm->width) { case 8: out_8(io_base, 0x0); break; case 16: out_be16(io_base, 0x0); break; case 32: out_be32(io_base, 0x0); break; default: ret = -EINVAL; break; } asm("sync; isync; msync"); spin_unlock_irqrestore(&fsl_lbc_lock, flags); return ret;
Quoted 4 lines
}
Is this a known problem with the MPC85xx? How do we handle it?
I did test this driver on MPC8555 and MPC8360 UPMs. They didn't need these syncs.. quite suspicious syncs, I must say. Maybe you should check TLB setup, for the UPM NAND it should be non-cacheable and guarded, IIRC.
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Re: [PATCH 6/6] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings
Quoted 45 lines · Anton Vorontsov
Quoted 44 lines · Wolfgang Grandegger
Quoted 26 lines · Anton Vorontsov
Quoted 1 line · Wolfgang Grandegger
Hi Anton,
[...]
Quoted 15 lines
Quoted 15 lines
(quoted diff) +15
-0+ upm@1,0 { + #address-cells = <0>; + #size-cells = <0>; + compatible = "fsl,upm-nand"; + reg = <1 0 1>; + fsl,upm-addr-offset = <16>; + fsl,upm-cmd-offset = <8>; + gpios = <&qe_pio_e 18 0>; + + flash { + #address-cells = <1>; + #size-cells = <1>; + compatible = "stmicro,NAND512W3A2BN6E"; + + partition@0 {Quoted 8 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ ... + }; + }; + };Where can I find the code for that binding?
fsl_upm_nand.cfrom
http://patchwork.ozlabs.org/linuxppc/patch?q=upm&id=17306 does not parse OF partitions. Are there any plans to push thefsl_upm_nanddriver upstream?Quoted 3 lines
David already pushed UPM NAND driver upstream, but true, it was an "old" version, i.e. without approved bindings. I'll send the update (inlining here) if/when these bindings will be applied to the powerpc tree.
OK, thanks a lot.
Quoted 12 lines
- - - -
From: Anton Vorontsov <[email protected]>
Subject: [NAND] update FSL UPM NAND driver for the new OF bindings- get rid of fsl,wait-pattern and fsl,wait-write. I think this isn't chip-specific, and we should always do waits. I saw one board that didn't need fsl,wait-pattern, but I assume it was exception that proves general rule;
- get rid of chip-delay. Today there are no users for this, and if anyone really need this they should push the OF bindings beforehand;
- Now flash chips should be child nodes of the FSL UPM nand controller;
- Implement OF partition parsing.
Quoted 8 lines
Quoted 4 lines
On what hardware did you test the NAND-UPM driver? Unfortunately, the TQM8548 does not support the R/B pin and therefore GPIO support is not needed but a chip delay. Furthermore some "asm sync" are required when executing the run pattern:
Too bad you need this. Oh well, you need to discuss property name with the OF guys, or think out some other way to deliver the chip delay value.
OK.
Quoted 35 lines
Quoted 35 lines
static inline int fsl_upm_run_pattern(struct fsl_upm *upm, void __iomem *io_base, u32 mar) { int ret = 0, i; unsigned long flags;spin_lock_irqsave(&fsl_lbc_lock, flags); out_be32(&fsl_lbc_regs->mar, mar << (32 - upm->width)); asm("sync; isync; msync"); switch (upm->width) { case 8: out_8(io_base, 0x0); break; case 16: out_be16(io_base, 0x0); break; case 32: out_be32(io_base, 0x0); break; default: ret = -EINVAL; break; } asm("sync; isync; msync"); spin_unlock_irqrestore(&fsl_lbc_lock, flags); return ret;}
Quoted 6 lines
Quoted 1 line
Is this a known problem with the MPC85xx? How do we handle it?
I did test this driver on MPC8555 and MPC8360 UPMs. They didn't need these syncs.. quite suspicious syncs, I must say. Maybe you should check TLB setup, for the UPM NAND it should be non-cacheable and guarded, IIRC.
I have that. Are you sure about the e500 CPUs. I have not seen any MPC85xx board in U-Boot or Linux BSP using FSL UPM. Sometimes these magic sync instructions seem to be needed, e.g., in the MPC8548 manual I find:
"Also, an msync assembly instruction must be executed after each I2C
register read/write access to guarantee in-order execution."
Can somebody (from freescale?) sched some light on that issue?
TIA.
Wolfgang.