Skip to contentSkip to conversation

handle/report errors set by grub_device_iterate()

PATCH In review Robert Millan 1 participant 2 messages Aug 14, 2008 – Aug 16, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 handle/report errors set by grub_device_iterate()

Hi,

After Felix's grub_print_error() fix, it is now possible to handle and report errors properly in raid. This patch enables that.

Signature · 5 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

2008-08-14 Robert Millan <[email protected]>

* disk/raid.c (grub_raid_init): Handle/report errors set by grub_device_iterate().

raid.c +6 -0
Index: disk/raid.c
===================================================================
@@ -580,6 +580,12 @@ static struct grub_disk_dev grub_raid_de
 GRUB_MOD_INIT(raid)
 {
   grub_device_iterate (&grub_raid_scan_device);
+  if (grub_errno)
+    {
+      grub_print_error ();
+      grub_errno = GRUB_ERR_NONE;
+    }
+
   grub_disk_dev_register (&grub_raid_dev);
 }
 
#1 lore raw

Committed. Same for disk/lvm.c as well.

Quoted 40 lines · Robert Millan

Hi,

After Felix's grub_print_error() fix, it is now possible to handle and report errors properly in raid. This patch enables that.

Signature · 13 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

2008-08-14  Robert Millan  <[email protected]>

	* disk/raid.c (grub_raid_init): Handle/report errors set by
	grub_device_iterate().

Index: disk/raid.c
===================================================================
raid.c +6 -0
@@ -580,6 +580,12 @@ static struct grub_disk_dev grub_raid_de
 GRUB_MOD_INIT(raid)
 {
   grub_device_iterate (&grub_raid_scan_device);
+  if (grub_errno)
+    {
+      grub_print_error ();
+      grub_errno = GRUB_ERR_NONE;
+    }
+
   grub_disk_dev_register (&grub_raid_dev);
 }
 

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

Signature · 5 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."