TQM5200 HIGHBOOT Makefile patch
PATCH 1/1 TQM5200 HIGHBOOT Makefile patch
Hi,
I don't know the normal procedure, if I should send the patch to Wolfgang or someone else, but I found a problem with Makefile and TQM5200 HIGHBOOT config in Makefile. I think this problem is also in previous versions since tqm boards where moved under tqc folder.
The patch is:
Makefile +1 -1
@@ -755,7 +755,7 @@ echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \ } @[ -z "$(findstring HIGHBOOT,$@)" ] || \ - { echo "TEXT_BASE = 0xFFF00000">$(obj)board/tqm5200/config.tmp ; \ + { echo "TEXT_BASE = 0xFFF00000">$(obj)board/tqc/tqm5200/config.tmp ; \ } @$(MKCONFIG) -n $@ -a TQM5200 ppc mpc5xxx tqm5200 tqc
Regards,
Pedro.
_________________________________________________________________
Prueba los prototipos de los ?ltimos en MSN Motor
http://motor.es.msn.com/
PATCH 1/1 TQM5200 HIGHBOOT Makefile patch
Hi Pedro,
Quoted 5 lines
Hi,
I don't know the normal procedure, if I should send the patch to Wolfgang or someone else, but I found a problem withMakefileand TQM5200 HIGHBOOT config inMakefile. I think this problem is also in previous versions since tqm boards where moved under tqc folder.
The normal procedure is to prepare a patch with git (use git-format-patch) against top of tree version so that it can be applied without any hassle (use git-send-email if you want to save a few iterations). Search the archives on more details on how to do this and be sure not to forget your Signed-off-by line.
Apart from that, the patch looks good.
Cheers
Detlev
Signature · 7 lines
If you currently have a 32-bit UNIX system, you are advised to trade it in for a 64-bit one sometime before the year 2106. -- Andrew S. Tanenbaum: Modern Operating Systems, 2nd Edition -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
PATCH 1/1 TQM5200 HIGHBOOT Makefile patch
In reply to Pedro Luis D. L.Dear "Pedro Luis D. L.",
Quoted 5 lines · In message <[email protected]> you wrote:
I don't know the normal procedure, if I should send the patch to Wolfgang o= r someone else, but I found a problem with
Makefileand TQM5200 HIGHBOOT co= nfig inMakefile. I think this problem is also in previous versions since t= qm boards where moved under tqc folder.
Please use a line length not longer than some 70+ characters.
Makefile line 760
Quoted 12 lines
The patch is:
Makefile +1
-1@@ -755,7 +755,7 @@ echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \ } @[ -z "$(findstring HIGHBOOT,$@)" ] || \ - { echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqm5200/config.tmp ; \ + { echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqc/tqm5200/config.tmp ; \ } @$(MKCONFIG) -n $@ -a TQM5200 ppc mpc5xxx tqm5200 tqc
Please re-submit after adding your Signed-off-by: line (and please follow the other instructions Detlev sent you).
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Were there fewer fools, knaves would starve. - Anonymous
PATCH 1/1 TQM5200 HIGHBOOT Makefile patch
Quoted 12 lines · On Sun, 7 Sep 2008 01:10:15 +0200 Wolfgang wrote:
Dear "Pedro Luis D. L.",
Quoted 5 lines · In message <[email protected]> you wrote:
I don't know the normal procedure, if I should send the patch to Wolfgang o= r someone else, but I found a problem with
Makefileand TQM5200 HIGHBOOT co= nfig inMakefile. I think this problem is also in previous versions since t= qm boards where moved under tqc folder.Please use a line length not longer than some 70+ characters.
Sorry, you told me before and I forgot. I use web email and can not change this option, so I have to do it manually.
Quoted 16 lines
Makefile line 760
Quoted 12 lines
The patch is:
Makefile +1
-1@@ -755,7 +755,7 @@ echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \ } @[ -z "$(findstring HIGHBOOT,$@)" ] || \ - { echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqm5200/config.tmp ; \ + { echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqc/tqm5200/config.tmp ; \ } @$(MKCONFIG) -n $@ -a TQM5200 ppc mpc5xxx tqm5200 tqcPlease re-submit after adding your Signed-off-by: line (and please follow the other instructions Detlev sent you).
I'll do it as fast as I can. I can't submit from my office, so I need to do it from home and had no time these days.
Regards,
Pedro.
_________________________________________________________________
Llega la nueva temporada. Consulta las nuevas tendencias en MSN Estilo
http://estilo.es.msn.com/moda/