Skip to contentSkip to conversation

ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR

PATCH Superseded Victor Gallardo 3 participants 5 messages Sep 9, 2008 – Sep 10, 2008 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR

On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.

---
v2:
- Add description for CFG_I2C_DTT_ADDR to README

 README               |    6 ++++++
 drivers/hwmon/lm75.c |    4 ++++
 2 files changed, 10 insertions(+), 0 deletions(-)
README +6 -0
index 37449d1..75d9329 100644
@@ -1392,6 +1392,12 @@ The following options need to be configured:
 		If defined, then this indicates the I2C bus number for the DTT.
 		If not defined, then U-Boot assumes that DTT is on I2C bus 0.
 
+		CFG_I2C_DTT_ADDR:
+
+		If defined, specifies the I2C address of the DTT device.
+		If not defined, then U-Boot uses predefined value for
+		specified DTT device.
+
 		CONFIG_FSL_I2C
 
 		Define this option if you want to use Freescale's I2C driver in
drivers/hwmon/lm75.c +4 -0
index 8051cb2..67a18f6 100644
@@ -38,7 +38,11 @@
 /*
  * Device code
  */
+#if defined(CFG_I2C_DTT_ADDR)
+#define DTT_I2C_DEV_CODE CFG_I2C_DTT_ADDR
+#else
 #define DTT_I2C_DEV_CODE 0x48			/* ON Semi's LM75 device */
+#endif
 #define DTT_READ_TEMP		0x0
 #define DTT_CONFIG		0x1
 #define DTT_TEMP_HYST		0x2
Signature · 1 line
1.5.5
#1 lore raw

PATCH v2 1/1 ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR

Victor,

Quoted 2 lines · Victor Gallardo

On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.

This patch is not really ppc4xx related, so please replace the "ppc4xx:" from the subject line with "DTT:".

Other than this:

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH v2 1/1 ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR

Hello Stefan,

Quoted 10 lines · Victor Gallardo
Quoted 2 lines

On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.

This patch is not really ppc4xx related, so please replace the "ppc4xx:" from the subject line with "DTT:".

Other than this:

Acked-by Stefan Roese sr at denx.de

You are correct. I should have used DTT instead. Sorry about that.

Wolfgang has accepted in his tree. Do I still need to resubmit to get it in your tree?

Thanks,

Victor Gallardo

#3 lore raw

PATCH v2 1/1 ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR

Quoted 11 lines · Victor Gallardo
Quoted 9 lines
Quoted 2 lines

On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.

This patch is not really ppc4xx related, so please replace the "ppc4xx:" from the subject line with "DTT:".

Other than this:

Acked-by Stefan Roese sr at denx.de

You are correct. I should have used DTT instead. Sorry about that.

No problem.

Quoted 2 lines

Wolfgang has accepted in his tree. Do I still need to resubmit to get it in your tree?

No, its ok. But please use the correct subject next time.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#4 lore raw

PATCH v2 1/1 ppc4xx: Allow DTT_I2C_DEV_CODE configured by CFG_I2C_DTT_ADDR

In reply to Victor Gallardo

Dear Victor Gallardo,

Quoted 10 lines · In message <[email protected]> you wrote:

On AMCC Arches board DTT_I2C_DEV_CODE is different then canyonlands and glacier.

---
v2:
- Add description for CFG_I2C_DTT_ADDR to README

 README               |    6 ++++++
 drivers/hwmon/lm75.c |    4 ++++
 2 files changed, 10 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The bad reputation UNIX has gotten is totally undeserved, laid on by
people who don't understand, who have not gotten in there  and  tried
anything."          -- Jim Joyce, owner of Jim Joyce's UNIX Bookstore